Fix overwrite default value image/file with NULL #10253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you set a default value for a config field type image/file and you save it. It won't set the default value in the database. Instead it will save NULL and so overwrite the default config. With this change the default value will be set as value. This is a replication of what used to be in of magento#5085
|
Hi @ajpevers I'll be reviewing this PR. Thanks for your contribution! |
magento-team
pushed a commit
that referenced
this pull request
Jul 18, 2017
magento-team
pushed a commit
that referenced
this pull request
Jul 18, 2017
[EngCom] Public Pull Requests - MAGETWO-70817: remove redundant else and use strict check #10271 - MAGETWO-70787: update phpserver to support versioned static urls #10250 - MAGETWO-70764: Fix overwrite default value image/file with NULL #10253 - MAGETWO-70761: Show values that are duplicate in attribute error msg #10213 - MAGETWO-70758: Fix for #4530 $product->getRatingSummary() always returns null […] #10248 - MAGETWO-70706: simplify product lists #2 #9019 - MAGETWO-70669: Fix fatal errors with deleteOptionsAndSelections #7711 - MAGETWO-70464: Fix shipping address can use for billing #10130 - MAGETWO-69913: magento/magento2 #9196 - Products ordered report doesn't show simple (child) products of configurable products #9908
|
Thanks for your contribution @ajpevers! |
magento-team
pushed a commit
that referenced
this pull request
Oct 10, 2017
…th NULL #10253 - for 2.2
magento-team
pushed a commit
that referenced
this pull request
Oct 10, 2017
…th NULL #10253 - for 2.2
magento-team
pushed a commit
that referenced
this pull request
Oct 10, 2017
…th NULL #10253 - for 2.2
magento-team
pushed a commit
that referenced
this pull request
Oct 10, 2017
Fixed issues: - MAGETWO-71552: Attribute values on store view level not searchable - for 2.2 - MAGETWO-72866: Redundant indexers invalidation - RIATCS-340 - MAGETWO-75458: [Backport] - Fix overwrite default value image/file with NULL #10253 - for 2.2 - MAGETWO-75460: [Backport] - LowestPriceOptionsProvider returns products without attributes which are used for price calculation (e.g. tax adjustment) - MAGETWO-80193: [2.2.x] - Add cast to string for CUST_GROUP_ALL #10475 - MAGETWO-80204: [2.2.x] - Grammar fix for #9533 #10627 - MAGETWO-71549: Impossible to export Advanced Prices on a medium profile - MAGETWO-80198: [2.2.x] - Fix issue #10565 #10575 - MAGETWO-80197: [2.2.x] - Fix JS translation search #10445 - MAGETWO-80195: [2.2.x] - Send different base currency in Google analytics #10508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set a default value for a config field type image/file and you save it. It won't set the default value in the database. Instead it will save NULL and so overwrite the default config.
With this change the default value will be set as value.
Description
This is a replication of #5085
Fixed Issues (if relevant)
Manual testing scenarios
Before the fix:
After the fix:
Contribution checklist