Phpdoc improvements #12257
Merged
Phpdoc improvements #12257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 14, 2017 21:53
param as optional set as false by default.
\Magento\Framework\Exception\LocalizedException
…Item() functions. Used Intl library for datetime handling: http://php.net/manual/en/book.intl.php
$this|\Magento\ImportExport\Model\Import\Entity\AbstractEntity Removed 'void' as declaration from _saveValidatedBunches() function as it shall return $this [\Magento\ImportExport\Model\Import\Entity\AbstractEntity]
order to use LocalizedException and reuse ObjectManager instead of classpath.
order to use LocalizedException.
KarlDeux
changed the title
magento-team
pushed a commit
that referenced
this pull request
Nov 16, 2017
- reverted some changes that were done incorrectly
magento-team
pushed a commit
that referenced
this pull request
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General tuning and phpdoc fixes for CatalogImportExport/Model/Import/Product.php and ImportExport/Model/Import/Entity/AbstractEntity.php
Description
The PR consist on a bunch of commits that improve the usage of classes and the coverage of PHPDoc.
Contribution checklist