From 738d5b3797ee4c7e7586ecee5e36c09f876cb3fd Mon Sep 17 00:00:00 2001
From: Yaroslav Rogoza <enarc@atwix.com>
Date: Wed, 25 Jul 2018 18:25:35 +0200
Subject: [PATCH 1/2] Added unit test for order success observer in GA

---
 ...ticsOnOrderSuccessPageViewObserverTest.php | 124 ++++++++++++++++++
 1 file changed, 124 insertions(+)
 create mode 100644 app/code/Magento/GoogleAnalytics/Test/Unit/Observer/SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php

diff --git a/app/code/Magento/GoogleAnalytics/Test/Unit/Observer/SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php b/app/code/Magento/GoogleAnalytics/Test/Unit/Observer/SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php
new file mode 100644
index 0000000000000..d1b1da51e87e9
--- /dev/null
+++ b/app/code/Magento/GoogleAnalytics/Test/Unit/Observer/SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php
@@ -0,0 +1,124 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\GoogleAnalytics\Test\Unit\Block;
+
+use Magento\Framework\Event;
+use Magento\Framework\Event\Observer;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use Magento\Framework\View\Element\AbstractBlock;
+use Magento\Framework\View\LayoutInterface;
+use Magento\GoogleAnalytics\Helper\Data as GaDataHelper;
+use Magento\GoogleAnalytics\Observer\SetGoogleAnalyticsOnOrderSuccessPageViewObserver;
+use Magento\Store\Model\StoreManagerInterface;
+use PHPUnit\Framework\TestCase;
+
+class SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest extends TestCase
+{
+    /**
+     * @var Event|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $eventMock;
+
+    /**
+     * @var Observer|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $observerMock;
+
+    /**
+     * @var GaDataHelper|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $googleAnalyticsDataMock;
+
+    /**
+     * @var LayoutInterface|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $layoutMock;
+
+    /**
+     * @var StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $storeManagerMock;
+
+    /**
+     * @var SetGoogleAnalyticsOnOrderSuccessPageViewObserver
+     */
+    private $orderSuccessObserver;
+
+    protected function setUp()
+    {
+        $this->googleAnalyticsDataMock = $this->getMockBuilder(GaDataHelper::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->storeManagerMock = $this->getMockBuilder(StoreManagerInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->layoutMock = $this->getMockBuilder(LayoutInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->observerMock = $this->getMockBuilder(Observer::class)->getMock();
+        $this->eventMock = $this->getMockBuilder(Event::class)->getMock();
+
+
+        $objectManager = new ObjectManager($this);
+
+        $this->orderSuccessObserver = $objectManager->getObject(
+            SetGoogleAnalyticsOnOrderSuccessPageViewObserver::class,
+            [
+                'storeManager' => $this->storeManagerMock,
+                'layout' => $this->layoutMock,
+                'googleAnalyticsData' => $this->googleAnalyticsDataMock
+            ]
+        );
+    }
+
+    public function testExecuteWithNoOrderIds()
+    {
+        $this->observerMock->expects($this->once())
+            ->method('getEvent')
+            ->willReturn($this->eventMock);
+        $this->eventMock->expects($this->once())
+            ->method('__call')
+            ->with(
+                $this->equalTo('getOrderIds')
+            )
+            ->willReturn([]);
+        $this->layoutMock->expects($this->never())
+            ->method('getBlock');
+
+        $this->orderSuccessObserver->execute($this->observerMock);
+    }
+
+    public function testExecuteWithOrderIds()
+    {
+        $blockMock = $this->getMockBuilder(AbstractBlock::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $orderIds = [8];
+
+        $this->observerMock->expects($this->once())
+            ->method('getEvent')
+            ->willReturn($this->eventMock);
+        $this->eventMock->expects($this->once())
+            ->method('__call')
+            ->with(
+                $this->equalTo('getOrderIds')
+            )
+            ->willReturn($orderIds);
+        $this->layoutMock->expects($this->once())
+            ->method('getBlock')
+            ->willReturn($blockMock);
+        $blockMock->expects($this->once())
+            ->method('__call')
+            ->with(
+                $this->equalTo('setOrderIds'),
+                $this->equalTo([$orderIds])
+            );
+
+        $this->orderSuccessObserver->execute($this->observerMock);
+    }
+}

From 67e2df5823c91a373cc7547a614c3d4a4edaa08f Mon Sep 17 00:00:00 2001
From: Yaroslav Rogoza <enarc@atwix.com>
Date: Wed, 25 Jul 2018 18:28:47 +0200
Subject: [PATCH 2/2] Removed extra empty line

---
 .../SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php     | 1 -
 1 file changed, 1 deletion(-)

diff --git a/app/code/Magento/GoogleAnalytics/Test/Unit/Observer/SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php b/app/code/Magento/GoogleAnalytics/Test/Unit/Observer/SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php
index d1b1da51e87e9..34f71dd53391d 100644
--- a/app/code/Magento/GoogleAnalytics/Test/Unit/Observer/SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php
+++ b/app/code/Magento/GoogleAnalytics/Test/Unit/Observer/SetGoogleAnalyticsOnOrderSuccessPageViewObserverTest.php
@@ -63,7 +63,6 @@ protected function setUp()
         $this->observerMock = $this->getMockBuilder(Observer::class)->getMock();
         $this->eventMock = $this->getMockBuilder(Event::class)->getMock();
 
-
         $objectManager = new ObjectManager($this);
 
         $this->orderSuccessObserver = $objectManager->getObject(