From 8b623a428414793298b4386d56bd288c2ed9e868 Mon Sep 17 00:00:00 2001 From: Tiago Sampaio Date: Wed, 2 Jan 2019 12:58:40 -0200 Subject: [PATCH 1/2] Added constants to unit codes to make it easier to reuse it if necessary. --- .../Directory/Model/Config/Source/WeightUnit.php | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/Directory/Model/Config/Source/WeightUnit.php b/app/code/Magento/Directory/Model/Config/Source/WeightUnit.php index 4e2758b362a43..6c0c50d620146 100644 --- a/app/code/Magento/Directory/Model/Config/Source/WeightUnit.php +++ b/app/code/Magento/Directory/Model/Config/Source/WeightUnit.php @@ -3,6 +3,7 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ + namespace Magento\Directory\Model\Config\Source; /** @@ -13,11 +14,24 @@ */ class WeightUnit implements \Magento\Framework\Option\ArrayInterface { + /** + * @var string + */ + const CODE_LBS = 'lbs'; + + /** + * @var string + */ + const CODE_KGS = 'kgs'; + /** * {@inheritdoc} */ public function toOptionArray() { - return [['value' => 'lbs', 'label' => __('lbs')], ['value' => 'kgs', 'label' => __('kgs')]]; + return [ + ['value' => self::CODE_LBS, 'label' => __('lbs')], + ['value' => self::CODE_KGS, 'label' => __('kgs')] + ]; } } From e2d6f1aead1ffa5ae5818a7f0c8c7bae5596423f Mon Sep 17 00:00:00 2001 From: Pavel Bystritsky Date: Thu, 3 Jan 2019 13:09:11 +0200 Subject: [PATCH 2/2] ENGCOM-3774: Static test fix. --- app/code/Magento/Directory/Model/Config/Source/WeightUnit.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Directory/Model/Config/Source/WeightUnit.php b/app/code/Magento/Directory/Model/Config/Source/WeightUnit.php index 6c0c50d620146..97d22633af03c 100644 --- a/app/code/Magento/Directory/Model/Config/Source/WeightUnit.php +++ b/app/code/Magento/Directory/Model/Config/Source/WeightUnit.php @@ -25,7 +25,7 @@ class WeightUnit implements \Magento\Framework\Option\ArrayInterface const CODE_KGS = 'kgs'; /** - * {@inheritdoc} + * @inheritdoc */ public function toOptionArray() {