From d08ce919585c9f3e9020662eaf0948df260fbb4a Mon Sep 17 00:00:00 2001 From: Patrick McLain Date: Wed, 2 Jan 2019 20:19:07 -0500 Subject: [PATCH 1/2] Add missing throws to docblock Document the `InputException` thrown https://github.com/magento/magento2/blob/2.3.0/app/code/Magento/Catalog/Model/CategoryLinkRepository.php#L81 --- .../Magento/Catalog/Api/CategoryLinkRepositoryInterface.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php b/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php index 30ac06107ba1d..7f6fccf29c600 100644 --- a/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php +++ b/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php @@ -32,6 +32,7 @@ public function save(\Magento\Catalog\Api\Data\CategoryProductLinkInterface $pro * * @throws \Magento\Framework\Exception\CouldNotSaveException * @throws \Magento\Framework\Exception\StateException + * @throws \Magento\Framework\Exception\InputException */ public function delete(\Magento\Catalog\Api\Data\CategoryProductLinkInterface $productLink); @@ -44,6 +45,7 @@ public function delete(\Magento\Catalog\Api\Data\CategoryProductLinkInterface $p * * @throws \Magento\Framework\Exception\CouldNotSaveException * @throws \Magento\Framework\Exception\StateException + * @throws \Magento\Framework\Exception\InputException */ public function deleteByIds($categoryId, $sku); } From a1d3299191805ea5fbee133436fe82ccb6b9a5cd Mon Sep 17 00:00:00 2001 From: Pavel Bystritsky Date: Thu, 3 Jan 2019 12:51:56 +0200 Subject: [PATCH 2/2] ENGCOM-3780: Static test fix. --- .../Magento/Catalog/Api/CategoryLinkRepositoryInterface.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php b/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php index 7f6fccf29c600..34656d522a72c 100644 --- a/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php +++ b/app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php @@ -39,7 +39,7 @@ public function delete(\Magento\Catalog\Api\Data\CategoryProductLinkInterface $p /** * Remove the product assignment from the category by category id and sku * - * @param string $sku + * @param string $categoryId * @param string $sku * @return bool will returned True if products successfully deleted *