From de600a6f2127dedcaf978d9e8ccf55ffd25a4a45 Mon Sep 17 00:00:00 2001 From: Oleh Usik Date: Mon, 15 Feb 2021 17:24:48 +0200 Subject: [PATCH 1/2] MArked as api --- .../Magento/AdvancedSearch/Block/SearchDataInterface.php | 3 +++ app/code/Magento/Analytics/Api/Data/LinkInterface.php | 4 ++++ app/code/Magento/Analytics/Api/LinkProviderInterface.php | 4 ++++ .../Magento/Analytics/Model/Connector/CommandInterface.php | 4 ++++ .../Magento/Analytics/Model/ExportDataHandlerInterface.php | 4 ++++ app/code/Magento/Analytics/Model/ReportWriterInterface.php | 4 ++++ .../ReportXml/DB/Assembler/AssemblerInterface.php | 4 ++++ .../Backend/Model/Image/UploadResizeConfigInterface.php | 2 ++ .../Search/Config/Structure/ElementBuilderInterface.php | 7 +++++++ .../Pricing/Adjustment/BundleCalculatorInterface.php | 3 +++ .../CardinalCommerce/Model/Response/JwtParserInterface.php | 3 +++ .../Model/Response/JwtPayloadValidatorInterface.php | 3 +++ 12 files changed, 45 insertions(+) diff --git a/app/code/Magento/AdvancedSearch/Block/SearchDataInterface.php b/app/code/Magento/AdvancedSearch/Block/SearchDataInterface.php index 299e68e558ad5..79008737ebe7d 100644 --- a/app/code/Magento/AdvancedSearch/Block/SearchDataInterface.php +++ b/app/code/Magento/AdvancedSearch/Block/SearchDataInterface.php @@ -3,11 +3,14 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); + namespace Magento\AdvancedSearch\Block; /** * Interface \Magento\AdvancedSearch\Block\SearchDataInterface * + * @api */ interface SearchDataInterface { diff --git a/app/code/Magento/Analytics/Api/Data/LinkInterface.php b/app/code/Magento/Analytics/Api/Data/LinkInterface.php index 81d0c279a62c3..276d96f44d36f 100644 --- a/app/code/Magento/Analytics/Api/Data/LinkInterface.php +++ b/app/code/Magento/Analytics/Api/Data/LinkInterface.php @@ -3,10 +3,14 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); + namespace Magento\Analytics\Api\Data; /** * Represents link with collected data and initialized vector for decryption. + * + * @api */ interface LinkInterface { diff --git a/app/code/Magento/Analytics/Api/LinkProviderInterface.php b/app/code/Magento/Analytics/Api/LinkProviderInterface.php index 6ee43a423337e..100d97a741bfe 100644 --- a/app/code/Magento/Analytics/Api/LinkProviderInterface.php +++ b/app/code/Magento/Analytics/Api/LinkProviderInterface.php @@ -3,10 +3,14 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); + namespace Magento\Analytics\Api; /** * Provides link to file with collected report data. + * + * @api */ interface LinkProviderInterface { diff --git a/app/code/Magento/Analytics/Model/Connector/CommandInterface.php b/app/code/Magento/Analytics/Model/Connector/CommandInterface.php index 7a8774fe3dba9..e8f25df986fe2 100644 --- a/app/code/Magento/Analytics/Model/Connector/CommandInterface.php +++ b/app/code/Magento/Analytics/Model/Connector/CommandInterface.php @@ -3,11 +3,15 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); + namespace Magento\Analytics\Model\Connector; /** * Introduces family of integration calls. * Each implementation represents call to external service. + * + * @api */ interface CommandInterface { diff --git a/app/code/Magento/Analytics/Model/ExportDataHandlerInterface.php b/app/code/Magento/Analytics/Model/ExportDataHandlerInterface.php index 65efb33659c89..596beff48c65e 100644 --- a/app/code/Magento/Analytics/Model/ExportDataHandlerInterface.php +++ b/app/code/Magento/Analytics/Model/ExportDataHandlerInterface.php @@ -3,10 +3,14 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); + namespace Magento\Analytics\Model; /** * The interface represents the type of classes that handling of a new data collection for MBI. + * + * @api */ interface ExportDataHandlerInterface { diff --git a/app/code/Magento/Analytics/Model/ReportWriterInterface.php b/app/code/Magento/Analytics/Model/ReportWriterInterface.php index a611095a47ae4..bc8c3d6f4fb8e 100644 --- a/app/code/Magento/Analytics/Model/ReportWriterInterface.php +++ b/app/code/Magento/Analytics/Model/ReportWriterInterface.php @@ -3,6 +3,8 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); + namespace Magento\Analytics\Model; use Magento\Framework\Filesystem\Directory\WriteInterface; @@ -14,6 +16,8 @@ * Executes export of collected data * Iterates registered providers @see etc/analytics.xml * Collects data (to TMP folder) + * + * @api */ interface ReportWriterInterface { diff --git a/app/code/Magento/Analytics/ReportXml/DB/Assembler/AssemblerInterface.php b/app/code/Magento/Analytics/ReportXml/DB/Assembler/AssemblerInterface.php index 083b4843c185a..7de22cc350365 100644 --- a/app/code/Magento/Analytics/ReportXml/DB/Assembler/AssemblerInterface.php +++ b/app/code/Magento/Analytics/ReportXml/DB/Assembler/AssemblerInterface.php @@ -3,6 +3,8 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); + namespace Magento\Analytics\ReportXml\DB\Assembler; use Magento\Analytics\ReportXml\DB\SelectBuilder; @@ -13,6 +15,8 @@ * Introduces family of SQL assemblers * Each assembler populates SelectBuilder with config information * @see usage examples at \Magento\Analytics\ReportXml\QueryFactory + * + * @api */ interface AssemblerInterface { diff --git a/app/code/Magento/Backend/Model/Image/UploadResizeConfigInterface.php b/app/code/Magento/Backend/Model/Image/UploadResizeConfigInterface.php index 50582dfafbcd1..6f3c2fa02209a 100644 --- a/app/code/Magento/Backend/Model/Image/UploadResizeConfigInterface.php +++ b/app/code/Magento/Backend/Model/Image/UploadResizeConfigInterface.php @@ -11,6 +11,8 @@ * Interface UploadResizeConfigInterface * * Used to retrieve configuration for frontend image uploader + * + * @api */ interface UploadResizeConfigInterface { diff --git a/app/code/Magento/Backend/Model/Search/Config/Structure/ElementBuilderInterface.php b/app/code/Magento/Backend/Model/Search/Config/Structure/ElementBuilderInterface.php index 86b796355946d..4bced00929c89 100644 --- a/app/code/Magento/Backend/Model/Search/Config/Structure/ElementBuilderInterface.php +++ b/app/code/Magento/Backend/Model/Search/Config/Structure/ElementBuilderInterface.php @@ -3,10 +3,17 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); + namespace Magento\Backend\Model\Search\Config\Structure; use Magento\Config\Model\Config\StructureElementInterface; +/** + * Element builder interface + * + * @api + */ interface ElementBuilderInterface { /** diff --git a/app/code/Magento/Bundle/Pricing/Adjustment/BundleCalculatorInterface.php b/app/code/Magento/Bundle/Pricing/Adjustment/BundleCalculatorInterface.php index 491d7d92b4679..56f018721288d 100644 --- a/app/code/Magento/Bundle/Pricing/Adjustment/BundleCalculatorInterface.php +++ b/app/code/Magento/Bundle/Pricing/Adjustment/BundleCalculatorInterface.php @@ -3,6 +3,7 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); namespace Magento\Bundle\Pricing\Adjustment; @@ -11,6 +12,8 @@ /** * Bundle calculator interface + * + * @api */ interface BundleCalculatorInterface extends CalculatorInterface { diff --git a/app/code/Magento/CardinalCommerce/Model/Response/JwtParserInterface.php b/app/code/Magento/CardinalCommerce/Model/Response/JwtParserInterface.php index c6f9a5f60d10d..4cc51b02ce4df 100644 --- a/app/code/Magento/CardinalCommerce/Model/Response/JwtParserInterface.php +++ b/app/code/Magento/CardinalCommerce/Model/Response/JwtParserInterface.php @@ -3,11 +3,14 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); namespace Magento\CardinalCommerce\Model\Response; /** * Parses content of CardinalCommerce response JWT. + * + * @api */ interface JwtParserInterface { diff --git a/app/code/Magento/CardinalCommerce/Model/Response/JwtPayloadValidatorInterface.php b/app/code/Magento/CardinalCommerce/Model/Response/JwtPayloadValidatorInterface.php index 774c0daee6ca2..5a5f8a07f0bfc 100644 --- a/app/code/Magento/CardinalCommerce/Model/Response/JwtPayloadValidatorInterface.php +++ b/app/code/Magento/CardinalCommerce/Model/Response/JwtPayloadValidatorInterface.php @@ -3,11 +3,14 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ +declare(strict_types=1); namespace Magento\CardinalCommerce\Model\Response; /** * Validates payload of CardinalCommerce response JWT. + * + * @api */ interface JwtPayloadValidatorInterface { From 5f31c5ce4edc7dd303a1a39ce1ba7e000bf63ded Mon Sep 17 00:00:00 2001 From: Oleh Usik Date: Thu, 25 Feb 2021 18:11:11 +0200 Subject: [PATCH 2/2] fixed static failed test --- app/code/Magento/Analytics/ReportXml/DB/SelectBuilder.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/code/Magento/Analytics/ReportXml/DB/SelectBuilder.php b/app/code/Magento/Analytics/ReportXml/DB/SelectBuilder.php index b4b7adebf7459..88b91904cf493 100644 --- a/app/code/Magento/Analytics/ReportXml/DB/SelectBuilder.php +++ b/app/code/Magento/Analytics/ReportXml/DB/SelectBuilder.php @@ -13,6 +13,8 @@ * Responsible for Select object creation, works as a builder. Returns Select as result; * * Used in SQL assemblers. + * + * @api */ class SelectBuilder {