From c05293c5895e169843d27423eae626a7b454932e Mon Sep 17 00:00:00 2001 From: dverkade Date: Tue, 27 Sep 2016 16:21:06 +0200 Subject: [PATCH] Changed constructor to use an interface The front controller only accepts an HTTP response object. The front controller now has a direct dependency on the Response\Http class, which is not correct. The front controller should not care which response object will be injected only that it will adhire the ResponseInterface. So changed this constructor to accept a ResponseInterface which in di.xml is being replaced by the Response\Http class. --- lib/internal/Magento/Framework/App/FrontController.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/internal/Magento/Framework/App/FrontController.php b/lib/internal/Magento/Framework/App/FrontController.php index 81a3e3f84379b..26c9f1948630f 100644 --- a/lib/internal/Magento/Framework/App/FrontController.php +++ b/lib/internal/Magento/Framework/App/FrontController.php @@ -15,17 +15,17 @@ class FrontController implements FrontControllerInterface protected $_routerList; /** - * @var \Magento\Framework\App\Response\Http + * @var \Magento\Framework\App\ResponseInterface */ protected $response; /** * @param RouterList $routerList - * @param \Magento\Framework\App\Response\Http $response + * @param \Magento\Framework\App\ResponseInterface $response */ public function __construct( RouterList $routerList, - \Magento\Framework\App\Response\Http $response + \Magento\Framework\App\ResponseInterface $response ) { $this->_routerList = $routerList; $this->response = $response;