Skip to content

refactor: remove commented code and unused file#364

Merged
meteyou merged 2 commits into
mainsail-crew:developfrom
mryel00:develop
May 14, 2026
Merged

refactor: remove commented code and unused file#364
meteyou merged 2 commits into
mainsail-crew:developfrom
mryel00:develop

Conversation

@mryel00
Copy link
Copy Markdown
Member

@mryel00 mryel00 commented May 13, 2026

In the past the kernel package had to be hold during the build process.
This got fixed at some point and the code got commented out, but not removed.
This PR removes this commented and unused code.

Signed-off-by: Patrick Gehrsitz <github@mryel.de>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eae9ae5f-2cc8-4908-9bc6-60eb7e0540a4

📥 Commits

Reviewing files that changed from the base of the PR and between cb9de0b and 41fe7a7.

📒 Files selected for processing (1)
  • modules/generic/files/00-config
💤 Files with no reviewable changes (1)
  • modules/generic/files/00-config

📝 Walkthrough

Walkthrough

Removes commented kernel hold lines from modules/generic/00-upgrade, deletes the contents of modules/generic/99-unhold-packages, and removes the exported HOLD_PKGS array from modules/generic/files/00-config.

Changes

Kernel hold/unhold removal

Layer / File(s) Summary
Upgrade script: remove commented hold
modules/generic/00-upgrade
Deleted the commented "hold linux kernel updates" header and the commented apt-mark hold line so the upgrade step now follows immediately after DEBIAN_FRONTEND setup.
Unhold module: contents removed
modules/generic/99-unhold-packages
Removed the file's script header, environment setup, /common.sh sourcing, /files/00-config sourcing, and the commented apt-mark unhold logic (module content deleted).
Config: remove HOLD_PKGS export
modules/generic/files/00-config
Removed the exported HOLD_PKGS=(...) array declaration; other config variables remain.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through scripts with gentle paws tonight,
Cleared commented holds and set the flow aright.
No held packages left, no unhold left to chase,
A tidy trail of changes—clean and full of grace. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: removing commented-out code and an unused file related to kernel package holding logic.
Description check ✅ Passed The description clearly explains the historical context and justification for removing the commented-out kernel package hold logic, directly relating to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Patrick Gehrsitz <github@mryel.de>
@meteyou meteyou merged commit a607941 into mainsail-crew:develop May 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants