Reduced logs for some log messages.

Marc Sowen · Marc Sowen · commit 6f940114e839 · 2021-12-29T16:54:48.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### Improvements
 
 - **HmIP-MOD**: Added "lightSwitch" config option to disable light switch if not available.
+- **General**: Reduced verbosity of log messages. Some frequent log messages have log level debug now.
 
 ### Bugfix
 
diff --git a/src/devices/HmIPBlind.ts b/src/devices/HmIPBlind.ts
@@ -2,7 +2,7 @@ import {CharacteristicGetCallback, CharacteristicSetCallback, CharacteristicValu
 
 import {HmIPPlatform} from '../HmIPPlatform';
 import {HmIPDevice, HmIPGroup, Updateable} from '../HmIPState';
-import {HmIPShutter} from "./HmIPShutter";
+import {HmIPShutter} from './HmIPShutter';
 
 interface BlindChannel {
   functionalChannelType: string;
@@ -66,9 +66,9 @@ export class HmIPBlind extends HmIPShutter implements Updateable {
         const blindChannel = <BlindChannel>channel;
 
         const slatsLevelHomeKit = HmIPBlind.slatsHmIPToHomeKit(blindChannel.slatsLevel);
-        if (slatsLevelHomeKit != this.slatsLevel) {
+        if (slatsLevelHomeKit !== this.slatsLevel) {
           this.slatsLevel = slatsLevelHomeKit;
-          this.platform.log.info('Current blind slats level of %s changed to %s°', this.accessory.displayName, this.slatsLevel.toFixed(0));
+          this.platform.log.debug('Current blind slats level of %s changed to %s°', this.accessory.displayName, this.slatsLevel.toFixed(0));
           this.service.updateCharacteristic(this.platform.Characteristic.CurrentHorizontalTiltAngle, this.slatsLevel);
           this.service.updateCharacteristic(this.platform.Characteristic.TargetHorizontalTiltAngle, this.slatsLevel);
         }
diff --git a/src/devices/HmIPClimateSensor.ts b/src/devices/HmIPClimateSensor.ts
@@ -67,13 +67,13 @@ export class HmIPClimateSensor extends HmIPGenericDevice implements Updateable {
 
         if (climateSensorChannel.actualTemperature !== this.actualTemperature) {
           this.actualTemperature = climateSensorChannel.actualTemperature;
-          this.platform.log.info('Current temperature of %s changed to %s °C', this.accessory.displayName, this.actualTemperature);
+          this.platform.log.debug('Current temperature of %s changed to %s °C', this.accessory.displayName, this.actualTemperature);
           this.temperatureService.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, this.actualTemperature);
         }
 
         if (climateSensorChannel.humidity !== this.humidity) {
           this.humidity = climateSensorChannel.humidity;
-          this.platform.log.info('Current relative humidity of %s changed to %s %%', this.accessory.displayName, this.humidity);
+          this.platform.log.debug('Current relative humidity of %s changed to %s %%', this.accessory.displayName, this.humidity);
           this.humidityService.updateCharacteristic(this.platform.Characteristic.CurrentRelativeHumidity, this.humidity);
         }
 
diff --git a/src/devices/HmIPDimmer.ts b/src/devices/HmIPDimmer.ts
@@ -102,7 +102,7 @@ export class HmIPDimmer extends HmIPGenericDevice implements Updateable {
           }
 
           this.brightness = brightness;
-          this.platform.log.info('Brightness of %s changed to %s %%', this.accessory.displayName, this.brightness.toFixed(0));
+          this.platform.log.debug('Brightness of %s changed to %s %%', this.accessory.displayName, this.brightness.toFixed(0));
           this.service.updateCharacteristic(this.platform.Characteristic.Brightness, this.brightness);
         }
       }
diff --git a/src/devices/HmIPDoorLockDrive.ts b/src/devices/HmIPDoorLockDrive.ts
@@ -113,7 +113,7 @@ export class HmIPDoorLockDrive extends HmIPGenericDevice implements Updateable {
 
         if (doorLockChannel.motorState !== null && doorLockChannel.motorState !== this.motorState) {
           this.motorState = doorLockChannel.motorState;
-          this.platform.log.info('Door lock drive motor state of %s changed to %s', this.accessory.displayName, this.motorState);
+          this.platform.log.debug('Door lock drive motor state of %s changed to %s', this.accessory.displayName, this.motorState);
           this.updateHmKitLockTargetState();
           this.service.updateCharacteristic(this.platform.Characteristic.LockTargetState, this.targetLockState);
         }
diff --git a/src/devices/HmIPGarageDoor.ts b/src/devices/HmIPGarageDoor.ts
@@ -43,7 +43,6 @@ export class HmIPGarageDoor extends HmIPGenericDevice implements Updateable {
   private service: Service;
   private switchService: Service | undefined;
 
-  private withLightSwitch = true;
   private currentDoorState: DoorState = DoorState.CLOSED;
   private previousDoorState: DoorState = DoorState.CLOSED;
   private processing = false;
@@ -56,8 +55,6 @@ export class HmIPGarageDoor extends HmIPGenericDevice implements Updateable {
   ) {
     super(platform, accessory);
 
-    this.withLightSwitch = this.accessoryConfig?.['lightSwitch'] === true;
-
     this.platform.log.debug(`Created garage door ${accessory.context.device.label}`);
     this.service = this.accessory.getService(this.platform.Service.GarageDoorOpener)
       || this.accessory.addService(this.platform.Service.GarageDoorOpener);
@@ -73,7 +70,9 @@ export class HmIPGarageDoor extends HmIPGenericDevice implements Updateable {
     this.service.getCharacteristic(this.platform.Characteristic.ObstructionDetected)
       .on('get', this.handleObstructionDetectedGet.bind(this));
 
-    if (this.withLightSwitch) {
+    const withLightSwitch = this.accessoryConfig?.['lightSwitch'] === true;
+
+    if (withLightSwitch) {
       this.switchService = this.accessory.getService(this.platform.Service.Switch)
         || this.accessory.addService(this.platform.Service.Switch);
 
@@ -149,7 +148,7 @@ export class HmIPGarageDoor extends HmIPGenericDevice implements Updateable {
 
         if (doorChannel.processing !== null && doorChannel.processing !== this.processing) {
           this.processing = doorChannel.processing;
-          this.platform.log.info('Garage door processing state of %s changed to %s', this.accessory.displayName, this.processing);
+          this.platform.log.debug('Garage door processing state of %s changed to %s', this.accessory.displayName, this.processing);
           if (!this.processing && this.currentDoorState !== DoorState.OPEN && this.currentDoorState !== DoorState.CLOSED){
             this.service.updateCharacteristic(this.platform.Characteristic.CurrentDoorState,
               this.platform.Characteristic.CurrentDoorState.STOPPED);
diff --git a/src/devices/HmIPHeatingThermostat.ts b/src/devices/HmIPHeatingThermostat.ts
@@ -132,19 +132,19 @@ export class HmIPHeatingThermostat extends HmIPGenericDevice implements Updateab
 
         if (heatingThermostatChannel.setPointTemperature !== this.setPointTemperature) {
           this.setPointTemperature = heatingThermostatChannel.setPointTemperature;
-          this.platform.log.info('Target temperature of %s changed to %s °C', this.accessory.displayName, this.setPointTemperature);
+          this.platform.log.debug('Target temperature of %s changed to %s °C', this.accessory.displayName, this.setPointTemperature);
           this.service.updateCharacteristic(this.platform.Characteristic.TargetTemperature, this.setPointTemperature);
         }
 
         if (heatingThermostatChannel.valveActualTemperature !== this.valveActualTemperature) {
           this.valveActualTemperature = heatingThermostatChannel.valveActualTemperature;
-          this.platform.log.info('Current temperature of %s changed to %s °C', this.accessory.displayName, this.valveActualTemperature);
+          this.platform.log.debug('Current temperature of %s changed to %s °C', this.accessory.displayName, this.valveActualTemperature);
           this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, this.valveActualTemperature);
         }
 
         if (heatingThermostatChannel.valvePosition !== this.valvePosition) {
           this.valvePosition = heatingThermostatChannel.valvePosition;
-          this.platform.log.info('Current valve position of %s changed to %s', this.accessory.displayName, this.valvePosition);
+          this.platform.log.debug('Current valve position of %s changed to %s', this.accessory.displayName, this.valvePosition);
         }
 
         if (heatingThermostatChannel.valveState !== this.valveState) {
diff --git a/src/devices/HmIPLightSensor.ts b/src/devices/HmIPLightSensor.ts
@@ -53,7 +53,7 @@ export class HmIPLightSensor extends HmIPGenericDevice implements Updateable {
 
         if (lightSensorChannel.averageIllumination !== null && lightSensorChannel.averageIllumination !== this.averageIllumination) {
           this.averageIllumination = lightSensorChannel.averageIllumination;
-          this.platform.log.info('Average light level of %s changed to %s lx', this.accessory.displayName, this.averageIllumination);
+          this.platform.log.debug('Average light level of %s changed to %s lx', this.accessory.displayName, this.averageIllumination);
           this.service.updateCharacteristic(this.platform.Characteristic.CurrentAmbientLightLevel, this.averageIllumination);
         }
       }
diff --git a/src/devices/HmIPMotionDetector.ts b/src/devices/HmIPMotionDetector.ts
@@ -70,7 +70,7 @@ export class HmIPMotionDetector extends HmIPGenericDevice implements Updateable
 
         if (motionDetectionChannel.motionDetected !== null && motionDetectionChannel.motionDetected !== this.motionDetected) {
           this.motionDetected = motionDetectionChannel.motionDetected;
-          this.platform.log.info('Motion detector state of %s changed to %s', this.accessory.displayName, this.motionDetected);
+          this.platform.log.debug('Motion detector state of %s changed to %s', this.accessory.displayName, this.motionDetected);
           this.service.updateCharacteristic(this.platform.Characteristic.MotionDetected, this.motionDetected);
         }
       }
diff --git a/src/devices/HmIPPresenceDetector.ts b/src/devices/HmIPPresenceDetector.ts
@@ -70,7 +70,7 @@ export class HmIPPresenceDetector extends HmIPGenericDevice implements Updateabl
 
         if (presenceDetectionChannel.presenceDetected !== null && presenceDetectionChannel.presenceDetected !== this.presenceDetected) {
           this.presenceDetected = presenceDetectionChannel.presenceDetected;
-          this.platform.log.info('Presence detector state of %s changed to %s', this.accessory.displayName, this.presenceDetected);
+          this.platform.log.debug('Presence detector state of %s changed to %s', this.accessory.displayName, this.presenceDetected);
           this.service.updateCharacteristic(this.platform.Characteristic.OccupancyDetected, this.presenceDetected
             ? this.platform.Characteristic.OccupancyDetected.OCCUPANCY_DETECTED
             : this.platform.Characteristic.OccupancyDetected.OCCUPANCY_NOT_DETECTED);
diff --git a/src/devices/HmIPShutter.ts b/src/devices/HmIPShutter.ts
@@ -105,14 +105,14 @@ export class HmIPShutter extends HmIPGenericDevice implements Updateable {
         const shutterLevelHomeKit = HmIPShutter.shutterHmIPToHomeKit(shutterChannel.shutterLevel);
         if (shutterLevelHomeKit !== this.shutterLevel) {
           this.shutterLevel = shutterLevelHomeKit;
-          this.platform.log.info('Current shutter level of %s changed to %s %%', this.accessory.displayName, this.shutterLevel.toFixed(0));
+          this.platform.log.debug('Current shutter level of %s changed to %s %%', this.accessory.displayName, this.shutterLevel.toFixed(0));
           this.service.updateCharacteristic(this.platform.Characteristic.CurrentPosition, this.shutterLevel);
           this.service.updateCharacteristic(this.platform.Characteristic.TargetPosition, this.shutterLevel);
         }
 
         if (shutterChannel.processing !== this.processing) {
           this.processing = shutterChannel.processing;
-          this.platform.log.info('Processing state of shutter/blind %s changed to %s', this.accessory.displayName, this.processing);
+          this.platform.log.debug('Processing state of shutter/blind %s changed to %s', this.accessory.displayName, this.processing);
           this.service.updateCharacteristic(this.platform.Characteristic.PositionState, this.processing ?
             this.platform.Characteristic.PositionState.DECREASING : this.platform.Characteristic.PositionState.STOPPED);
         }
diff --git a/src/devices/HmIPSwitchMeasuring.ts b/src/devices/HmIPSwitchMeasuring.ts
@@ -99,14 +99,14 @@ export class HmIPSwitchMeasuring extends HmIPGenericDevice implements Updateable
         if (switchMeasuringChannel.currentPowerConsumption !== null
           && switchMeasuringChannel.currentPowerConsumption !== this.currentPowerConsumption) {
           this.currentPowerConsumption = switchMeasuringChannel.currentPowerConsumption;
-          this.platform.log.info('Switch power consumption of %s changed to %s W',
+          this.platform.log.debug('Switch power consumption of %s changed to %s W',
             this.accessory.displayName, this.currentPowerConsumption.toFixed(1));
           this.service.updateCharacteristic(this.platform.customCharacteristic.characteristic.ElectricPower, this.currentPowerConsumption);
         }
 
         if (switchMeasuringChannel.energyCounter !== null && switchMeasuringChannel.energyCounter !== this.energyCounter) {
           this.energyCounter = switchMeasuringChannel.energyCounter;
-          this.platform.log.info('Switch energy counter of %s changed to %s kWh',
+          this.platform.log.debug('Switch energy counter of %s changed to %s kWh',
             this.accessory.displayName, this.energyCounter.toFixed(3));
           this.service.updateCharacteristic(this.platform.customCharacteristic.characteristic.ElectricalEnergy, this.energyCounter);
         }
diff --git a/src/devices/HmIPWallMountedThermostat.ts b/src/devices/HmIPWallMountedThermostat.ts
@@ -154,13 +154,13 @@ export class HmIPWallMountedThermostat extends HmIPGenericDevice implements Upda
 
         if (wthChannel.actualTemperature !== null && wthChannel.actualTemperature !== this.actualTemperature) {
           this.actualTemperature = wthChannel.actualTemperature;
-          this.platform.log.info('Current temperature of %s changed to %s °C', this.accessory.displayName, this.actualTemperature);
+          this.platform.log.debug('Current temperature of %s changed to %s °C', this.accessory.displayName, this.actualTemperature);
           this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, this.actualTemperature);
         }
 
         if (wthChannel.humidity !== null && wthChannel.humidity !== this.humidity) {
           this.humidity = wthChannel.humidity;
-          this.platform.log.info('Current relative humidity of %s changed to %s %%', this.accessory.displayName, this.humidity);
+          this.platform.log.debug('Current relative humidity of %s changed to %s %%', this.accessory.displayName, this.humidity);
           this.service.updateCharacteristic(this.platform.Characteristic.CurrentRelativeHumidity, this.humidity);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -67,13 +67,13 @@ export class HmIPClimateSensor extends HmIPGenericDevice implements Updateable {`
`67`	`67`
`68`	`68`	`if (climateSensorChannel.actualTemperature !== this.actualTemperature) {`
`69`	`69`	`this.actualTemperature = climateSensorChannel.actualTemperature;`
`70`		`- this.platform.log.info('Current temperature of %s changed to %s °C', this.accessory.displayName, this.actualTemperature);`
	`70`	`+ this.platform.log.debug('Current temperature of %s changed to %s °C', this.accessory.displayName, this.actualTemperature);`
`71`	`71`	`this.temperatureService.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, this.actualTemperature);`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`if (climateSensorChannel.humidity !== this.humidity) {`
`75`	`75`	`this.humidity = climateSensorChannel.humidity;`
`76`		`- this.platform.log.info('Current relative humidity of %s changed to %s %%', this.accessory.displayName, this.humidity);`
	`76`	`+ this.platform.log.debug('Current relative humidity of %s changed to %s %%', this.accessory.displayName, this.humidity);`
`77`	`77`	`this.humidityService.updateCharacteristic(this.platform.Characteristic.CurrentRelativeHumidity, this.humidity);`
`78`	`78`	`}`
`79`	`79`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ export class HmIPDimmer extends HmIPGenericDevice implements Updateable {`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`this.brightness = brightness;`
`105`		`- this.platform.log.info('Brightness of %s changed to %s %%', this.accessory.displayName, this.brightness.toFixed(0));`
	`105`	`+ this.platform.log.debug('Brightness of %s changed to %s %%', this.accessory.displayName, this.brightness.toFixed(0));`
`106`	`106`	`this.service.updateCharacteristic(this.platform.Characteristic.Brightness, this.brightness);`
`107`	`107`	`}`
`108`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ export class HmIPDoorLockDrive extends HmIPGenericDevice implements Updateable {`
`113`	`113`
`114`	`114`	`if (doorLockChannel.motorState !== null && doorLockChannel.motorState !== this.motorState) {`
`115`	`115`	`this.motorState = doorLockChannel.motorState;`
`116`		`- this.platform.log.info('Door lock drive motor state of %s changed to %s', this.accessory.displayName, this.motorState);`
	`116`	`+ this.platform.log.debug('Door lock drive motor state of %s changed to %s', this.accessory.displayName, this.motorState);`
`117`	`117`	`this.updateHmKitLockTargetState();`
`118`	`118`	`this.service.updateCharacteristic(this.platform.Characteristic.LockTargetState, this.targetLockState);`
`119`	`119`	`}`
Original file line number	Diff line number	Diff line change
`@@ -132,19 +132,19 @@ export class HmIPHeatingThermostat extends HmIPGenericDevice implements Updateab`
`132`	`132`
`133`	`133`	`if (heatingThermostatChannel.setPointTemperature !== this.setPointTemperature) {`
`134`	`134`	`this.setPointTemperature = heatingThermostatChannel.setPointTemperature;`
`135`		`- this.platform.log.info('Target temperature of %s changed to %s °C', this.accessory.displayName, this.setPointTemperature);`
	`135`	`+ this.platform.log.debug('Target temperature of %s changed to %s °C', this.accessory.displayName, this.setPointTemperature);`
`136`	`136`	`this.service.updateCharacteristic(this.platform.Characteristic.TargetTemperature, this.setPointTemperature);`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`if (heatingThermostatChannel.valveActualTemperature !== this.valveActualTemperature) {`
`140`	`140`	`this.valveActualTemperature = heatingThermostatChannel.valveActualTemperature;`
`141`		`- this.platform.log.info('Current temperature of %s changed to %s °C', this.accessory.displayName, this.valveActualTemperature);`
	`141`	`+ this.platform.log.debug('Current temperature of %s changed to %s °C', this.accessory.displayName, this.valveActualTemperature);`
`142`	`142`	`this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, this.valveActualTemperature);`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`if (heatingThermostatChannel.valvePosition !== this.valvePosition) {`
`146`	`146`	`this.valvePosition = heatingThermostatChannel.valvePosition;`
`147`		`- this.platform.log.info('Current valve position of %s changed to %s', this.accessory.displayName, this.valvePosition);`
	`147`	`+ this.platform.log.debug('Current valve position of %s changed to %s', this.accessory.displayName, this.valvePosition);`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`if (heatingThermostatChannel.valveState !== this.valveState) {`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ export class HmIPLightSensor extends HmIPGenericDevice implements Updateable {`
`53`	`53`
`54`	`54`	`if (lightSensorChannel.averageIllumination !== null && lightSensorChannel.averageIllumination !== this.averageIllumination) {`
`55`	`55`	`this.averageIllumination = lightSensorChannel.averageIllumination;`
`56`		`- this.platform.log.info('Average light level of %s changed to %s lx', this.accessory.displayName, this.averageIllumination);`
	`56`	`+ this.platform.log.debug('Average light level of %s changed to %s lx', this.accessory.displayName, this.averageIllumination);`
`57`	`57`	`this.service.updateCharacteristic(this.platform.Characteristic.CurrentAmbientLightLevel, this.averageIllumination);`
`58`	`58`	`}`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ export class HmIPMotionDetector extends HmIPGenericDevice implements Updateable`
`70`	`70`
`71`	`71`	`if (motionDetectionChannel.motionDetected !== null && motionDetectionChannel.motionDetected !== this.motionDetected) {`
`72`	`72`	`this.motionDetected = motionDetectionChannel.motionDetected;`
`73`		`- this.platform.log.info('Motion detector state of %s changed to %s', this.accessory.displayName, this.motionDetected);`
	`73`	`+ this.platform.log.debug('Motion detector state of %s changed to %s', this.accessory.displayName, this.motionDetected);`
`74`	`74`	`this.service.updateCharacteristic(this.platform.Characteristic.MotionDetected, this.motionDetected);`
`75`	`75`	`}`
`76`	`76`	`}`