Skip to content

Conversation

@althenlimzixuan
Copy link
Contributor

@althenlimzixuan althenlimzixuan commented May 17, 2024

Open issue:

[https://github.com//issues/557]

Close #557

Copy link
Collaborator

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Fail is related, could you update the test mocks?

--- FAIL: Test_ToJSON (0.00s)
    session_test.go:40: 
        	Error Trace:	/home/runner/work/goth/goth/providers/apple/session_test.go:40
        	Error:      	Not equal: 
        	            	expected: "{\"AuthURL\":\"\",\"AccessToken\":\"\",\"RefreshToken\":\"\",\"ExpiresAt\":\"0001-01-01T00:00:00Z\",\"sub\":\"\",\"email\":\"\",\"is_private_email\":false,\"email_verified\":false}"
        	            	actual  : "{\"AuthURL\":\"\",\"AccessToken\":\"\",\"RefreshToken\":\"\",\"ExpiresAt\":\"0001-01-01T00:00:00Z\",\"sub\":\"\",\"email\":\"\",\"is_private_email\":false}"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-{"AuthURL":"","AccessToken":"","RefreshToken":"","ExpiresAt":"0001-01-01T00:00:00Z","sub":"","email":"","is_private_email":false,"email_verified":false}
        	            	+{"AuthURL":"","AccessToken":"","RefreshToken":"","ExpiresAt":"0001-01-01T00:00:00Z","sub":"","email":"","is_private_email":false}
        	Test:       	Test_ToJSON
FAIL
FAIL	github.com/markbates/goth/providers/apple	0.024s

@althenlimzixuan
Copy link
Contributor Author

Test cases fixed.

Copy link
Collaborator

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! thanks for the PR.

@techknowlogick techknowlogick merged commit 260588e into markbates:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add EmailVerified field in Apple Session

2 participants