Introduce "local" tag to work around github's non-POSIX file system

Author: markdingo

Makefile

@@ -11,7 +11,7 @@ CMDDEPENDS=$(GENERATED) *.go Makefile $(MANPAGE)
 all: $(CMD)
 
 $(CMD): $(CMDDEPENDS)
-	go build
+	go build -tags local
 
 version.go:	generate_version.sh ChangeLog.md go.mod Makefile
 	sh generate_version.sh ChangeLog.md version.go
@@ -27,16 +27,20 @@ clean:
 
 .PHONY: vet
 vet:	$(GENERATED)
-	go vet ./...
+	go vet -tags local ./...
 	mandoc -Tlint $(MANPAGE); exit 0
 
 .PHONY: install
 install: $(BINDIST)/$(CMD) $(MANDIST)/$(MANPAGE)
 
 .PHONY: test tests
 
+# The "local" tag is my convention for any build or test requirements which can only be
+# satisified on a local system with a regular local file system. This is largely used to
+# turn off some tests which fail on github because it presents a funky file system which
+# is not POSIX.
 test tests: $(GENERATED)
-	go test -race -v
+	go test -tags local -race -v
 
 $(BINDIST)/$(CMD): $(CMD) Makefile
 	install -d -m u=rwx,go=rx $(BINDIST) # Ensure destination exists
@@ -54,5 +58,5 @@ $(MANDIST)/$(MANPAGE): $(MANPAGE) Makefile
 windows: fad.exe
 fad.exe: $(CMDDEPENDS)
 	@echo 'Building for Windows amd64 (10 or higher)'
-	@GOOS=windows GOARCH=amd64 go build
+	@GOOS=windows GOARCH=amd64 go build -tags local
 	@file $(CMD).exe

scanner_local_test.go

@@ -0,0 +1,32 @@
+//go:build local
+
+package main
+
+import (
+	"bytes"
+	"flag"
+	"testing"
+)
+
+// Check basic scaner functionality. That scan returns a single entry which is also the
+// one with the most recent DTM. Unfortunately this test fails on github for reasons to do
+// with their funky file-system so it's only run on a non-gitgub environment.
+func TestScannerBasic(t *testing.T) {
+	var stderr bytes.Buffer
+	cfg := newConfig(flag.NewFlagSet(Name, flag.ContinueOnError),
+		func() (string, error) { return "", nil })
+	scn, can, err := testScannerSetup(cfg, &stderr, 10)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	scn.descend(0, "testdata/scan10")
+	scn.wait()
+
+	if len(can.cf) != 1 {
+		t.Fatal("Expected 1 entry from testdata/scan10, got", len(can.cf))
+	}
+	if can.cf[0].path != "testdata/scan10/README" {
+		t.Error("Expected scan to return README, not", can.cf[0].path)
+	}
+}

scanner_test.go

@@ -81,31 +81,6 @@ func TestStats(t *testing.T) {
 	}
 }
 
-/*
-// Check that scan returns a single entry which is also the one with the most recent DTM. Unfortunately
-// this test fails on github for reasons to do with their funky file-system so we've commented this
-// out for now.
-func TestScannerStart(t *testing.T) {
-	var stderr bytes.Buffer
-	cfg := newConfig(flag.NewFlagSet(Name, flag.ContinueOnError),
-		func() (string, error) { return "", nil })
-	scn, can, err := testScannerSetup(cfg, &stderr, 10)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	scn.descend(0, "testdata/scan10")
-	scn.wait()
-
-	if len(can.cf) != 1 {
-		t.Fatal("Expected 1 entry from testdata/scan10, got", len(can.cf))
-	}
-	if can.cf[0].path != "testdata/scan10/README" {
-		t.Error("Expected scan to return README, not", can.cf[0].path)
-	}
-}
-*/
-
 // Test for readDir error return
 func TestScannerReaddir(t *testing.T) {
 	var stderr bytes.Buffer