provide local IDs

Martin Rotter · Martin Rotter · commit 47448a05efc6 · 2021-07-14T14:55:41.000+02:00
diff --git a/src/librssguard/services/abstract/serviceroot.h b/src/librssguard/services/abstract/serviceroot.h
@@ -102,7 +102,7 @@ class ServiceRoot : public RootItem {
     // Throws exception subclassed from ApplicationException, preferably FeedFetchException
     // if any problems arise.
     virtual QList<Message> obtainNewMessages(const QList<Feed*>& feeds,
-                                             QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>> stated_messages,
+                                             const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                              const QHash<QString, QStringList>& tagged_messages) = 0;
 
     // This method should prepare messages for given "item" (download them maybe?)
diff --git a/src/librssguard/services/feedly/feedlyserviceroot.cpp b/src/librssguard/services/feedly/feedlyserviceroot.cpp
@@ -73,7 +73,7 @@ void FeedlyServiceRoot::setCustomDatabaseData(const QVariantHash& data) {
 }
 
 QList<Message> FeedlyServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,
-                                                    const QHash<BagOfMessages, QStringList>& stated_messages,
+                                                    const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                                     const QHash<QString, QStringList>& tagged_messages) {
   Q_UNUSED(stated_messages)
   Q_UNUSED(tagged_messages)
diff --git a/src/librssguard/services/feedly/feedlyserviceroot.h b/src/librssguard/services/feedly/feedlyserviceroot.h
@@ -24,7 +24,7 @@ class FeedlyServiceRoot : public ServiceRoot, public CacheForServiceRoot {
     virtual QVariantHash customDatabaseData() const;
     virtual void setCustomDatabaseData(const QVariantHash& data);
     virtual QList<Message> obtainNewMessages(const QList<Feed*>& feeds,
-                                             QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>> stated_messages,
+                                             const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                              const QHash<QString, QStringList>& tagged_messages);
 
     FeedlyNetwork* network() const;
diff --git a/src/librssguard/services/gmail/gmailserviceroot.cpp b/src/librssguard/services/gmail/gmailserviceroot.cpp
@@ -75,7 +75,7 @@ void GmailServiceRoot::setCustomDatabaseData(const QVariantHash& data) {
 }
 
 QList<Message> GmailServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,
-                                                   const QHash<BagOfMessages, QStringList>& stated_messages,
+                                                   const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                                    const QHash<QString, QStringList>& tagged_messages) {
   Q_UNUSED(stated_messages)
   Q_UNUSED(tagged_messages)
diff --git a/src/librssguard/services/gmail/gmailserviceroot.h b/src/librssguard/services/gmail/gmailserviceroot.h
@@ -32,7 +32,7 @@ class GmailServiceRoot : public ServiceRoot, public CacheForServiceRoot {
     virtual QVariantHash customDatabaseData() const;
     virtual void setCustomDatabaseData(const QVariantHash& data);
     virtual QList<Message> obtainNewMessages(const QList<Feed*>& feeds,
-                                             QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>> stated_messages,
+                                             const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                              const QHash<QString, QStringList>& tagged_messages);
 
   protected:
diff --git a/src/librssguard/services/greader/greaderserviceroot.cpp b/src/librssguard/services/greader/greaderserviceroot.cpp
@@ -58,7 +58,7 @@ void GreaderServiceRoot::setCustomDatabaseData(const QVariantHash& data) {
 }
 
 QList<Message> GreaderServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,
-                                                     const QHash<BagOfMessages, QStringList>& stated_messages,
+                                                     const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                                      const QHash<QString, QStringList>& tagged_messages) {
   Q_UNUSED(stated_messages)
   Q_UNUSED(tagged_messages)
diff --git a/src/librssguard/services/greader/greaderserviceroot.h b/src/librssguard/services/greader/greaderserviceroot.h
@@ -32,7 +32,7 @@ class GreaderServiceRoot : public ServiceRoot, public CacheForServiceRoot {
     virtual QVariantHash customDatabaseData() const;
     virtual void setCustomDatabaseData(const QVariantHash& data);
     virtual QList<Message> obtainNewMessages(const QList<Feed*>& feeds,
-                                             QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>> stated_messages,
+                                             const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                              const QHash<QString, QStringList>& tagged_messages);
     virtual bool wantsBaggedIdsOfExistingMessages() const;
 
diff --git a/src/librssguard/services/inoreader/inoreaderserviceroot.cpp b/src/librssguard/services/inoreader/inoreaderserviceroot.cpp
@@ -57,7 +57,7 @@ void InoreaderServiceRoot::setCustomDatabaseData(const QVariantHash& data) {
 }
 
 QList<Message> InoreaderServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,
-                                                       const QHash<BagOfMessages, QStringList>& stated_messages,
+                                                       const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                                        const QHash<QString, QStringList>& tagged_messages) {
   Q_UNUSED(stated_messages)
   Q_UNUSED(tagged_messages)
diff --git a/src/librssguard/services/inoreader/inoreaderserviceroot.h b/src/librssguard/services/inoreader/inoreaderserviceroot.h
@@ -30,7 +30,7 @@ class InoreaderServiceRoot : public ServiceRoot, public CacheForServiceRoot {
     virtual QVariantHash customDatabaseData() const;
     virtual void setCustomDatabaseData(const QVariantHash& data);
     virtual QList<Message> obtainNewMessages(const QList<Feed*>& feeds,
-                                             QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>> stated_messages,
+                                             const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                              const QHash<QString, QStringList>& tagged_messages);
 
   protected:
diff --git a/src/librssguard/services/owncloud/owncloudserviceroot.cpp b/src/librssguard/services/owncloud/owncloudserviceroot.cpp
@@ -151,7 +151,7 @@ void OwnCloudServiceRoot::setCustomDatabaseData(const QVariantHash& data) {
 }
 
 QList<Message> OwnCloudServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,
-                                                      const QHash<BagOfMessages, QStringList>& stated_messages,
+                                                      const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                                       const QHash<QString, QStringList>& tagged_messages) {
   Q_UNUSED(stated_messages)
   Q_UNUSED(tagged_messages)
diff --git a/src/librssguard/services/owncloud/owncloudserviceroot.h b/src/librssguard/services/owncloud/owncloudserviceroot.h
@@ -29,7 +29,7 @@ class OwnCloudServiceRoot : public ServiceRoot, public CacheForServiceRoot {
     virtual QVariantHash customDatabaseData() const;
     virtual void setCustomDatabaseData(const QVariantHash& data);
     virtual QList<Message> obtainNewMessages(const QList<Feed*>& feeds,
-                                             QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>> stated_messages,
+                                             const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                              const QHash<QString, QStringList>& tagged_messages);
 
     OwnCloudNetworkFactory* network() const;
diff --git a/src/librssguard/services/standard/standardserviceroot.cpp b/src/librssguard/services/standard/standardserviceroot.cpp
@@ -145,7 +145,7 @@ Qt::ItemFlags StandardServiceRoot::additionalFlags() const {
 }
 
 QList<Message> StandardServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,
-                                                      const QHash<BagOfMessages, QStringList>& stated_messages,
+                                                      const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                                       const QHash<QString, QStringList>& tagged_messages) {
   Q_UNUSED(stated_messages)
   Q_UNUSED(tagged_messages)
diff --git a/src/librssguard/services/standard/standardserviceroot.h b/src/librssguard/services/standard/standardserviceroot.h
@@ -33,7 +33,7 @@ class StandardServiceRoot : public ServiceRoot {
     virtual bool supportsCategoryAdding() const;
     virtual Qt::ItemFlags additionalFlags() const;
     virtual QList<Message> obtainNewMessages(const QList<Feed*>& feeds,
-                                             QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>> stated_messages,
+                                             const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                              const QHash<QString, QStringList>& tagged_messages);
 
     QList<QAction*> serviceMenu();
diff --git a/src/librssguard/services/tt-rss/ttrssserviceroot.cpp b/src/librssguard/services/tt-rss/ttrssserviceroot.cpp
@@ -215,7 +215,7 @@ void TtRssServiceRoot::setCustomDatabaseData(const QVariantHash& data) {
 }
 
 QList<Message> TtRssServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,
-                                                   const QHash<BagOfMessages, QStringList>& stated_messages,
+                                                   const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                                    const QHash<QString, QStringList>& tagged_messages) {
   Q_UNUSED(stated_messages)
   Q_UNUSED(tagged_messages)
diff --git a/src/librssguard/services/tt-rss/ttrssserviceroot.h b/src/librssguard/services/tt-rss/ttrssserviceroot.h
@@ -34,7 +34,7 @@ class TtRssServiceRoot : public ServiceRoot, public CacheForServiceRoot {
     virtual QVariantHash customDatabaseData() const;
     virtual void setCustomDatabaseData(const QVariantHash& data);
     virtual QList<Message> obtainNewMessages(const QList<Feed*>& feeds,
-                                             QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>> stated_messages,
+                                             const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,
                                              const QHash<QString, QStringList>& tagged_messages);
 
     // Access to network.

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ void FeedlyServiceRoot::setCustomDatabaseData(const QVariantHash& data) {`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`QList<Message> FeedlyServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,`
`76`		`- const QHash<BagOfMessages, QStringList>& stated_messages,`
	`76`	`+ const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,`
`77`	`77`	`const QHash<QString, QStringList>& tagged_messages) {`
`78`	`78`	`Q_UNUSED(stated_messages)`
`79`	`79`	`Q_UNUSED(tagged_messages)`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ void GmailServiceRoot::setCustomDatabaseData(const QVariantHash& data) {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`QList<Message> GmailServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,`
`78`		`- const QHash<BagOfMessages, QStringList>& stated_messages,`
	`78`	`+ const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,`
`79`	`79`	`const QHash<QString, QStringList>& tagged_messages) {`
`80`	`80`	`Q_UNUSED(stated_messages)`
`81`	`81`	`Q_UNUSED(tagged_messages)`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ void GreaderServiceRoot::setCustomDatabaseData(const QVariantHash& data) {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`QList<Message> GreaderServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,`
`61`		`- const QHash<BagOfMessages, QStringList>& stated_messages,`
	`61`	`+ const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,`
`62`	`62`	`const QHash<QString, QStringList>& tagged_messages) {`
`63`	`63`	`Q_UNUSED(stated_messages)`
`64`	`64`	`Q_UNUSED(tagged_messages)`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ void InoreaderServiceRoot::setCustomDatabaseData(const QVariantHash& data) {`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`QList<Message> InoreaderServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,`
`60`		`- const QHash<BagOfMessages, QStringList>& stated_messages,`
	`60`	`+ const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,`
`61`	`61`	`const QHash<QString, QStringList>& tagged_messages) {`
`62`	`62`	`Q_UNUSED(stated_messages)`
`63`	`63`	`Q_UNUSED(tagged_messages)`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ void OwnCloudServiceRoot::setCustomDatabaseData(const QVariantHash& data) {`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`QList<Message> OwnCloudServiceRoot::obtainNewMessages(const QList<Feed*>& feeds,`
`154`		`- const QHash<BagOfMessages, QStringList>& stated_messages,`
	`154`	`+ const QHash<QString, QPair<ServiceRoot::BagOfMessages, QStringList>>& stated_messages,`
`155`	`155`	`const QHash<QString, QStringList>& tagged_messages) {`
`156`	`156`	`Q_UNUSED(stated_messages)`
`157`	`157`	`Q_UNUSED(tagged_messages)`