Skip to content

Commit 6b7b13f

Browse files
dotnet-maestro[bot]lewingjjonesczpavelsavarastephentoub
authored and
matouskozak
committed
[main] Update dependencies from dotnet/roslyn (dotnet#98559)
* Update dependencies from https://github.com/dotnet/roslyn build 20240215.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24115.8 * Update dependencies from https://github.com/dotnet/roslyn build 20240216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240216.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24116.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240220.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24120.1 * Update dependencies from https://github.com/dotnet/roslyn build 20240221.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24121.2 * Update dependencies from https://github.com/dotnet/roslyn build 20240221.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24121.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240222.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24122.5 * Update dependencies from https://github.com/dotnet/roslyn build 20240223.6 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24123.6 * Update dependencies from https://github.com/dotnet/roslyn build 20240224.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24124.2 * Update dependencies from https://github.com/dotnet/roslyn build 20240222.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24122.4 * Avoid/suppress Lock-to-object conversion warnings * Update dependencies from https://github.com/dotnet/roslyn build 20240227.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-2.24127.1 * Update dependencies from https://github.com/dotnet/roslyn build 20240227.10 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24127.10 * Update dependencies from https://github.com/dotnet/roslyn build 20240228.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24128.4 * Update dependencies from https://github.com/dotnet/roslyn build 20240301.3 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24151.3 * Update dependencies from https://github.com/dotnet/roslyn build 20240301.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24151.8 * Update dependencies from https://github.com/dotnet/roslyn build 20240301.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24151.8 * Update dependencies from https://github.com/dotnet/roslyn build 20240301.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24151.8 * Update dependencies from https://github.com/dotnet/roslyn build 20240305.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24155.1 * Update dependencies from https://github.com/dotnet/roslyn build 20240305.13 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24155.13 * Suppress more Lock-to-object warnings * Remove invalid source build element * Update dependencies from https://github.com/dotnet/roslyn build 20240306.11 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24156.11 * Update dependencies from https://github.com/dotnet/roslyn build 20240307.14 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24157.14 * Update dependencies from https://github.com/dotnet/roslyn build 20240308.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24158.5 * Update dependencies from https://github.com/dotnet/roslyn build 20240308.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24158.5 * Update dependencies from https://github.com/dotnet/roslyn build 20240311.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24161.2 * Update dependencies from https://github.com/dotnet/roslyn build 20240311.10 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24161.10 * Update dependencies from https://github.com/dotnet/roslyn build Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24172.1 * Update dependencies from https://github.com/dotnet/roslyn build Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24175.2 * Workaround compiler changes related to dynamic * Work around Microsoft.CSharp test failure due to dynamic changes * Update dependencies from https://github.com/dotnet/roslyn build Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.11.0-1.24176.2 * Update dependencies from https://github.com/dotnet/roslyn build 20240330.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.11.0-1.24180.2 * Convert ParallelTheory to Theory in InteropService test suites. The ParallelTheory creates an environment that overwhelms the GC and Finalizer thread on x86. The result is OOMs in the 32-bit memory address space. * Fix deadlocking in regex tests * Update dependencies from https://github.com/dotnet/roslyn build 20240402.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.10.0-2.24114.13 -> To Version 4.10.0-3.24202.15 * Fix wasm * Comment out test for InvokeConstructor Roslyn no longer generates a call to InvokeConstructor. --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Jan Jones <[email protected]> Co-authored-by: Pavel Savara <[email protected]> Co-authored-by: Stephen Toub <[email protected]> Co-authored-by: Aaron R Robinson <[email protected]> Co-authored-by: Sven Boemer <[email protected]>
1 parent 6d138aa commit 6b7b13f

File tree

23 files changed

+109
-59
lines changed

23 files changed

+109
-59
lines changed

‎eng/Version.Details.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -360,17 +360,17 @@
360360
<Uri>https://github.com/dotnet/runtime-assets</Uri>
361361
<Sha>f282faa0ddd1b3672a3cba54518943fb1d0b4e36</Sha>
362362
</Dependency>
363-
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.10.0-2.24114.13">
363+
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.10.0-3.24202.15">
364364
<Uri>https://github.com/dotnet/roslyn</Uri>
365-
<Sha>77372c66fd54927312b5b0a2e399e192f74445c9</Sha>
365+
<Sha>cbca41cad4e21c29548e9e57d7135740b6f78df9</Sha>
366366
</Dependency>
367-
<Dependency Name="Microsoft.CodeAnalysis" Version="4.10.0-2.24114.13">
367+
<Dependency Name="Microsoft.CodeAnalysis" Version="4.10.0-3.24202.15">
368368
<Uri>https://github.com/dotnet/roslyn</Uri>
369-
<Sha>77372c66fd54927312b5b0a2e399e192f74445c9</Sha>
369+
<Sha>cbca41cad4e21c29548e9e57d7135740b6f78df9</Sha>
370370
</Dependency>
371-
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="4.10.0-2.24114.13">
371+
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="4.10.0-3.24202.15">
372372
<Uri>https://github.com/dotnet/roslyn</Uri>
373-
<Sha>77372c66fd54927312b5b0a2e399e192f74445c9</Sha>
373+
<Sha>cbca41cad4e21c29548e9e57d7135740b6f78df9</Sha>
374374
</Dependency>
375375
<Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0-beta1.24177.1">
376376
<Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
@@ -381,9 +381,9 @@
381381
<Sha>ad732e236e7ffcb66de4b45a1b736aad4ccdcd83</Sha>
382382
</Dependency>
383383
<!-- Intermediate is necessary for source build. -->
384-
<Dependency Name="Microsoft.SourceBuild.Intermediate.roslyn" Version="4.10.0-2.24114.13">
384+
<Dependency Name="Microsoft.SourceBuild.Intermediate.roslyn" Version="4.10.0-3.24202.15">
385385
<Uri>https://github.com/dotnet/roslyn</Uri>
386-
<Sha>77372c66fd54927312b5b0a2e399e192f74445c9</Sha>
386+
<Sha>cbca41cad4e21c29548e9e57d7135740b6f78df9</Sha>
387387
<SourceBuild RepoName="roslyn" ManagedOnly="true" />
388388
</Dependency>
389389
<Dependency Name="Microsoft.DotNet.ApiCompat.Task" Version="9.0.100-preview.4.24175.4">

‎eng/Versions.props

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@
4242
Any tools that contribute to the design-time experience should use the MicrosoftCodeAnalysisVersion_LatestVS property above to ensure
4343
they do not break the local dev experience.
4444
-->
45-
<MicrosoftCodeAnalysisCSharpVersion>4.10.0-2.24114.13</MicrosoftCodeAnalysisCSharpVersion>
46-
<MicrosoftCodeAnalysisVersion>4.10.0-2.24114.13</MicrosoftCodeAnalysisVersion>
47-
<MicrosoftNetCompilersToolsetVersion>4.10.0-2.24114.13</MicrosoftNetCompilersToolsetVersion>
45+
<MicrosoftCodeAnalysisCSharpVersion>4.10.0-3.24202.15</MicrosoftCodeAnalysisCSharpVersion>
46+
<MicrosoftCodeAnalysisVersion>4.10.0-3.24202.15</MicrosoftCodeAnalysisVersion>
47+
<MicrosoftNetCompilersToolsetVersion>4.10.0-3.24202.15</MicrosoftNetCompilersToolsetVersion>
4848
</PropertyGroup>
4949
<!--
5050
For source generator support we need to target multiple versions of Roslyn in order to be able to run on older versions of Roslyn.

‎src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Condition.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ private unsafe void RemoveWaiter(Waiter waiter)
8989

9090
public Condition(Lock @lock)
9191
{
92+
#pragma warning disable CS9216 // A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.
9293
ArgumentNullException.ThrowIfNull(@lock);
94+
#pragma warning restore CS9216
9395
_lock = @lock;
9496
}
9597

‎src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/SyncTable.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public static unsafe int AssignEntry(object obj, int* pHeader)
140140

141141
// Found a free entry to assign
142142
Debug.Assert(!entry.Owner.IsAllocated);
143-
Debug.Assert(entry.Lock == null);
143+
Debug.Assert(entry.Lock is null);
144144
Debug.Assert(entry.HashCode == 0);
145145

146146
// Set up the new entry. We should not fail after this point.

‎src/libraries/Microsoft.CSharp/tests/BindingErrors.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ public void DoSomething(double d)
6161
{
6262
}
6363

64+
public void DoSomething(float d)
65+
{
66+
}
67+
6468
public static void DoSomething(int i)
6569
{
6670
}

‎src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,12 @@ private void ContentionLockCreated(nint LockID, nint AssociatedObjectID, ushort
9494

9595
[NonEvent]
9696
[MethodImpl(MethodImplOptions.NoInlining)]
97-
public void ContentionLockCreated(Lock lockObj) => ContentionLockCreated(lockObj.LockIdForEvents, ObjectIDForEvents(lockObj));
97+
public void ContentionLockCreated(Lock lockObj) =>
98+
ContentionLockCreated(
99+
lockObj.LockIdForEvents,
100+
#pragma warning disable CS9216 // A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.
101+
ObjectIDForEvents(lockObj));
102+
#pragma warning restore CS9216
98103

99104
[Event(81, Level = EventLevel.Informational, Message = Messages.ContentionStart, Task = Tasks.Contention, Opcode = EventOpcode.Start, Version = 2, Keywords = Keywords.ContentionKeyword)]
100105
private void ContentionStart(
@@ -115,7 +120,9 @@ public void ContentionStart(Lock lockObj) =>
115120
ContentionFlagsMap.Managed,
116121
DefaultClrInstanceId,
117122
lockObj.LockIdForEvents,
123+
#pragma warning disable CS9216 // A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.
118124
ObjectIDForEvents(lockObj),
125+
#pragma warning restore CS9216
119126
lockObj.OwningThreadId);
120127

121128
[Event(91, Level = EventLevel.Informational, Message = Messages.ContentionStop, Task = Tasks.Contention, Opcode = EventOpcode.Stop, Version = 1, Keywords = Keywords.ContentionKeyword)]

‎src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,12 @@ private unsafe void ContentionLockCreated(nint LockID, nint AssociatedObjectID,
107107

108108
[NonEvent]
109109
[MethodImpl(MethodImplOptions.NoInlining)]
110-
public void ContentionLockCreated(Lock lockObj) => ContentionLockCreated(lockObj.LockIdForEvents, ObjectIDForEvents(lockObj));
110+
public void ContentionLockCreated(Lock lockObj) =>
111+
ContentionLockCreated(
112+
lockObj.LockIdForEvents,
113+
#pragma warning disable CS9216 // A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.
114+
ObjectIDForEvents(lockObj));
115+
#pragma warning restore CS9216
111116

112117
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:UnrecognizedReflectionPattern", Justification = "Parameters to this method are primitive and are trimmer safe")]
113118
[Event(81, Level = EventLevel.Informational, Message = Messages.ContentionStart, Task = Tasks.Contention, Opcode = EventOpcode.Start, Version = 2, Keywords = Keywords.ContentionKeyword)]
@@ -146,7 +151,9 @@ public void ContentionStart(Lock lockObj) =>
146151
ContentionFlagsMap.Managed,
147152
DefaultClrInstanceId,
148153
lockObj.LockIdForEvents,
154+
#pragma warning disable CS9216 // A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.
149155
ObjectIDForEvents(lockObj),
156+
#pragma warning restore CS9216
150157
lockObj.OwningThreadId);
151158

152159
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:UnrecognizedReflectionPattern", Justification = "Parameters to this method are primitive and are trimmer safe")]

‎src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ internal Scope(Lock lockObj, ThreadId currentThreadId)
130130
public void Dispose()
131131
{
132132
Lock? lockObj = _lockObj;
133-
if (lockObj != null)
133+
if (lockObj is not null)
134134
{
135135
_lockObj = null;
136136
lockObj.Exit(_currentThreadId);

‎src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/CompileFails.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public static IEnumerable<object[]> ComInterfaceGeneratorSnippetsToCompile()
4141
} };
4242
}
4343

44-
[ParallelTheory]
44+
[Theory]
4545
[MemberData(nameof(ComInterfaceGeneratorSnippetsToCompile))]
4646
public async Task ValidateComInterfaceGeneratorSnippets(string id, string source, DiagnosticResult[] expectedDiagnostics)
4747
{
@@ -335,7 +335,7 @@ public static IEnumerable<object[]> InvalidManagedToUnmanagedCodeSnippetsToCompi
335335
yield return new[] { ID(), customStructMarshallingCodeSnippets.Stateful.ByValueOutParameter };
336336
}
337337

338-
[ParallelTheory]
338+
[Theory]
339339
[MemberData(nameof(InvalidUnmanagedToManagedCodeSnippetsToCompile), GeneratorKind.ComInterfaceGenerator)]
340340
public async Task ValidateInvalidUnmanagedToManagedCodeSnippets(string id, string source, DiagnosticResult[] expectedDiagnostics)
341341
{
@@ -349,7 +349,7 @@ public async Task ValidateInvalidUnmanagedToManagedCodeSnippets(string id, strin
349349
await test.RunAsync();
350350
}
351351

352-
[ParallelTheory]
352+
[Theory]
353353
[MemberData(nameof(InvalidManagedToUnmanagedCodeSnippetsToCompile), GeneratorKind.ComInterfaceGenerator)]
354354
public async Task ValidateInvalidManagedToUnmanagedCodeSnippets(string id, string source)
355355
{
@@ -361,7 +361,7 @@ public async Task ValidateInvalidManagedToUnmanagedCodeSnippets(string id, strin
361361
await VerifyComInterfaceGenerator.VerifySourceGeneratorAsync(source, expectedDiagnostic);
362362
}
363363

364-
[ParallelTheory]
364+
[Theory]
365365
[MemberData(nameof(StringMarshallingCodeSnippets), GeneratorKind.ComInterfaceGenerator)]
366366
public async Task ValidateStringMarshallingDiagnostics(string id, string source, DiagnosticResult[] expectedDiagnostics)
367367
{
@@ -512,15 +512,15 @@ public static unsafe partial class Test {
512512
}
513513
}
514514

515-
[ParallelTheory]
515+
[Theory]
516516
[MemberData(nameof(StringMarshallingCustomTypeVisibilities))]
517517
public async Task VerifyStringMarshallingCustomTypeWithLessVisibilityThanInterfaceWarns(string id, string source, DiagnosticResult[] diagnostics)
518518
{
519519
_ = id;
520520
await VerifyComInterfaceGenerator.VerifySourceGeneratorAsync(source, diagnostics);
521521
}
522522

523-
[ParallelTheory]
523+
[Theory]
524524
[MemberData(nameof(InterfaceVisibilities))]
525525
public async Task VerifyInterfaceWithLessVisibilityThanInterfaceWarns(string id, string source, DiagnosticResult[] diagnostics)
526526
{
@@ -772,7 +772,7 @@ string Source(
772772
}
773773
}
774774

775-
[ParallelTheory]
775+
[Theory]
776776
[MemberData(nameof(CountParameterIsOutSnippets))]
777777
public async Task ValidateSizeParameterRefKindDiagnostics(string ID, string source, params DiagnosticResult[] diagnostics)
778778
{
@@ -889,7 +889,7 @@ partial interface I
889889
}
890890
}
891891

892-
[ParallelTheory]
892+
[Theory]
893893
[MemberData(nameof(IntAndEnumReturnTypeSnippets))]
894894
public async Task ValidateReturnTypeInfoDiagnostics(string id, string source, DiagnosticResult[] diagnostics)
895895
{

‎src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/Compiles.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ public static IEnumerable<object[]> CustomCollectionsManagedToUnmanaged(Generato
320320
yield return new[] { ID(), customCollectionMarshallingCodeSnippetsManagedToUnmanaged.Stateful.NonBlittableElementNativeToManagedOnlyReturnValue };
321321
}
322322

323-
[ParallelTheory]
323+
[Theory]
324324
[MemberData(nameof(CodeSnippetsToCompile), GeneratorKind.VTableIndexStubGenerator)]
325325
[MemberData(nameof(ManagedToUnmanagedCodeSnippetsToCompile), GeneratorKind.VTableIndexStubGenerator)]
326326
[MemberData(nameof(UnmanagedToManagedCodeSnippetsToCompile), GeneratorKind.VTableIndexStubGenerator)]
@@ -348,7 +348,7 @@ public static IEnumerable<object[]> ManagedToUnmanagedComInterfaceSnippetsToComp
348348
yield return new[] { ID(), codeSnippets.MarshalAsParameterAndModifiers("object", System.Runtime.InteropServices.UnmanagedType.Struct) };
349349
}
350350

351-
[ParallelTheory]
351+
[Theory]
352352
[MemberData(nameof(CodeSnippetsToCompile), GeneratorKind.ComInterfaceGenerator)]
353353
[MemberData(nameof(CustomCollections), GeneratorKind.ComInterfaceGenerator)]
354354
[MemberData(nameof(ManagedToUnmanagedCodeSnippetsToCompile), GeneratorKind.ComInterfaceGeneratorComObjectWrapper)]

0 commit comments

Comments
 (0)