Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 1fbc972

Browse files
authored
Use LTS nodejs in github workflows (#12726)
Currently our GH workflows all use nodejs 18, but that's not compatible with the stated support range of matrix-js-sdk, which requires the latest LTS nodejs; so, when we attermpt to `yarn install` on an older nodejs, we get an error. Switch to LTS nodejs for all the places we set up nodejs.
1 parent e75dc4e commit 1fbc972

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

.github/workflows/end-to-end-tests.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ jobs:
5656
- uses: actions/setup-node@v4
5757
with:
5858
cache: "yarn"
59+
node-version: "lts/*"
5960

6061
- name: Fetch layered build
6162
id: layered_build
@@ -121,6 +122,7 @@ jobs:
121122
with:
122123
cache: "yarn"
123124
cache-dependency-path: matrix-react-sdk/yarn.lock
125+
node-version: "lts/*"
124126

125127
- name: Install dependencies
126128
working-directory: matrix-react-sdk
@@ -172,6 +174,7 @@ jobs:
172174
if: inputs.skip != true
173175
with:
174176
cache: "yarn"
177+
node-version: "lts/*"
175178

176179
- name: Install dependencies
177180
if: inputs.skip != true

.github/workflows/static_analysis.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
- uses: actions/setup-node@v4
2626
with:
2727
cache: "yarn"
28+
node-version: "lts/*"
2829

2930
- name: Install Deps
3031
run: "./scripts/ci/install-deps.sh"
@@ -83,6 +84,7 @@ jobs:
8384
- uses: actions/setup-node@v4
8485
with:
8586
cache: "yarn"
87+
node-version: "lts/*"
8688

8789
# Does not need branch matching as only analyses this layer
8890
- name: Install Deps
@@ -100,6 +102,7 @@ jobs:
100102
- uses: actions/setup-node@v4
101103
with:
102104
cache: "yarn"
105+
node-version: "lts/*"
103106

104107
# Does not need branch matching as only analyses this layer
105108
- name: Install Deps
@@ -117,6 +120,7 @@ jobs:
117120
- uses: actions/setup-node@v4
118121
with:
119122
cache: "yarn"
123+
node-version: "lts/*"
120124

121125
# Does not need branch matching as only analyses this layer
122126
- name: Install Deps
@@ -134,6 +138,7 @@ jobs:
134138
- uses: actions/setup-node@v4
135139
with:
136140
cache: "yarn"
141+
node-version: "lts/*"
137142

138143
- name: Install Deps
139144
run: "scripts/ci/layered.sh"

.github/workflows/tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
- name: Yarn cache
4545
uses: actions/setup-node@v4
4646
with:
47+
node-version: "lts/*"
4748
cache: "yarn"
4849

4950
- name: Install Deps
@@ -115,6 +116,7 @@ jobs:
115116
- uses: actions/setup-node@v4
116117
with:
117118
cache: "yarn"
119+
node-version: "lts/*"
118120

119121
- name: Run tests
120122
run: "./scripts/ci/app-tests.sh"

0 commit comments

Comments
 (0)