Skip to content

Commit 5954ee1

Browse files
committed
pinned events(refactor): rename event_with_config to fetch_event
The `with_config` is now redundant, and `fetch` makes it clear it's hitting network.
1 parent e15ddf6 commit 5954ee1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

crates/matrix-sdk-ui/src/timeline/pinned_events_loader.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ impl PinnedEventsLoader {
8787
let new_events = join_all(event_ids_to_request.into_iter().map(|event_id| {
8888
let provider = Arc::clone(&provider);
8989
async move {
90-
match provider.event_with_config(&event_id, request_config).await {
90+
match provider.fetch_event(&event_id, request_config).await {
9191
Ok(event) => Some(event),
9292
Err(err) => {
9393
warn!("error when loading pinned event: {err}");
@@ -124,7 +124,7 @@ impl PinnedEventsLoader {
124124
#[cfg_attr(not(target_arch = "wasm32"), async_trait::async_trait)]
125125
pub trait PinnedEventsRoom: SendOutsideWasm + SyncOutsideWasm {
126126
/// Load a single room event.
127-
async fn event_with_config(
127+
async fn fetch_event(
128128
&self,
129129
event_id: &EventId,
130130
request_config: Option<RequestConfig>,
@@ -143,7 +143,7 @@ pub trait PinnedEventsRoom: SendOutsideWasm + SyncOutsideWasm {
143143
#[cfg_attr(target_arch = "wasm32", async_trait::async_trait(?Send))]
144144
#[cfg_attr(not(target_arch = "wasm32"), async_trait::async_trait)]
145145
impl PinnedEventsRoom for Room {
146-
async fn event_with_config(
146+
async fn fetch_event(
147147
&self,
148148
event_id: &EventId,
149149
request_config: Option<RequestConfig>,

crates/matrix-sdk-ui/src/timeline/tests/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ impl PaginableRoom for TestRoomDataProvider {
322322
#[cfg_attr(target_arch = "wasm32", async_trait::async_trait(?Send))]
323323
#[cfg_attr(not(target_arch = "wasm32"), async_trait::async_trait)]
324324
impl PinnedEventsRoom for TestRoomDataProvider {
325-
async fn event_with_config(
325+
async fn fetch_event(
326326
&self,
327327
_event_id: &EventId,
328328
_config: Option<RequestConfig>,

0 commit comments

Comments
 (0)