Skip to content

Clarify the meaning of "public rooms" for profile look-ups #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Mar 18, 2025

Relates to: #633

This is merely a clarification of what the spec says today. It's debatable whether members of "public rooms" should be included in profile queries or not. Changing this, would require an MSC, however.

Pull Request Checklist

Preview: https://pr2101--matrix-spec-previews.netlify.app

@Johennes Johennes changed the title Clarify the meaning of "public rooms" for profile look-ups" Clarify the meaning of "public rooms" for profile look-ups Mar 18, 2025
@Johennes Johennes force-pushed the johannes/public-rooms-profiles branch from 9a77b2e to e842319 Compare March 18, 2025 12:44
@Johennes Johennes marked this pull request as ready for review March 18, 2025 12:44
@Johennes Johennes requested a review from a team as a code owner March 18, 2025 12:45
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM based on how I would interpret the previous spec text.

@anoadragon453 anoadragon453 merged commit c74befd into matrix-org:main May 13, 2025
12 checks passed
Johennes added a commit to Johennes/matrix-spec that referenced this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants