Improve performance of query _get_subset_users_in_room_with_profiles (#13299)

H-Shay · web-flow · commit 15edf23626a5 · 2022-07-18T12:35:45.000-07:00
diff --git a/changelog.d/13299.misc b/changelog.d/13299.misc
@@ -0,0 +1 @@
+Improve performance of query  `_get_subset_users_in_room_with_profiles`.
diff --git a/synapse/storage/databases/main/roommember.py b/synapse/storage/databases/main/roommember.py
@@ -243,7 +243,7 @@ def _get_subset_users_in_room_with_profiles(
             txn: LoggingTransaction,
         ) -> Dict[str, ProfileInfo]:
             clause, ids = make_in_list_sql_clause(
-                self.database_engine, "m.user_id", user_ids
+                self.database_engine, "c.state_key", user_ids
             )
 
             sql = """

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Improve performance of query `_get_subset_users_in_room_with_profiles`.
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ def _get_subset_users_in_room_with_profiles(`
`243`	`243`	`txn: LoggingTransaction,`
`244`	`244`	`) -> Dict[str, ProfileInfo]:`
`245`	`245`	`clause, ids = make_in_list_sql_clause(`
`246`		`- self.database_engine, "m.user_id", user_ids`
	`246`	`+ self.database_engine, "c.state_key", user_ids`
`247`	`247`	`)`
`248`	`248`
`249`	`249`	`sql = """`