Don't accept opentracing data from clients. (#5715)

JorikSchellekens · web-flow · commit 7b8bc6183405 · 2019-07-19T16:29:57.000+01:00
* Don't accept opentracing data from clients.

* newsfile
diff --git a/changelog.d/5715.misc b/changelog.d/5715.misc
@@ -0,0 +1 @@
+Don't accept opentracing data from clients.
diff --git a/synapse/logging/opentracing.py b/synapse/logging/opentracing.py
@@ -340,8 +340,7 @@ def trace_servlet(servlet_name, func):
     @wraps(func)
     @defer.inlineCallbacks
     def _trace_servlet_inner(request, *args, **kwargs):
-        with start_active_span_from_context(
-            request.requestHeaders,
+        with start_active_span(
             "incoming-client-request",
             tags={
                 "request_id": request.get_request_id(),

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Don't accept opentracing data from clients.`