Fix spurious warning when fetching state after a missing prev event

Author: Sean Quah

changelog.d/13258.misc

@@ -0,0 +1 @@
+Fix spurious warning when fetching state after a missing prev event.

synapse/handlers/federation_event.py

@@ -1036,6 +1036,9 @@ async def _get_state_ids_after_missing_prev_event(
         # XXX: this doesn't sound right? it means that we'll end up with incomplete
         #   state.
         failed_to_fetch = desired_events - event_metadata.keys()
+        # `event_id`'s missing from `event_metadata` because it's not necessarily a
+        # state event. We've already checked that we've fetched it above.
+        failed_to_fetch.remove(event_id)
         if failed_to_fetch:
             logger.warning(
                 "Failed to fetch missing state events for %s %s",