Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit dae224a

Browse files
authored
Fix failure to fetch batches of PDUs (#5342)
FederationClient.get_pdu is called in a loop to fetch a batch of PDUs. A failure to fetch one should not result in a failure of the whole batch. Add the missing `continue`.
1 parent b4189b1 commit dae224a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

changelog.d/5342.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix failure when fetching batches of events during backfill, etc.

synapse/federation/federation_client.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@ def get_pdu(self, destinations, event_id, room_version, outlier=False,
279279
"Failed to get PDU %s from %s because %s",
280280
event_id, destination, e,
281281
)
282+
continue
282283
except NotRetryingDestination as e:
283284
logger.info(str(e))
284285
continue

0 commit comments

Comments
 (0)