Rewrite the EditorToolbar class

Previously, it used some complicated internal datastructures to track
what buttons were available and manually painted them and handled mouse
clicks. This lead to a clunky and hard to extend toolbar.

This commit completely rewrites the toolbar. Now, each button is a
separate component (new ToolbarButton class deriving from JButton), so
painting and handling clicks works out of the box.

In previous commits, Action objects have been made available for each of
the toolbar buttons, that also had icons set already. These new
ToolbarButtons take all of their info from these actions. Most of this
was implemented by JButton already, but copying some properties
(selected, the selected icon and the rollover icon) is added by
ToolbarButton.

Before, buttons would be activated (e.g. giving the upload button a
color while the upload is in progress) by calling methods on the
toolbar. Now, the "selected" state of the Action / JButton is used for
this, which automatically changes the icon to the "selected" icon. This
removes the coupling between the verify/upload/save processes and the
EditorToolbar, leaving them only coupled to the Actions they are run
from. This also allows removing the Editor.toolbar instance variable,
since nobody needs to reference it anymore after it was created.

The `Editor.statusError()` method used to deactivate the run (verify)
button on the toolbar, but it seems there are no code paths that
activate this button and then go through statusError but not through the
regular deactivation, so this call was removed.

Because pressing shift changes the effect of some toolbar buttons, each
ToolbarButton can contain one or two Action objects. When shift is
pressed or released, the active Action object (as kept by JButton) is
exchanged for the other one, updating the effect of the button, the
tooltip and icon (though all related actions now use the same icon).
When one action becomes selected, that action stays active regardless of
the shift button, to provide user feedback (until the action is no
longer selected, then it listens to the shift key again).

By using separate Icon objects and files instead of manually cutting up
a single gif with all icons, it will also be easier to replace the icons
with vector icons later, to support high DPI screens more cleanly.

Define the buttons themselves (e.g. what buttons are present) still
happens in the EditorToolbar class, but it might be good to move these
elsewhere at some point.

References: arduino#4196

Author: matthijskooijman

app/src/processing/app/Editor.java

@@ -142,7 +142,6 @@ public boolean test(SketchController sketch) {
 
   private int numTools = 0;
 
-  private final EditorToolbar toolbar;
   // these menus are shared so that they needn't be rebuilt for all windows
   // each time a sketch is created, renamed, or moved.
   static JMenu toolbarMenu;
@@ -261,8 +260,7 @@ public void windowDeactivated(WindowEvent e) {
       toolbarMenu = new JMenu();
       base.rebuildToolbarMenu(toolbarMenu);
     }
-    toolbar = new EditorToolbar(this, toolbarMenu);
-    upper.add(toolbar);
+    upper.add(new EditorToolbar(this));
 
     header = new EditorHeader(this);
     upper.add(header);
@@ -1740,7 +1738,7 @@ private void handleRun(final boolean verbose, Predicate<SketchController> should
     if (shouldSavePredicate.test(sketchController)) {
       handleSave(true);
     }
-    toolbar.activateRun();
+    verifyAction.setSelected(true);
     status.progress(tr("Compiling sketch..."));
 
     // do this to advance/clear the terminal window / dos prompt / etc
@@ -1790,7 +1788,7 @@ public void run() {
       }
 
       status.unprogress();
-      toolbar.deactivateRun();
+      verifyAction.setSelected(false);
     }
   }
 
@@ -2004,7 +2002,7 @@ public void run() {
 
 
   private boolean handleSave2() {
-    toolbar.activateSave();
+    saveSketchAction.setSelected(true);
     statusNotice(tr("Saving..."));
     boolean saved = false;
     try {
@@ -2038,13 +2036,13 @@ private boolean handleSave2() {
       // this is used when another operation calls a save
     }
     //toolbar.clear();
-    toolbar.deactivateSave();
+    saveSketchAction.setSelected(false);
     return saved;
   }
 
 
   public boolean handleSaveAs() {
-    toolbar.activateSave();
+    saveSketchAsAction.setSelected(true);
 
     //SwingUtilities.invokeLater(new Runnable() {
     //public void run() {
@@ -2068,7 +2066,7 @@ public boolean handleSaveAs() {
 
     } finally {
       // make sure the toolbar button deactivates
-      toolbar.deactivateSave();
+      saveSketchAsAction.setSelected(false);
     }
 
     return true;
@@ -2126,7 +2124,11 @@ synchronized public void handleExport(final boolean usingProgrammer) {
         handleSave(true);
       }
     }
-    toolbar.activateExport();
+    if (usingProgrammer)
+      uploadUsingProgrammerAction.setSelected(true);
+    else
+      uploadAction.setSelected(true);
+
     console.clear();
     status.progress(tr("Uploading to I/O Board..."));
 
@@ -2172,9 +2174,7 @@ public void run() {
       }
       status.unprogress();
       uploading = false;
-      //toolbar.clear();
-      toolbar.deactivateExport();
-
+      uploadAction.setSelected(false);
       resumeOrCloseSerialMonitor();
       resumeOrCloseSerialPlotter();
       base.onBoardOrPortChange();
@@ -2267,9 +2267,7 @@ public void run() {
       }
       status.unprogress();
       uploading = false;
-      //toolbar.clear();
-      toolbar.deactivateExport();
-
+      uploadUsingProgrammerAction.setSelected(false);
       resumeOrCloseSerialMonitor();
       resumeOrCloseSerialPlotter();
 
@@ -2547,8 +2545,6 @@ private void handlePrint() {
   public void statusError(String what) {
     System.err.println(what);
     status.error(what);
-    //new Exception("deactivating RUN").printStackTrace();
-    toolbar.deactivateRun();
   }