Fix last_green build after disable_autoloads flip

Explicitly loads all symbols affected by
`--incompatible_disable_autoloads_in_main_repo` to fix `last_green`
Bazel builds. Adds `rules_shell` as a dev dependency and updates files
to fix `test_bzlmod_macros.sh` and `test_dependency_versions.sh`.

As a result of using Buildifier to add the missing `load` statements,
Buildifier reordered the `load` statements as well.

Fixes the following breakage when using the `last_green` build from
bazelbuild/bazel@f08d561 (and other
breakages blocked by this one):

```sh
$ bazel run //tools:lint_check

ERROR: scala/private/rules/scala_test.bzl:130:21:
  name 'JavaInfo' is not defined

ERROR: .../external/+dev_deps+com_github_bazelbuild_buildtools/buildifier/BUILD.bazel:3:10:
  While resolving toolchains for target
  @@+dev_deps+com_github_bazelbuild_buildtools//buildifier:buildifier
  (b5bbebe): invalid registered toolchain
  '//test/proto:scalapb_toolchain':
  error loading package 'test/proto':
  at /Users/mbland/src/bazel-contrib/rules_scala/scala/scala.bzl:35:5:
  compilation of module 'scala/private/rules/scala_test.bzl' failed

ERROR: Analysis of target '//tools:lint_check' failed; build aborted:
  Analysis failed
```

Fixed using Buildifier 8.2.0 by first running the following to get the
list of appropriate warnings:

```txt
buildifier --lint=warn -r . 2>&1 | grep -- native- |
  awk '{print $2}' | sort | uniq
```

then running:

```txt
buildifier --lint=fix \
  --warnings=native-java-common,native-java-info,native-sh-test,native-sh-binary \
  -r .
```

I also ran it separately on the changed files in `deps/test` and
`scala/private/macros/test`, since Buildifier didn't automatically find
them.

---

bazelbuild/bazel@d87eaf5 from
2025-05-08 at 8:03am EDT flipped
`--incompatible_disable_autoloads_in_main_repo` to `true` to prepare for
Bazel 9. I did confirm that setting
`--noincompatible_disable_autoloads_in_main_repo` resolved the breakage
before using Buildifier to add the necessary `load` statements.

Pull request bazel-contrib#1735 was the last to pass the `last_green` CI build using
bazelbuild/bazel@94e0b44 from
2025-05-08 at 7:39am EDT. This was two commits before the commit that
flipped `--incompatible_disable_autoloads_in_main_repo`:

- https://buildkite.com/bazel/rules-scala-scala/builds/5596#0196afc2-4af3-4202-8232-d5f5fe113349

Pull request bazel-contrib#1736 failed the `last_green` CI build using
bazelbuild/bazel@cac54c4 from
2025-05-09 at 6:14am EDT. That job ran on 2025-05-09 at 6:47am EDT. The
`last_green` configuration in `.bazelci/presubmit.yml` emits a warning
if the build fails. This warning was present on the build page, but
we've overlooked it until now:

- https://buildkite.com/bazel/rules-scala-scala/builds/5598#0196b4a8-e593-431a-ab4c-8d8471d9b08b

Part of this change copies more files from `test/jmh` into the
`test_dependency_versions.sh` test directory. It also replicates targets
from `//test/jmh` in `deps/test/BUILD.bazel.test` to replace
the previous dependency on `@rules_scala//test/jmh:add_numbers`.

This is because `//test/jmh` now has a `load` dependency on
`@rules_shell`, which is a `dev_dependency` of `@rules_scala`. Since
`@rules_shell` isn't visible to `@rules_scala` when it isn't the root
module, this broke the build within `test_dependency_versions.sh`.

Author: mbland

MODULE.bazel

@@ -302,3 +302,4 @@ use_repo(
 )
 
 bazel_dep(name = "rules_python", version = "1.4.0", dev_dependency = True)
+bazel_dep(name = "rules_shell", version = "0.4.1", dev_dependency = True)

WORKSPACE

@@ -144,3 +144,20 @@ load("//scala/private/extensions:dev_deps.bzl", "dev_deps_repositories")
 dev_deps_repositories()
 
 register_toolchains("//test/toolchains:java21_toolchain_definition")
+
+http_archive(
+    name = "rules_shell",
+    sha256 = "bc61ef94facc78e20a645726f64756e5e285a045037c7a61f65af2941f4c25e1",
+    strip_prefix = "rules_shell-0.4.1",
+    url = "https://github.com/bazelbuild/rules_shell/releases/download/v0.4.1/rules_shell-v0.4.1.tar.gz",
+)
+
+load(
+    "@rules_shell//shell:repositories.bzl",
+    "rules_shell_dependencies",
+    "rules_shell_toolchains",
+)
+
+rules_shell_dependencies()
+
+rules_shell_toolchains()

deps/test/BUILD.bazel.test

@@ -8,6 +8,7 @@ load(
     "scalafmt_scala_test",
     "scrooge_transitive_outputs_test",
 )
+load("@rules_java//java:defs.bzl", "java_library")
 load("@rules_proto//proto:defs.bzl", "proto_library")
 load("@rules_scala//jmh:jmh.bzl", "scala_benchmark_jmh")
 load("@rules_scala//scala/scalafmt:phase_scalafmt_ext.bzl", "ext_scalafmt")
@@ -89,11 +90,37 @@ default_outputs_test(
 )
 
 # From: `test/jmh/BUILD`
+java_library(
+    name = "java_type",
+    srcs = ["JavaType.java"],
+    visibility = ["//visibility:public"],
+)
+
+scala_library(
+    name = "scala_type",
+    srcs = ["ScalaType.scala"],
+    visibility = ["//visibility:public"],
+)
+
+scala_library(
+    name = "add_numbers",
+    srcs = ["AddNumbers.scala"],
+    visibility = ["//visibility:public"],
+    exports = [
+        ":java_type",
+        ":scala_type",
+    ],
+    deps = [
+        ":java_type",
+        ":scala_type",
+    ],
+)
+
 scala_benchmark_jmh(
     name = "test_benchmark",
     srcs = ["TestBenchmark.scala"],
     data = ["data.txt"],
-    deps = ["@rules_scala//test/jmh:add_numbers"],
+    deps = [":add_numbers"],
 )
 
 # From: `test/src/main/scala/scalarules/test/twitter_scrooge/BUILD`

deps/test/defs.bzl

@@ -1,5 +1,6 @@
-load("@bazel_skylib//lib:unittest.bzl", "analysistest", "asserts", "unittest")
 load("@bazel_skylib//lib:collections.bzl", "collections")
+load("@bazel_skylib//lib:unittest.bzl", "analysistest", "asserts", "unittest")
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
 load("@rules_scala//scala:advanced_usage/scala.bzl", "make_scala_test")
 load("@rules_scala//scala/scalafmt:phase_scalafmt_ext.bzl", "ext_scalafmt")
 

examples/semanticdb/BUILD

@@ -1,5 +1,5 @@
-load("@rules_scala//scala:scala_toolchain.bzl", "scala_toolchain")
 load("@rules_scala//scala:scala.bzl", "scala_binary", "scala_library")
+load("@rules_scala//scala:scala_toolchain.bzl", "scala_toolchain")
 
 scala_toolchain(
     name = "semanticdb_toolchain_impl",

jmh/jmh.bzl

@@ -1,3 +1,5 @@
+load("@rules_java//java/common:java_common.bzl", "java_common")
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
 load("//scala/private:rules/scala_binary.bzl", "scala_binary")
 load("//scala/private:rules/scala_library.bzl", "scala_library")
 

jmh/toolchain/toolchain.bzl

@@ -1,10 +1,10 @@
-load("//scala/private/toolchain_deps:toolchain_deps.bzl", "expose_toolchain_deps")
+load("@rules_scala_config//:config.bzl", "SCALA_VERSION")
 load("//scala:providers.bzl", "declare_deps_provider", _DepsInfo = "DepsInfo")
 load(
     "//scala:scala_cross_version.bzl",
     _versioned_repositories = "repositories",
 )
-load("@rules_scala_config//:config.bzl", "SCALA_VERSION")
+load("//scala/private/toolchain_deps:toolchain_deps.bzl", "expose_toolchain_deps")
 
 DEP_PROVIDERS = [
     "jmh_classpath",

manual_test/scala_test_jacocorunner/BUILD

@@ -1,5 +1,5 @@
-load("//scala:scala_toolchain.bzl", "scala_toolchain")
 load("//scala:scala.bzl", "scala_test")
+load("//scala:scala_toolchain.bzl", "scala_toolchain")
 
 scala_toolchain(
     name = "passing_toolchain_impl",

manual_test/scala_test_jvm_flags/BUILD

@@ -1,5 +1,5 @@
-load("//scala:scala_toolchain.bzl", "scala_toolchain")
 load("//scala:scala.bzl", "scala_test")
+load("//scala:scala_toolchain.bzl", "scala_toolchain")
 
 scala_toolchain(
     name = "failing_toolchain_impl",

manual_test/scalac_jvm_opts/BUILD

@@ -1,6 +1,6 @@
 load("@rules_proto//proto:defs.bzl", "proto_library")
-load("//scala:scala_toolchain.bzl", "scala_toolchain")
 load("//scala:scala.bzl", "scala_library")
+load("//scala:scala_toolchain.bzl", "scala_toolchain")
 load("//scala_proto:scala_proto.bzl", "scala_proto_library")
 
 scala_toolchain(

protoc/private/protoc_toolchains.bzl

@@ -3,14 +3,14 @@
 Provides precompiled protocol compiler toolchains.
 """
 
+load("@com_google_protobuf//:protobuf_version.bzl", "PROTOC_VERSION")
+load("@platforms//host:constraints.bzl", "HOST_CONSTRAINTS")
 load(":private/protoc_integrity.bzl", "PROTOC_BUILDS", "PROTOC_DOWNLOAD_URL")
 load(
     ":private/toolchain_impl.bzl",
     "PROTOC_TOOLCHAIN_ENABLED",
     "PROTOC_TOOLCHAIN_TYPE",
 )
-load("@com_google_protobuf//:protobuf_version.bzl", "PROTOC_VERSION")
-load("@platforms//host:constraints.bzl", "HOST_CONSTRAINTS")
 
 def _default_platform():
     host_platform = sorted(HOST_CONSTRAINTS)

scala/BUILD

@@ -1,7 +1,7 @@
-load("//scala:scala_cross_version.bzl", "version_suffix")
-load("//scala:scala_toolchain.bzl", "scala_toolchain")
 load("@rules_java//java:defs.bzl", "java_import", "java_library")
 load("@rules_scala_config//:config.bzl", "SCALA_VERSION")
+load("//scala:scala_cross_version.bzl", "version_suffix")
+load("//scala:scala_toolchain.bzl", "scala_toolchain")
 
 toolchain_type(
     name = "toolchain_type",

scala/extensions/config.bzl

@@ -4,16 +4,16 @@ Provides the `scala_config` module extension with the `settings` tag class.
 See the `_settings_attrs` dict for documentation.
 """
 
-load(
-    "//scala/private:macros/bzlmod.bzl",
-    "root_module_tags",
-    "single_tag_values",
-)
 load(
     "//:scala_config.bzl",
     "DEFAULT_SCALA_VERSION",
     _scala_config = "scala_config",
 )
+load(
+    "//scala/private:macros/bzlmod.bzl",
+    "root_module_tags",
+    "single_tag_values",
+)
 
 _settings_defaults = {
     "scala_version": DEFAULT_SCALA_VERSION,

scala/extensions/deps.bzl

@@ -21,15 +21,15 @@ See the `scala/private/macros/bzlmod.bzl` docstring for a description of
 the defaults, attrs, and tag class dictionaries pattern employed here.
 """
 
+load("//scala:scala_cross_version.bzl", "default_maven_server_urls")
+load("//scala:toolchains.bzl", "scala_toolchains")
 load(
     "//scala/private:macros/bzlmod.bzl",
     "repeated_tag_values",
     "root_module_tags",
     "single_tag_values",
 )
 load("//scala/private:toolchain_defaults.bzl", "TOOLCHAIN_DEFAULTS")
-load("//scala:scala_cross_version.bzl", "default_maven_server_urls")
-load("//scala:toolchains.bzl", "scala_toolchains")
 
 _settings_defaults = {
     "maven_servers": default_maven_server_urls(),

scala/private/common.bzl

@@ -1,7 +1,8 @@
+load("@bazel_skylib//lib:paths.bzl", "paths")
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
 load("//scala:jars_to_labels.bzl", "JarsToLabelsInfo")
 load("//scala:plusone.bzl", "PlusOneDeps")
 load("//scala:providers.bzl", "ScalaInfo")
-load("@bazel_skylib//lib:paths.bzl", "paths")
 
 def write_manifest_file(actions, output_file, main_class):
     # TODO(bazel-team): I don't think this classpath is what you want

scala/private/common_attributes.bzl

@@ -1,13 +1,15 @@
 """Shared attributes for rules"""
 
-load(
-    "//scala/private:coverage_replacements_provider.bzl",
-    _coverage_replacements_provider = "coverage_replacements_provider",
-)
+load("@rules_java//java/common:java_common.bzl", "java_common")
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
 load(
     "//scala:plusone.bzl",
     _collect_plus_one_deps_aspect = "collect_plus_one_deps_aspect",
 )
+load(
+    "//scala/private:coverage_replacements_provider.bzl",
+    _coverage_replacements_provider = "coverage_replacements_provider",
+)
 
 common_attrs_for_plugin_bootstrapping = {
     "srcs": attr.label_list(allow_files = [

scala/private/coverage_replacements_provider.bzl

@@ -18,6 +18,8 @@
 # duplicate providers.
 #
 
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
+
 _CoverageReplacements = provider(
     fields = {
         "replacements": "hash of files to swap out",

scala/private/extensions/dev_deps.bzl

@@ -1,14 +1,14 @@
 """Repositories for testing rules_scala itself"""
 
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+load("//scala:scala_cross_version.bzl", "default_maven_server_urls")
+load("//scala:scala_maven_import_external.bzl", "java_import_external")
 load(
     "//scala/private:macros/bzlmod.bzl",
     "root_module_tags",
     "single_tag_values",
 )
-load("//scala:scala_cross_version.bzl", "default_maven_server_urls")
-load("//scala:scala_maven_import_external.bzl", "java_import_external")
 load("//third_party/repositories:repositories.bzl", "repositories")
-load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 _BUILD_TOOLS_RELEASE = "5.1.0"
 

scala/private/macros/scala_repositories.bzl

@@ -1,11 +1,11 @@
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+load("@rules_scala_config//:config.bzl", "SCALA_VERSIONS")
 load(
     "//scala:scala_cross_version.bzl",
     "extract_major_version",
     "extract_minor_version",
     "version_suffix",
 )
-load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
-load("@rules_scala_config//:config.bzl", "SCALA_VERSIONS")
 
 def _dt_patched_compiler_impl(rctx):
     # Need to give the file a .zip extension so rctx.extract knows what type of archive it is

scala/private/macros/setup_scala_toolchain.bzl

@@ -1,7 +1,7 @@
-load("//scala:scala_toolchain.bzl", "scala_toolchain")
+load("@rules_scala_config//:config.bzl", "SCALA_VERSION")
 load("//scala:providers.bzl", "declare_deps_provider")
 load("//scala:scala_cross_version.bzl", "repositories", "version_suffix")
-load("@rules_scala_config//:config.bzl", "SCALA_VERSION")
+load("//scala:scala_toolchain.bzl", "scala_toolchain")
 
 def setup_scala_toolchain(
         name,

scala/private/macros/test/BUILD.bzlmod_test

@@ -1,11 +1,12 @@
 """Used by test/shell/test_bzlmod_helpers.sh to test bzlmod.bzl."""
 
+load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
 load(
     "@test_tag_values//:results.bzl",
     "FIRST",
+    "REPEATED",
     "SECOND",
     "THIRD",
-    "REPEATED",
 )
 
 sh_binary(

scala/private/macros/test/MODULE.bzlmod_test

@@ -16,3 +16,5 @@ dev_test_ext = use_extension(
     "test_ext",
     dev_dependency = True,
 )
+
+bazel_dep(name = "rules_shell", version = "0.4.1")

scala/private/phases/api.bzl

@@ -2,11 +2,11 @@
 The phase API for rules implementation
 """
 
+load("@bazel_skylib//lib:dicts.bzl", "dicts")
 load(
     "//scala:advanced_usage/providers.bzl",
     _ScalaRulePhase = "ScalaRulePhase",
 )
-load("@bazel_skylib//lib:dicts.bzl", "dicts")
 
 # A method to modify the built-in phase list
 # - Insert new phases to the first/last position

scala/private/phases/phase_collect_jars.bzl

@@ -1,3 +1,5 @@
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
+
 #
 # PHASE: collect jars
 #

scala/private/phases/phase_compile.bzl

@@ -1,3 +1,6 @@
+load("@rules_java//java/common:java_common.bzl", "java_common")
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
+
 #
 # PHASE: compile
 #

scala/private/phases/phase_jvm_flags.bzl

@@ -1,3 +1,5 @@
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
+
 #
 # PHASE: jvm flags
 #

scala/private/phases/phase_scalac_provider.bzl

@@ -1,10 +1,11 @@
+load("//scala:providers.bzl", _ScalacProvider = "ScalacProvider")
+
 #
 # PHASE: scalac provider
 #
 # DOCUMENT THIS
 #
 load("//scala/private/toolchain_deps:toolchain_deps.bzl", "find_deps_info_on")
-load("//scala:providers.bzl", _ScalacProvider = "ScalacProvider")
 
 def phase_scalac_provider(ctx, p):
     toolchain_type_label = "//scala:toolchain_type"

scala/private/phases/phase_semanticdb.bzl

@@ -1,6 +1,7 @@
-load("//scala/private/toolchain_deps:toolchain_deps.bzl", "find_deps_info_on")
-load("//scala:semanticdb_provider.bzl", "SemanticdbInfo")
 load("@bazel_skylib//lib:paths.bzl", "paths")
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
+load("//scala:semanticdb_provider.bzl", "SemanticdbInfo")
+load("//scala/private/toolchain_deps:toolchain_deps.bzl", "find_deps_info_on")
 
 def phase_semanticdb(ctx, p):
     #semanticdb_bundle_in_jar feature: enables bundling the semanticdb files within the output jar.

scala/private/phases/phases.bzl

@@ -7,6 +7,7 @@ load(
     _extras_phases = "extras_phases",
     _run_phases = "run_phases",
 )
+load("//scala/private:phases/phase_collect_exports_jars.bzl", _phase_collect_exports_jars = "phase_collect_exports_jars")
 load(
     "//scala/private:phases/phase_collect_jars.bzl",
     _phase_collect_jars_common = "phase_collect_jars_common",
@@ -15,7 +16,6 @@ load(
     _phase_collect_jars_repl = "phase_collect_jars_repl",
     _phase_collect_jars_scalatest = "phase_collect_jars_scalatest",
 )
-load("//scala/private:phases/phase_collect_exports_jars.bzl", _phase_collect_exports_jars = "phase_collect_exports_jars")
 load("//scala/private:phases/phase_collect_srcjars.bzl", _phase_collect_srcjars = "phase_collect_srcjars")
 load(
     "//scala/private:phases/phase_compile.bzl",

scala/private/rule_impls.bzl

@@ -14,6 +14,7 @@
 """Rules for supporting the Scala language."""
 
 load("@bazel_skylib//lib:paths.bzl", "paths")
+load("@rules_java//java/common:java_common.bzl", "java_common")
 load("@rules_java//toolchains:toolchain_utils.bzl", "find_java_toolchain")
 load(":common.bzl", "rlocationpath_from_rootpath", _collect_plugin_paths = "collect_plugin_paths")
 load(":resources.bzl", _resource_paths = "paths")

scala/private/rules/scala_binary.bzl

@@ -1,6 +1,9 @@
 """Builds Scala binaries"""
 
 load("@bazel_skylib//lib:dicts.bzl", _dicts = "dicts")
+load("@rules_java//java/common:java_common.bzl", "java_common")
+load("@rules_java//java/common:java_info.bzl", "JavaInfo")
+load("//scala:scala_cross_version.bzl", "scala_version_transition", "toolchain_transition_attr")
 load(
     "//scala/private:common_attributes.bzl",
     "common_attrs",
@@ -9,7 +12,6 @@ load(
     "resolve_deps",
 )
 load("//scala/private:common_outputs.bzl", "common_outputs")
-load("//scala:scala_cross_version.bzl", "scala_version_transition", "toolchain_transition_attr")
 load(
     "//scala/private:phases/phases.bzl",
     "extras_phases",