Skip to content

Commit 6815597

Browse files
committed
docs: add blocking requirement to monitor and respond to PR feedback
Updates PROMPT.md to enforce that Contributors must: - Check for open PR feedback BEFORE starting new work (blocking) - Implement requested fixes immediately using TDD - Self-verify with build and tests - Reply to comments with verification confirmation - NOT proceed to new tasks while PRs have unresolved feedback Updated in three locations: 1. EXTREMELY-IMPORTANT section (blocking requirement) 2. Workflow Rules section (steps 3-4, 14) 3. Instructions for Claude (steps 2, 10) This ensures Contributors prioritize addressing review feedback over starting new tasks, improving PR turnaround time.
1 parent 2d3b963 commit 6815597

1 file changed

Lines changed: 26 additions & 16 deletions

File tree

PROMPT.md

Lines changed: 26 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@
1313
> - See CLAUDE.local.md "CRITICAL: Verify Both Git and GitHub CLI Credentials" section
1414
> - All changes need to be done via feature branch and merged via PR
1515
> - Work as `Contributor` implementing code changes and raising PR's. Do not review PR's unless explicitly prompted by the user - just monitor active PR and Issues for comment feedback.
16+
> - **BLOCKING: Monitor ALL open PRs for feedback**
17+
> - Check open PRs created by Contributor account for comments or "Changes requested" reviews
18+
> - Implement requested fixes immediately using TDD approach
19+
> - Self-verify fixes with `dotnet build --warnaserror && dotnet test`
20+
> - Reply to review comments with: "Fixed. Changes verified - ready for re-review."
21+
> - DO NOT proceed to new tasks while open PRs have unresolved feedback
1622
1723
</EXTREMELY-IMPORTANT>
1824

@@ -110,15 +116,17 @@ See **[docs/plans/rules-engine-design.md](docs/plans/rules-engine-design.md)** f
110116

111117
1. **FIRST: Verify credentials** - Run `./scripts/verify-credentials.sh contributor` before any work
112118
2. Work as Contributor
113-
3. Check for GitHub issue before any work
114-
4. Create feature branch: `feature/<issue>-<description>`
115-
5. Write failing tests first
116-
6. Implement to pass tests
117-
7. Run `dotnet build --warnaserror && dotnet test`
118-
8. **BEFORE COMMIT: Re-verify credentials** - Run `./scripts/verify-credentials.sh contributor`
119-
9. Commit with: `<type>: <description>\n\nRefs #<issue>`
120-
10. **BEFORE PR: Re-verify credentials** - Run `./scripts/verify-credentials.sh contributor`
121-
11. Create PR and request review
119+
3. **BLOCKING: Check for open PR feedback** - Run `gh pr list --author martincjarvis --state open` and check for review comments
120+
4. **If PR has feedback**: Implement requested changes immediately (skip to new tasks only after all feedback resolved)
121+
5. Check for GitHub issue before any work
122+
6. Create feature branch: `feature/<issue>-<description>`
123+
7. Write failing tests first
124+
8. Implement to pass tests
125+
9. Run `dotnet build --warnaserror && dotnet test`
126+
10. **BEFORE COMMIT: Re-verify credentials** - Run `./scripts/verify-credentials.sh contributor`
127+
11. Commit with: `<type>: <description>
128+
129+
Refs #<issue>`12. **BEFORE PR: Re-verify credentials** - Run`./scripts/verify-credentials.sh contributor` 13. Create PR and request review 14. **AFTER PR: Monitor for feedback** - Check PR regularly for review comments and respond immediately
122130

123131
### Commit Types
124132

@@ -139,10 +147,12 @@ Reference `docs/design/` for game mechanics specifications (gdd-core.md, gdd-cla
139147
1. Read these files in order:
140148
- `CLAUDE.md` and `AGENTS.md` - Project rules and workflows
141149
- `docs/plans/rules-engine-design.md` - Architecture, design, and progress
142-
2. Check Epic Status Overview for current progress and next tasks
143-
3. For completed epics, examine Code Reference paths for implementation patterns
144-
4. Reference `docs/design/gdd-*.md` for game mechanics details
145-
5. Always reference the GitHub issue in commits
146-
6. Use TDD - write failing tests before implementation
147-
7. Run verification: `dotnet build --warnaserror && dotnet test`
148-
8. Update progress tracking after completing tasks
150+
2. **BLOCKING: Check for open PR feedback FIRST** - Run `gh pr list --author martincjarvis --state open` and prioritize addressing any review comments
151+
3. Check Epic Status Overview for current progress and next tasks
152+
4. For completed epics, examine Code Reference paths for implementation patterns
153+
5. Reference `docs/design/gdd-*.md` for game mechanics details
154+
6. Always reference the GitHub issue in commits
155+
7. Use TDD - write failing tests before implementation
156+
8. Run verification: `dotnet build --warnaserror && dotnet test`
157+
9. Update progress tracking after completing tasks
158+
10. After creating PR, monitor for feedback and respond immediately

0 commit comments

Comments
 (0)