Skip to content

Dumped tasks are disconnected from their batch #5832

@Mubelotix

Description

@Mubelotix

Describe the bug

Batch uids get set to null on all tasks when dumped.

// Patch the task to remove the batch uid, because as of v1.12.5 batches are not persisted.
// This prevent from referencing *future* batches not actually associated with the task.
//
// See <https://github.com/meilisearch/meilisearch/issues/5247> for details.
t.batch_uid = None;

This should have been removed when #5247 was fixed.

To Reproduce

  1. Perform a dump

Expected behavior

Batch uids should be stored

Meilisearch version:

branch main, all versions since v1.13

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions