Skip to content

Commit 4a16cd3

Browse files
Merge #312
312: Update wana_kana to 4.0.0 r=ManyTheFish a=tats-u # Pull Request ## Related issue - Fixes #313 - meilisearch/meilisearch#3588 (comment) - PSeitz/wana_kana_rust#13 - meilisearch/meilisearch@0fbda63 - https://github.com/orgs/meilisearch/discussions/532#discussioncomment-9999921 ## What does this PR do? `wana_kana` used to easily panic. The panicability made it difficult to adopt it in the Meilisearch core. Update it to the latest version that [doesn't panic](https://github.com/orgs/meilisearch/discussions/532#discussioncomment-10814507). ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Tatsunori Uchino <[email protected]>
2 parents 1b48ada + bacd1c1 commit 4a16cd3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

charabia/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ lindera = { version = "=0.32.2", default-features = false, optional = true }
2626
pinyin = { version = "0.10", default-features = false, features = [
2727
"with_tone",
2828
], optional = true }
29-
wana_kana = { version = "3.0.0", optional = true }
29+
wana_kana = { version = "4.0.0", optional = true }
3030
unicode-normalization = "0.1.23"
3131
irg-kvariants = { path = "../irg-kvariants", version = "=0.1.1" }
3232

@@ -43,7 +43,7 @@ chinese-normalization-pinyin = ["dep:pinyin", "chinese-normalization"]
4343
hebrew = []
4444

4545
# allow japanese specialized tokenization
46-
japanese = ["japanese-segmentation-unidic"]
46+
japanese = ["japanese-segmentation-unidic", "japanese-transliteration"]
4747
japanese-segmentation-ipadic = ["lindera/ipadic", "lindera/compress"]
4848
japanese-segmentation-unidic = ["lindera/unidic", "lindera/compress"]
4949
japanese-transliteration = ["dep:wana_kana"]

0 commit comments

Comments
 (0)