Skip to content

Commit 342e4ff

Browse files
committed
Merge branch 'fix_geo_point' of github.com:meilisearch/firestore-meilisearch into fix_geo_point
2 parents f0cf6cf + 1fdb61e commit 342e4ff

File tree

7 files changed

+17
-86
lines changed

7 files changed

+17
-86
lines changed

functions/__tests__/adapter.test.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { mockConsoleInfo } from './__mocks__/console'
33
import * as firestore from 'firebase-admin/firestore'
44
import {
55
adaptDocumentForMeilisearch,
6-
adaptFields,
6+
adaptFieldsForMeilisearch,
77
} from '../src/meilisearch-adapter'
88
import defaultDocument from './data/document'
99

@@ -65,14 +65,20 @@ describe('extensions process', () => {
6565
describe('adaptValues', () => {
6666
test('adaptValues an id value', () => {
6767
expect(
68-
adaptFields({ id: defaultDocument.id } as firestore.DocumentData, 'id')
68+
adaptFieldsForMeilisearch(
69+
{ id: defaultDocument.id } as firestore.DocumentData,
70+
'id'
71+
)
6972
).toStrictEqual({ id: defaultDocument.id })
7073
})
7174
test('adaptValues a geo point value', () => {
7275
const geoPoint = new firestore.GeoPoint(48.866667, 2.333333)
7376

7477
expect(
75-
adaptFields({ _geo: geoPoint } as firestore.DocumentData, '_geo')
78+
adaptFieldsForMeilisearch(
79+
{ _geo: geoPoint } as firestore.DocumentData,
80+
'_geo'
81+
)
7682
).toStrictEqual({
7783
_geo: {
7884
lat: 48.866667,
@@ -87,7 +93,7 @@ describe('extensions process', () => {
8793
const geoPoint = new firestore.GeoPoint(48.866667, 2.333333)
8894

8995
expect(
90-
adaptFields(
96+
adaptFieldsForMeilisearch(
9197
{ wrong_geo: geoPoint } as firestore.DocumentData,
9298
'wrong_geo'
9399
)

functions/lib/adapter.js

Lines changed: 0 additions & 58 deletions
This file was deleted.

functions/lib/import/index.js

100755100644
File mode changed.

functions/lib/meilisearch-adapter.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
Object.defineProperty(exports, "__esModule", { value: true });
3-
exports.adaptDocumentForMeilisearch = exports.adaptFields = exports.parseFieldsToIndex = exports.isAFieldToIndex = void 0;
3+
exports.adaptDocumentForMeilisearch = exports.adaptFieldsForMeilisearch = exports.parseFieldsToIndex = exports.isAFieldToIndex = void 0;
44
const firestore = require("firebase-admin/firestore");
55
const logs_1 = require("./logs");
66
/**
@@ -47,7 +47,7 @@ exports.parseFieldsToIndex = parseFieldsToIndex;
4747
* @param {string[]} rawFieldsToIndex
4848
* @return {firestore.DocumentData} A properly formatted array of field and value.
4949
*/
50-
function adaptFields(document, rawFieldsToIndex) {
50+
function adaptFieldsForMeilisearch(document, rawFieldsToIndex) {
5151
const fieldsToIndex = parseFieldsToIndex(rawFieldsToIndex);
5252
return Object.keys(document).reduce((doc, currentField) => {
5353
const value = document[currentField];
@@ -68,7 +68,7 @@ function adaptFields(document, rawFieldsToIndex) {
6868
return { ...doc, [currentField]: value };
6969
}, {});
7070
}
71-
exports.adaptFields = adaptFields;
71+
exports.adaptFieldsForMeilisearch = adaptFieldsForMeilisearch;
7272
/**
7373
* Adapts documents from the Firestore database to Meilisearch compatible documents.
7474
* @param {string} documentId Document id.
@@ -81,7 +81,7 @@ function adaptDocumentForMeilisearch(documentId, snapshot, rawFieldsToIndex) {
8181
if ('_firestore_id' in data) {
8282
delete data.id;
8383
}
84-
const adaptedDoc = adaptFields(data, rawFieldsToIndex);
84+
const adaptedDoc = adaptFieldsForMeilisearch(data, rawFieldsToIndex);
8585
return { _firestore_id: documentId, ...adaptedDoc };
8686
}
8787
exports.adaptDocumentForMeilisearch = adaptDocumentForMeilisearch;

functions/lib/meilisearch-index.js

Lines changed: 0 additions & 17 deletions
This file was deleted.

functions/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,4 @@
5050
"typescript": "^4.4.3"
5151
},
5252
"bin": "lib/import/index.js"
53-
}
53+
}

functions/src/meilisearch-adapter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export function parseFieldsToIndex(fieldsToIndex: string): string[] {
7171
* @param {string[]} rawFieldsToIndex
7272
* @return {firestore.DocumentData} A properly formatted array of field and value.
7373
*/
74-
export function adaptFields(
74+
export function adaptFieldsForMeilisearch(
7575
document: firestore.DocumentData,
7676
rawFieldsToIndex: string
7777
): firestore.DocumentData {
@@ -112,7 +112,7 @@ export function adaptDocumentForMeilisearch(
112112
if ('_firestore_id' in data) {
113113
delete data.id
114114
}
115-
const adaptedDoc = adaptFields(data, rawFieldsToIndex)
115+
const adaptedDoc = adaptFieldsForMeilisearch(data, rawFieldsToIndex)
116116

117117
return { _firestore_id: documentId, ...adaptedDoc }
118118
}

0 commit comments

Comments
 (0)