-
Notifications
You must be signed in to change notification settings - Fork 97
Ensure the error handling are following the best practice #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @brunoocasali, I am new to this project and would like to work on this one. I recently learnt go basics, so I think this would be a good issue for me. |
@brunoocasali can you assign me this ? |
Hi @heysujal We prefer not assigning external people to our issues. |
Understood |
Hi, I have not been able to figure it out like how to go about doing this. |
@brunoocasali I reviewed the error handling. The current implementation aligns well with common best practices, including structured error handling, contextual error messages, and integration with API-specific errors. However, there is room for improvement in the future. |
Ok, so I close the issue ✅ feel free to open an new one with future improvements |
Uh oh!
There was an error while loading. Please reload this page.
Also, if you are a maintainer, please add any clarification and instructions about this issue.
Sorry if this is already wholly/partially implemented. Feel free to let me know about the state of this issue in the repo.
Related to meilisearch/integration-guides#267
Ensure this SDK follows the following guidelines:
MeilisearchCommunicationError
MeilisearchApiError
MeilisearchError
Essentially all the error should extend from
MeilisearchError
, the consumers should have a way to catch all the errors.Let us know if this is not clear, or you have better idea!
TODO:
MeilisearchError
which will extend the standard error if it does not exist (when the language supports)MeilisearchCommunicationError
since it is not a Meilisearch error anyway.The text was updated successfully, but these errors were encountered: