Skip to content

Commit b626044

Browse files
committed
Make task tests more relevant
1 parent 9502482 commit b626044

File tree

1 file changed

+15
-46
lines changed

1 file changed

+15
-46
lines changed

tests/task.test.ts

Lines changed: 15 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -94,32 +94,18 @@ describe.each([{ permission: 'Master' }, { permission: 'Private' }])(
9494

9595
const tasks = await client.getTasks()
9696

97-
expect(tasks.results[0]).toHaveProperty(
98-
'status',
99-
TaskStatus.TASK_SUCCEEDED
100-
)
101-
expect(tasks.results[0].indexUid).toEqual(index.uid)
102-
expect(tasks.results[0].status).toEqual(TaskStatus.TASK_SUCCEEDED)
103-
expect(tasks.results[0].type).toEqual(
104-
TaskTypes.DOCUMENTS_ADDITION_OR_UPDATE
105-
)
106-
expect(tasks.results[0].enqueuedAt).toBeDefined()
107-
expect(tasks.results[0].uid).toBeDefined()
108-
expect(tasks.results[0].type).toEqual(
109-
TaskTypes.DOCUMENTS_ADDITION_OR_UPDATE
110-
)
111-
expect(tasks.results[0].duration).toBeDefined()
112-
expect(tasks.results[0].finishedAt).toBeDefined()
113-
expect(tasks.results[0].startedAt).toBeDefined()
97+
expect(tasks.results).toBeInstanceOf(Array)
98+
expect(tasks.results[0].uid).toEqual(enqueuedTask.taskUid)
11499
})
115100

116101
test(`${permission} key: Get all tasks with type filter`, async () => {
117102
const client = await getClient(permission)
118103
const task1 = await client.index(index.uid).addDocuments([{ id: 1 }])
119-
await client.waitForTask(task1.taskUid)
120-
121104
const task2 = await client.index(index.uid).deleteDocument(1)
105+
const task3 = await client.createIndex(index2.uid)
106+
await client.waitForTask(task1.taskUid)
122107
await client.waitForTask(task2.taskUid)
108+
await client.waitForTask(task3.taskUid)
123109

124110
const tasks = await client.getTasks({
125111
type: [
@@ -144,19 +130,17 @@ describe.each([{ permission: 'Master' }, { permission: 'Private' }])(
144130
const tasks = await client.getTasks({
145131
status: [TaskStatus.TASK_SUCCEEDED, TaskStatus.TASK_FAILED],
146132
})
147-
const onlySuccesFullTasks = new Set(
133+
const onlySuccesfullTasks = new Set(
148134
tasks.results.map((task) => task.status)
149135
)
150136

151-
expect(onlySuccesFullTasks.size).toEqual(2)
137+
expect(onlySuccesfullTasks.size).toEqual(2)
152138
})
153139

154140
test(`${permission} key: Get all tasks with indexUid filter`, async () => {
155141
const client = await getClient(permission)
156-
const task1 = await client.index(index.uid).addDocuments([{ id: 1 }])
157-
const task2 = await client.index(index2.uid).addDocuments([{ id: 1 }])
158-
await client.waitForTask(task1.taskUid)
159-
await client.waitForTask(task2.taskUid)
142+
await client.index(index.uid).addDocuments([{ id: 1 }])
143+
await client.index(index2.uid).addDocuments([{ id: 1 }])
160144

161145
const tasks = await client.getTasks({
162146
indexUid: [index.uid, index2.uid],
@@ -170,30 +154,15 @@ describe.each([{ permission: 'Master' }, { permission: 'Private' }])(
170154

171155
test(`${permission} key: Get all indexes tasks with index instance`, async () => {
172156
const client = await getClient(permission)
173-
const enqueuedTask = await client
174-
.index(index.uid)
175-
.addDocuments([{ id: 1 }])
176-
await client.waitForTask(enqueuedTask.taskUid)
157+
await client.index(index.uid).addDocuments([{ id: 1 }])
158+
await client.index(index2.uid).addDocuments([{ id: 1 }])
177159

178160
const tasks = await client.index(index.uid).getTasks()
179-
180-
expect(tasks.results[0]).toHaveProperty(
181-
'status',
182-
TaskStatus.TASK_SUCCEEDED
183-
)
184-
expect(tasks.results[0].indexUid).toEqual(index.uid)
185-
expect(tasks.results[0].status).toEqual(TaskStatus.TASK_SUCCEEDED)
186-
expect(tasks.results[0].type).toEqual(
187-
TaskTypes.DOCUMENTS_ADDITION_OR_UPDATE
188-
)
189-
expect(tasks.results[0].enqueuedAt).toBeDefined()
190-
expect(tasks.results[0].uid).toBeDefined()
191-
expect(tasks.results[0].type).toEqual(
192-
TaskTypes.DOCUMENTS_ADDITION_OR_UPDATE
161+
const onlyTaskWithSameUid = new Set(
162+
tasks.results.map((task) => task.indexUid)
193163
)
194-
expect(tasks.results[0].duration).toBeDefined()
195-
expect(tasks.results[0].finishedAt).toBeDefined()
196-
expect(tasks.results[0].startedAt).toBeDefined()
164+
165+
expect(onlyTaskWithSameUid.size).toEqual(2)
197166
})
198167

199168
test(`${permission} key: Try to get a task that does not exist`, async () => {

0 commit comments

Comments
 (0)