fix

Author: w1ndcn

meilisearch/client.py

@@ -30,10 +30,10 @@
     MeilisearchError,
 )
 from meilisearch.index import Index
+from meilisearch.models.dynamic_search_rule import DynamicSearchRule, DynamicSearchRuleResults
 from meilisearch.models.key import Key, KeysResults
 from meilisearch.models.task import Batch, BatchResults, Task, TaskInfo, TaskResults
 from meilisearch.models.webhook import Webhook, WebhooksResults
-from meilisearch.models.dynamic_search_rule import DynamicSearchRule, DynamicSearchRuleResults
 from meilisearch.task import TaskHandler
 
 
@@ -601,9 +601,9 @@ def delete_webhook(self, webhook_uuid: str) -> int:
         """
         response = self.http.delete(f"{self.config.paths.webhooks}/{webhook_uuid}")
         return response.status_code
-    
+
     # DYNAMIC SEARCH RULES ROUTES
-    
+
     def get_dynamic_search_rules(self) -> DynamicSearchRuleResults:
         """Get all dynamic search rules.
 
@@ -675,7 +675,6 @@ def create_or_update_dynamic_search_rule(
         rule = self.http.patch(f"{self.config.paths.dynamic_search_rules}/{uid}", options)
         return DynamicSearchRule(**rule)
 
-
     def delete_dynamic_search_rule(self, uid: str) -> int:
         """Delete a dynamic search rule.
 
@@ -700,7 +699,6 @@ def delete_dynamic_search_rule(self, uid: str) -> int:
         response = self.http.delete(f"{self.config.paths.dynamic_search_rules}/{uid}")
         return response.status_code
 
-
     def get_version(self) -> Dict[str, str]:
         """Get version Meilisearch
 

meilisearch/models/dynamic_search_rule.py

@@ -24,4 +24,4 @@ class DynamicSearchRuleResults(CamelBase):
     results: List[DynamicSearchRule]
     offset: int
     limit: int
-    total: int
+    total: int

tests/client/test_client_dynamic_search_rules_meilisearch.py

@@ -4,6 +4,8 @@
 
 from meilisearch.errors import MeilisearchApiError
 
+pytestmark = pytest.mark.usefixtures("enable_dynamic_search_rules")
+
 
 def test_get_dynamic_search_rules_empty(client):
     """Test getting dynamic search rules when none exist."""
@@ -19,13 +21,11 @@ def test_create_or_update_dynamic_search_rule(client):
         "description": "Test rule for promotion",
         "priority": 10,
         "active": True,
-        "conditions": [
-            {"scope": "query", "isEmpty": True}
-        ],
+        "conditions": [{"scope": "query", "isEmpty": True}],
         "actions": [
             {
                 "selector": {"indexUid": "movies", "id": "123"},
-                "action": {"type": "pin", "position": 1}
+                "action": {"type": "pin", "position": 1},
             }
         ],
     }
@@ -68,13 +68,11 @@ def test_update_dynamic_search_rule(client):
         "description": "Original description",
         "priority": 10,
         "active": True,
-        "conditions": [
-            {"scope": "query", "isEmpty": True}
-        ],
+        "conditions": [{"scope": "query", "isEmpty": True}],
         "actions": [
             {
                 "selector": {"indexUid": "movies", "id": "123"},
-                "action": {"type": "pin", "position": 1}
+                "action": {"type": "pin", "position": 1},
             }
         ],
     }

tests/conftest.py

@@ -352,3 +352,20 @@ def enable_network_options():
         json={"network": False},
         timeout=10,
     )
+
+
+@fixture
+def enable_dynamic_search_rules():
+    requests.patch(
+        f"{common.BASE_URL}/experimental-features",
+        headers={"Authorization": f"Bearer {common.MASTER_KEY}"},
+        json={"dynamicSearchRules": True},
+        timeout=10,
+    )
+    yield
+    requests.patch(
+        f"{common.BASE_URL}/experimental-features",
+        headers={"Authorization": f"Bearer {common.MASTER_KEY}"},
+        json={"dynamicSearchRules": False},
+        timeout=10,
+    )