Skip to content

Commit ce31c76

Browse files
committed
Apply dumps changes
1 parent 6bfee07 commit ce31c76

File tree

3 files changed

+6
-62
lines changed

3 files changed

+6
-62
lines changed

meilisearch/client.py

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -383,29 +383,6 @@ def create_dump(self) -> Dict[str, str]:
383383
"""
384384
return self.http.post(self.config.paths.dumps)
385385

386-
def get_dump_status(self, uid: str) -> Dict[str, str]:
387-
"""Retrieve the status of a Meilisearch dump creation.
388-
389-
Parameters
390-
----------
391-
uid:
392-
UID of the dump.
393-
394-
Returns
395-
-------
396-
Dump status:
397-
Information about the dump status.
398-
https://docs.meilisearch.com/reference/api/dump.html#get-dump-status
399-
400-
Raises
401-
------
402-
MeiliSearchApiError
403-
An error containing details about why Meilisearch can't process your request. Meilisearch error codes are described here: https://docs.meilisearch.com/errors/#meilisearch-errors
404-
"""
405-
return self.http.get(
406-
self.config.paths.dumps + '/' + str(uid) + '/status'
407-
)
408-
409386
def get_tasks(self) -> Dict[str, List[Dict[str, Any]]]:
410387
"""Get all tasks.
411388

tests/client/test_client_dumps.py

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,12 @@
11
# pylint: disable=invalid-name
22

3-
import pytest
4-
from tests import wait_for_dump_creation
5-
from meilisearch.errors import MeiliSearchApiError
6-
73
def test_dump_creation(client, index_with_documents):
84
"""Tests the creation of a Meilisearch dump."""
95
index_with_documents("indexUID-dump-creation")
106
dump = client.create_dump()
11-
assert dump['uid'] is not None
12-
assert dump['status'] == 'in_progress'
13-
wait_for_dump_creation(client, dump['uid'])
14-
15-
def test_dump_status_route(client, index_with_documents):
16-
"""Tests the route for getting a Meilisearch dump status."""
17-
index_with_documents("indexUID-dump-status")
18-
dump = client.create_dump()
19-
assert dump['uid'] is not None
20-
assert dump['status'] == 'in_progress'
21-
dump_status = client.get_dump_status(dump['uid'])
22-
assert dump_status['uid'] is not None
23-
assert dump_status['status'] is not None
24-
wait_for_dump_creation(client, dump['uid'])
25-
26-
def test_dump_status_nonexistent_uid_raises_error(client):
27-
"""Tests the route for getting an inexistent dump status."""
28-
with pytest.raises(MeiliSearchApiError):
29-
client.get_dump_status('uid_not_exists')
7+
assert dump['taskUid'] is not None
8+
assert dump['status'] == 'enqueued'
9+
client.wait_for_task(dump['taskUid'])
10+
dump_status = client.get_task(dump['taskUid'])
11+
assert dump_status['status'] == 'succeeded'
12+
assert dump_status['type'] == 'dumpCreation'

tests/helper.py

Lines changed: 0 additions & 16 deletions
This file was deleted.

0 commit comments

Comments
 (0)