Skip to content

cancel_tasks parameters are inconsistant #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanders41 opened this issue May 18, 2023 · 0 comments · Fixed by #761
Closed

cancel_tasks parameters are inconsistant #760

sanders41 opened this issue May 18, 2023 · 0 comments · Fixed by #761

Comments

@sanders41
Copy link
Collaborator

Description
params in cancel_tasks from Client are required, but in TaskHandler they are optional.

In TaskHandler if params is set to None it defaults to {} meaning the information is sent to the Meilisearch server but it won't do anything. I think either the None params should default to something that makes sense ({"statuses": "enqueued, processing"} maybe?) and the parms in Client should be made options, or params in TaskHandler should also be required.

Expected behavior
Parameters should be consistant.

Current behavior
What happened.

Screenshots or Logs
If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

  • OS: All
  • Meilisearch version: All
  • meilisearch-python version: v0.26.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant