MB-20054: Account for memory alloc/dealloc in unregisterBucket

While unregistering a bucket, any memory allocations/deallocations
made should be accounted to the bucket in question.  Hence no
`onSwitchThread(NULL)` call.

Change-Id: I5c260e3aa7e2c8d1fd4ff0a1ca20f2185a7362a8
Reviewed-on: http://review.couchbase.org/65525
Well-Formed: buildbot <[email protected]>
Tested-by: buildbot <[email protected]>
Reviewed-by: Will Gardner <[email protected]>
Reviewed-by: Jim Walker <[email protected]>

Author: daverigby

src/executorpool.cc

@@ -606,9 +606,10 @@ void ExecutorPool::_unregisterBucket(EventuallyPersistentEngine *engine) {
 }
 
 void ExecutorPool::unregisterBucket(EventuallyPersistentEngine *engine) {
-    EventuallyPersistentEngine *epe = ObjectRegistry::onSwitchThread(NULL, true);
+    // Note: unregistering a bucket is special - any memory allocations /
+    // deallocations made while unregistering *should* be accounted to the
+    // bucket in question - hence no `onSwitchThread(NULL)` call.
     _unregisterBucket(engine);
-    ObjectRegistry::onSwitchThread(epe);
 }
 
 void ExecutorPool::doTaskQStat(EventuallyPersistentEngine *engine,