Merge pull request #45 from messerli-informatik-ag/cleanup

Cleanup

Author: Jan Nils Ferner

.github/workflows/build.yml

@@ -27,4 +27,4 @@ jobs:
     - name: Test that files are importable by MSBuild
       run: ruby ./scripts/test_files_are_importable_by_msbuild.rb
     - name: Show NuGet package content
-      run: unzip -l bin/Release/*.nupkg
+      run: unzip -l nupkg/*.nupkg

.gitignore

@@ -1,3 +1,4 @@
 bin/
 obj/
 /documentation/book/
+/nupkg/

CodeStyle.csproj

@@ -7,6 +7,7 @@
         <PackageId>Messerli.CodeStyle</PackageId>
         <PackageTags>analyzers</PackageTags>
         <PackageLicenseExpression>MIT OR Apache-2.0</PackageLicenseExpression>
+        <PackageOutputPath>nupkg</PackageOutputPath>
         <Copyright>© Messerli Informatik AG. All rights reserved.</Copyright>
         <Description>Various analyzers bundled with opinionated configuration</Description>
         <NoWarn>$(NoWarn);NU5105;NU5104;NU5128</NoWarn>
@@ -25,7 +26,7 @@
         <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.205" PrivateAssets="none" />
     </ItemGroup>
     <ItemGroup>
-        <None Include="build\**\*;buildMultiTargeting\**\*">
+        <None Include="build\**\*">
             <Pack>true</Pack>
             <PackagePath>%(Identity)</PackagePath>
         </None>

build/Default.ruleset

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <RuleSet Name="Default rules for all MesserliOne projects" ToolsVersion="10.0">
-    <Include Path="Disposable\Default.ruleset" Action="Default" />
-    <Include Path="StyleCop\Default.ruleset" Action="Default" />
+    <Include Path="Disposable.ruleset" Action="Default" />
+    <Include Path="StyleCop.ruleset" Action="Default" />
     <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp" RuleNamespace="Microsoft.CodeAnalysis.CSharp">
         <Rule Id="CS1591" Action="None" /> <!-- Missing XML comment for publicly visible type or member 'Type_or_Member' -->
     </Rules>

build/Disposable/Default.ruleset renamed to build/Disposable.ruleset

@@ -3,7 +3,9 @@
     <PropertyGroup>
         <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)Default.ruleset</CodeAnalysisRuleSet>
         <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
+        <GenerateDocumentationFile>true</GenerateDocumentationFile><!-- This is needed so that analyzers can inspect XML comments. Enforced by SA0001. -->
     </PropertyGroup>
-
-    <Import Project="$(MSBuildThisFileDirectory)StyleCop\Default.props" />
+    <ItemGroup>
+        <AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json" Link="stylecop.json" Visible="false" InProject="false" />
+    </ItemGroup>
 </Project>

build/Messerli.CodeStyle.props

@@ -48,6 +48,5 @@ def test_files_are_importable_by_msbuild(directory, files_to_test)
 
     test_files_are_importable_by_msbuild unpacked_directory, [
         'build/Messerli.CodeStyle.props',
-        'buildMultiTargeting/Messerli.CodeStyle.props',
     ]
 end