Address code review feedback: use else-if and clarify variable naming

Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>

Author: Copilot

src/Meziantou.Analyzer.CodeFixers/Rules/UseAttributeIsDefinedFixer.cs

@@ -75,16 +75,16 @@ private static async Task<Document> ReplaceWithAttributeIsDefined(Document docum
                 else
                 {
                     // Check for GetCustomAttributes().Count() comparisons
-                    var countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.LeftOperand, out isLeftSide);
+                    var countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.LeftOperand, out var countIsOnLeft);
                     if (countInvocation is null)
                     {
-                        countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.RightOperand, out isLeftSide);
-                        isLeftSide = !isLeftSide; // If found on right, flip the comparison perspective
+                        countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.RightOperand, out var countIsOnRight);
+                        countIsOnLeft = !countIsOnRight; // If found on right, Count is not on left
                     }
 
                     if (countInvocation is not null)
                     {
-                        var negateCount = ShouldNegateLengthComparison(binaryOperation, isLeftSide);
+                        var negateCount = ShouldNegateLengthComparison(binaryOperation, countIsOnLeft);
                         replacement = CreateAttributeIsDefinedInvocation(generator, semanticModel, countInvocation, negateCount);
                     }
                 }

src/Meziantou.Analyzer/Rules/UseAttributeIsDefinedAnalyzer.cs

@@ -76,11 +76,9 @@ public void AnalyzeBinary(OperationAnalysisContext context)
                 IsGetCustomAttributesLengthComparison(operation, operation.RightOperand, operation.LeftOperand, out _))
             {
                 context.ReportDiagnostic(Rule, operation, "GetCustomAttributes().Length");
-                return;
             }
-
-            if (IsGetCustomAttributesCountComparison(operation, operation.LeftOperand, operation.RightOperand, out _) ||
-                IsGetCustomAttributesCountComparison(operation, operation.RightOperand, operation.LeftOperand, out _))
+            else if (IsGetCustomAttributesCountComparison(operation, operation.LeftOperand, operation.RightOperand, out _) ||
+                     IsGetCustomAttributesCountComparison(operation, operation.RightOperand, operation.LeftOperand, out _))
             {
                 context.ReportDiagnostic(Rule, operation, "GetCustomAttributes().Count()");
             }