Skip to content

Commit 1413c9d

Browse files
meziantouCopilot
andcommitted
Remove unused SupportInternalsVisibleTo flag
Drop the now-unused SupportInternalsVisibleTo state from PolyfillData and compute the type-polyfill condition directly from XmlDocumentationId in Program.cs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent db18fc8 commit 1413c9d

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

Meziantou.Polyfill.Generator/PolyfillData.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ internal sealed partial class PolyfillData
4242

4343
public bool UseUnsafe { get; private set; }
4444
public bool UseExtensions { get; private set; }
45-
public bool SupportInternalsVisibleTo { get; private set; }
4645

4746
public override string ToString()
4847
{
@@ -140,7 +139,6 @@ static bool IsExposed(ISymbol symbol)
140139
var useExtensions = root.DescendantNodes().OfType<ExtensionBlockDeclarationSyntax>().Any();
141140
var useUnsafe = root.DescendantNodes().OfType<UnsafeStatementSyntax>().Any() || root.DescendantNodes().OfType<MethodDeclarationSyntax>().Any(m => m.Modifiers.Any(m => m.IsKind(SyntaxKind.UnsafeKeyword)));
142141

143-
var supportInternalsVisibleTo = documentationDeclarationId.StartsWith("T:", StringComparison.Ordinal);
144142
var finalContent = new AddEmbeddedAttributeRewriter().Visit(root) ?? root;
145143

146144
var data = new PolyfillData(finalContent.ToFullString());
@@ -150,7 +148,6 @@ static bool IsExposed(ISymbol symbol)
150148
data.PolyfillExtensionsClassNames = [.. polyfillExtensionsClassNames.OrderBy(x => x, StringComparer.Ordinal)];
151149
data.UseExtensions = useExtensions;
152150
data.UseUnsafe = useUnsafe;
153-
data.SupportInternalsVisibleTo = supportInternalsVisibleTo;
154151

155152
foreach (var requiredType in requiredTypes)
156153
{

Meziantou.Polyfill.Generator/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ string GenerateIncludePreCondition(PolyfillData data)
241241
string GenerateIncludePostCondition(PolyfillData data)
242242
{
243243
var result = "";
244-
if (data.SupportInternalsVisibleTo && data.DeclaredMemberDocumentationIds.Length > 0)
244+
if (data.XmlDocumentationId?.StartsWith("T:", StringComparison.Ordinal) == true && data.DeclaredMemberDocumentationIds.Length > 0)
245245
{
246246
result += " && (";
247247
result += string.Join(" && ", data.DeclaredMemberDocumentationIds.Select(member =>

0 commit comments

Comments
 (0)