Skip to content

Commit 1066f50

Browse files
committed
mgr/volumes: place getters and setters next to each other
workaround for mypy issue: python/mypy#1465 fixes mypy errors: volumes/fs/operations/group.py: note: In class "Group": volumes/fs/operations/group.py:44: error: Name 'uid' already defined on line 36 volumes/fs/operations/group.py:44: error: "Callable[[Group], Any]" has no attribute "setter" volumes/fs/operations/group.py:48: error: Name 'gid' already defined on line 40 volumes/fs/operations/group.py:48: error: "Callable[[Group], Any]" has no attribute "setter" volumes/fs/operations/group.py: note: In function "open_group": volumes/fs/operations/group.py:170: error: Property "uid" defined in "Group" is read-only volumes/fs/operations/group.py:171: error: Property "gid" defined in "Group" is read-only volumes/fs/operations/versions/subvolume_base.py: note: In class "SubvolumeBase": volumes/fs/operations/versions/subvolume_base.py:45: error: Name 'uid' already defined on line 33 volumes/fs/operations/versions/subvolume_base.py:45: error: "Callable[[SubvolumeBase], Any]" has no attribute "setter" volumes/fs/operations/versions/subvolume_base.py:49: error: Name 'gid' already defined on line 37 volumes/fs/operations/versions/subvolume_base.py:49: error: "Callable[[SubvolumeBase], Any]" has no attribute "setter" volumes/fs/operations/versions/subvolume_base.py:53: error: Name 'mode' already defined on line 41 volumes/fs/operations/versions/subvolume_base.py:53: error: "Callable[[SubvolumeBase], Any]" has no attribute "setter" Signed-off-by: Michael Fritch <[email protected]>
1 parent eacc080 commit 1066f50

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/pybind/mgr/volumes/fs/operations/group.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@ def group_name(self):
3737
def uid(self):
3838
return self.user_id
3939

40-
@property
41-
def gid(self):
42-
return self.group_id
43-
4440
@uid.setter
4541
def uid(self, val):
4642
self.user_id = val
4743

44+
@property
45+
def gid(self):
46+
return self.group_id
47+
4848
@gid.setter
4949
def gid(self, val):
5050
self.group_id = val

src/pybind/mgr/volumes/fs/operations/versions/subvolume_base.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,22 +34,22 @@ def __init__(self, fs, vol_spec, group, subvolname, legacy=False):
3434
def uid(self):
3535
return self.user_id
3636

37-
@property
38-
def gid(self):
39-
return self.group_id
40-
41-
@property
42-
def mode(self):
43-
return self.cmode
44-
4537
@uid.setter
4638
def uid(self, val):
4739
self.user_id = val
4840

41+
@property
42+
def gid(self):
43+
return self.group_id
44+
4945
@gid.setter
5046
def gid(self, val):
5147
self.group_id = val
5248

49+
@property
50+
def mode(self):
51+
return self.cmode
52+
5353
@mode.setter
5454
def mode(self, val):
5555
self.cmode = val

0 commit comments

Comments
 (0)