Skip to content

Git Graph stays empty with remote development in container since VS-Code v1.57.1 (regression) #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oschulz opened this issue Jul 1, 2021 · 20 comments
Assignees
Labels
vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions.

Comments

@oschulz
Copy link

oschulz commented Jul 1, 2021

Bug Description

Since VS-Code v1.57.1, Git Graph doesn't seem to work in remote-development mode (tested with remote-SSH) any longer. This used to work fine until VS-Code v1.56.2. On v1.57.1, the Git Graph window just stays empty.

Git Graph may IMHO be the best Git GUI tool for remote systems, currently, it would be awesome to get that functionality back.

Steps to Reproduce

  • Install the official "Remote - SSH (ms-vscode-remote.remote-ssh)" extension and the Git Graph extension.
  • Use Remote-SSH to connect to a system (may just be "localhost") and open a folder with a Git repository
  • Open Git Graph (opens, but will be empty on VS-Code v1.57.1).

Expected Behaviour

Git Graph should show the usual nice version tree. :-)

Environment

  • Git Graph Extension Version: 1.30.0
  • Visual Studio Code Version: 1.57.1
  • Operating System: Ubuntu Linux 20.04
@oschulz oschulz added the bug Something isn't working label Jul 1, 2021
@mhutchie
Copy link
Owner

mhutchie commented Jul 1, 2021

Hi @oschulz,

Can you please provide a screenshot to demonstrate what you're experiencing?

Do you get any error messages, or are there any error logs in the console when you do the following steps? If so, please provide them.

  1. Open the Visual Studio Code Command Palette
  2. Run "Developer: Open Webview Developer Tools"
  3. Navigate to the "Console" tab

@oschulz
Copy link
Author

oschulz commented Jul 1, 2021

Hi @mhutchie ,

thanks, here are the screenshots:

VS-Code v1.56.2:

git-graph-working

VS-Code v1.57.1:

git-graph-not-working

@oschulz
Copy link
Author

oschulz commented Jul 1, 2021

Are the "Webview Developer Tools" supposed to work in remote-SSH mode? I can only get them to open in VS-Code windows that don't use remote-SSH.

@oschulz oschulz changed the title Git Graph stays empty in remote development mode since VS-Code v1.57.1 (regression) Git Graph stays empty with remote development in container since VS-Code v1.57.1 (regression) Jul 1, 2021
@oschulz
Copy link
Author

oschulz commented Jul 1, 2021

Another thing I just noticed: I typically run the remote vscode-server session in a Singularity container that contains my software stack and does some bind mounts. When I don't use the container, then Git Graph does work in remote mode on v1.57.1. However, I've been running this vscode-server in container setup for a long time and many VS-Code versions now, and there were never any problems with Git Graph. I wonder if something has changed in Code with the new security improvements and so on?

@oschulz
Copy link
Author

oschulz commented Jul 1, 2021

Are the "Webview Developer Tools" supposed to work in remote-SSH mode? I can only get them to open in VS-Code windows that don't use remote-SSH.

I can use "Developer: Toggle Developer Tools" though, and see the console there. Is that sufficient?

@mhutchie
Copy link
Owner

mhutchie commented Jul 1, 2021

What you've shown in your screenshot is enough. The behaviour you've observed is a Visual Studio Code Webview bug that was introduced in Visual Studio Code 1.57.x. It prevents the extension's CSS & JS resources from being accessible in the Webview. It affects all extensions that use a Webview, not just Git Graph (the Git Graph View uses a Webview to render).

In Visual Studio Code 1.57.x, Microsoft made some fairly significant changes to their underlying Webview implementation, that has caused numerous bugs that affect all extensions using Webviews. This is the fourth I'm aware of - see the other issues tagged as "vscode-bug" on https://github.com/mhutchie/vscode-git-graph/issues.

Please raise this as a bug in https://github.com/microsoft/vscode, so Microsoft can fix. Make sure to call your issue something general (e.g. "Extension Webview resource error with Remote SSH"), so it is prioritised accurately as it's an issue affecting all extensions (not just one). Refer to Git Graph as an example of an affected extension in the bug you raise.

@mhutchie mhutchie added vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions. and removed bug Something isn't working labels Jul 1, 2021
@oschulz
Copy link
Author

oschulz commented Jul 1, 2021

Thanks!

@oschulz
Copy link
Author

oschulz commented Jul 1, 2021

Should I close this here, then?

@mhutchie
Copy link
Owner

mhutchie commented Jul 1, 2021

@oschulz I'll leave this open until Visual Studio Code fixes it, so other affected users can read it (and not raise further Git Graph bugs for it).

@pomack
Copy link

pomack commented Aug 2, 2021

FYI the bug report is here: microsoft/vscode#127770

@KaeLL
Copy link

KaeLL commented Aug 6, 2021

Came here looking for this issue. Thing is, it was working fine up until yesterday's 1.59.0, unlike OP.

@pomack
Copy link

pomack commented Aug 12, 2021

FYI, this may have been fixed in microsoft/vscode#123494 if anyone is using the vscode insiders build to test. Otherwise will need to wait till 1.60 is released.

@oschulz
Copy link
Author

oschulz commented Aug 13, 2021

@pomack: this may have been fixed in microsoft/vscode#123494

Thanks - just tested with code-insider-x64-1628833345, the Git graph is back! :-)

@KaeLL
Copy link

KaeLL commented Aug 13, 2021

Otherwise will need to wait till 1.60 is released.

Fucking hell. Well, insiders it it, then.

@mhutchie
Copy link
Owner

This Visual Studio Code bug has been fixed by Microsoft in Visual Studio Code 1.60. If you continue to face this issue, please raise it again with Microsoft.

@oschulz
Copy link
Author

oschulz commented Sep 19, 2021

Thanks again, @mhutchie !

@bjoham
Copy link

bjoham commented Jun 18, 2024

Again broken. :-(

It was working in 1.87, but has been broken in 1.88 - 1.90

Extension Webview resource error in Ubuntu #216513

@oschulz
Copy link
Author

oschulz commented Jun 18, 2024

GitGraph is working for me on Ubuntu v22.04 with Remote-SSH to Ubuntu v22.04 using VSCode v1.90.1 .

@bjoham
Copy link

bjoham commented Aug 6, 2024

With 22.04 it is working.
Thanks!

@MichaelLiss
Copy link

MichaelLiss commented Sep 12, 2024

In version 1.93.0 git graph works (on a mac, Sonoma 14.6.1) in a normal file view:
image

image

However, when I load my docker devcontainer: it's greyed out and will not load
image

Here is my devcontainer contents:

{
  "name": "React Dev Container",
  "dockerFile": "Dockerfile",
  "context": "..",
  "appPort": 3000,
  "customizations": {
    "vscode": {
      "extensions": [
        "ms-python.python",
        "esbenp.prettier-vscode",
        "dbaeumer.vscode-eslint",
        "mhutchie.git-graph"
      ]
    }
  },
  "postCreateCommand": "npm install",
  "remoteUser": "node"
}

tried adding "ms-vscode-remote.remote-ssh" - still does not load

{
  "name": "React Dev Container",
  "dockerFile": "Dockerfile",
  "context": "..",
  "appPort": 3000,
  "customizations": {
    "vscode": {
      "extensions": [
        "ms-python.python",
        "esbenp.prettier-vscode",
        "dbaeumer.vscode-eslint",
        "mhutchie.git-graph",
        "ms-vscode-remote.remote-ssh"
      ]
    }
  },
  "postCreateCommand": "npm install",
  "remoteUser": "node"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions.
Projects
None yet
Development

No branches or pull requests

6 participants