-
Notifications
You must be signed in to change notification settings - Fork 296
Git Graph stays empty with remote development in container since VS-Code v1.57.1 (regression) #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @oschulz, Can you please provide a screenshot to demonstrate what you're experiencing? Do you get any error messages, or are there any error logs in the console when you do the following steps? If so, please provide them.
|
Hi @mhutchie , thanks, here are the screenshots: VS-Code v1.56.2: VS-Code v1.57.1: |
Are the "Webview Developer Tools" supposed to work in remote-SSH mode? I can only get them to open in VS-Code windows that don't use remote-SSH. |
Another thing I just noticed: I typically run the remote vscode-server session in a Singularity container that contains my software stack and does some bind mounts. When I don't use the container, then Git Graph does work in remote mode on v1.57.1. However, I've been running this vscode-server in container setup for a long time and many VS-Code versions now, and there were never any problems with Git Graph. I wonder if something has changed in Code with the new security improvements and so on? |
I can use "Developer: Toggle Developer Tools" though, and see the console there. Is that sufficient? |
What you've shown in your screenshot is enough. The behaviour you've observed is a Visual Studio Code Webview bug that was introduced in Visual Studio Code 1.57.x. It prevents the extension's CSS & JS resources from being accessible in the Webview. It affects all extensions that use a Webview, not just Git Graph (the Git Graph View uses a Webview to render). In Visual Studio Code 1.57.x, Microsoft made some fairly significant changes to their underlying Webview implementation, that has caused numerous bugs that affect all extensions using Webviews. This is the fourth I'm aware of - see the other issues tagged as "vscode-bug" on https://github.com/mhutchie/vscode-git-graph/issues. Please raise this as a bug in https://github.com/microsoft/vscode, so Microsoft can fix. Make sure to call your issue something general (e.g. "Extension Webview resource error with Remote SSH"), so it is prioritised accurately as it's an issue affecting all extensions (not just one). Refer to Git Graph as an example of an affected extension in the bug you raise. |
Thanks! |
Should I close this here, then? |
@oschulz I'll leave this open until Visual Studio Code fixes it, so other affected users can read it (and not raise further Git Graph bugs for it). |
FYI the bug report is here: microsoft/vscode#127770 |
Came here looking for this issue. Thing is, it was working fine up until yesterday's 1.59.0, unlike OP. |
FYI, this may have been fixed in microsoft/vscode#123494 if anyone is using the vscode insiders build to test. Otherwise will need to wait till 1.60 is released. |
Thanks - just tested with code-insider-x64-1628833345, the Git graph is back! :-) |
Fucking hell. Well, insiders it it, then. |
This Visual Studio Code bug has been fixed by Microsoft in Visual Studio Code 1.60. If you continue to face this issue, please raise it again with Microsoft. |
Thanks again, @mhutchie ! |
Again broken. :-( It was working in 1.87, but has been broken in 1.88 - 1.90 |
GitGraph is working for me on Ubuntu v22.04 with Remote-SSH to Ubuntu v22.04 using VSCode v1.90.1 . |
With 22.04 it is working. |
Uh oh!
There was an error while loading. Please reload this page.
Bug Description
Since VS-Code v1.57.1, Git Graph doesn't seem to work in remote-development mode (tested with remote-SSH) any longer. This used to work fine until VS-Code v1.56.2. On v1.57.1, the Git Graph window just stays empty.
Git Graph may IMHO be the best Git GUI tool for remote systems, currently, it would be awesome to get that functionality back.
Steps to Reproduce
Expected Behaviour
Git Graph should show the usual nice version tree. :-)
Environment
The text was updated successfully, but these errors were encountered: