stop considering log entries with LogLevel.None (#2667)

Author: vmcbaptista

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## VNext
 - Update endpoint redirect header name for QuickPulse module to v2
 - AzureSdkDiagnosticListener modified to use sdkversion prefix "rdddsaz" instead of "dotnet".
+- [ILogger logs with LogLevel.None severity are now ignored by ApplicationInsightsLogger](https://github.com/microsoft/ApplicationInsights-dotnet/pull/2667). Fixes ([#2666](https://github.com/microsoft/ApplicationInsights-dotnet/issues/2666))
 
 ## Version 2.21.0
 - no changes since beta.

LOGGING/src/ILogger/ApplicationInsightsLogger.cs

@@ -65,7 +65,7 @@ public IDisposable BeginScope<TState>(TState state)
         /// </returns>
         public bool IsEnabled(LogLevel logLevel)
         {
-            return this.telemetryClient.IsEnabled();
+            return logLevel != LogLevel.None && this.telemetryClient.IsEnabled();
         }
 
         /// <summary>

LOGGING/test/ILogger.Tests/ILoggerIntegrationTests.cs

@@ -96,6 +96,7 @@ public void ApplicationInsightsLoggerIsInvokedWhenUsingILogger()
             testLogger.LogTrace("Trace");
             testLogger.LogWarning("Warning");
             testLogger.LogDebug("Debug");
+            testLogger.Log(LogLevel.None, "None");
 
             Assert.AreEqual(7, itemsReceived.Count);
 
@@ -125,6 +126,37 @@ public void ApplicationInsightsLoggerIsInvokedWhenUsingILogger()
             Assert.AreEqual("Debug", (itemsReceived[6] as TraceTelemetry).Message);
         }
 
+        /// <summary>
+        /// Ensures that <see cref="ApplicationInsightsLogger"/> is invoked when user logs using <see cref="ILogger"/>.
+        /// </summary>
+        [TestMethod]
+        [TestCategory("ILogger")]
+        public void ApplicationInsightsLoggerIsNotInvokedWhenUsingILoggerAndTelemetryIsDisabled()
+        {
+            List<ITelemetry> itemsReceived = new List<ITelemetry>();
+
+            IServiceProvider serviceProvider = ILoggerIntegrationTests.SetupApplicationInsightsLoggerIntegration((telemetryItem, telemetryProcessor) =>
+            {
+                itemsReceived.Add(telemetryItem);
+            }, configuration =>
+            {
+                configuration.DisableTelemetry = true;
+            });
+
+            ILogger<ILoggerIntegrationTests> testLogger = serviceProvider.GetRequiredService<ILogger<ILoggerIntegrationTests>>();
+
+            testLogger.LogInformation("Testing");
+            testLogger.LogError(new Exception("ExceptionMessage"), "LoggerMessage");
+            testLogger.LogInformation(new EventId(100, "TestEvent"), "TestingEvent");
+            testLogger.LogCritical("Critical");
+            testLogger.LogTrace("Trace");
+            testLogger.LogWarning("Warning");
+            testLogger.LogDebug("Debug");
+            testLogger.Log(LogLevel.None, "None");
+
+            Assert.AreEqual(0, itemsReceived.Count);
+        }
+
         /// <summary>
         /// Ensures that the <see cref="ApplicationInsightsLoggerOptions.TrackExceptionsAsExceptionTelemetry"/> switch is honored
         /// and exceptions are logged as trace messages when value is true.