auto: collect candidates from microsoft/BCApps

Author: github-actions[bot]

dataset/bcbench.jsonl

@@ -0,0 +1,66 @@
+# [E-Document] Data Exchange v2 import handler (bridge pattern)
+
+## Summary
+- Add `IStructuredFormatReader` implementation for Data Exchange format (codeunit 6407)
+- Bridge existing Data Exchange Definition infrastructure to v2 import pipeline staging tables
+- Register as enum value 5 "Data Exchange" on `E-Doc. Read into Draft`
+- Namespace-based definition matching (replaces v1 trial-and-error auto-detection)
+- Run Data Handling Codeunit only (skip Pre-Mapping codeunit 6156 — vendor/GL resolution deferred to Prepare Draft)
+- Map Intermediate Data Import records to `E-Document Purchase Header` / `E-Document Purchase Line` via field-ID bridge
+- Process base64 attachments from Document Attachment intermediate records
+- XPath supplement for Company Information fields not in intermediate data
+- Integration events for partner extensibility
+
+### New codeunit
+| ID | Name | Purpose |
+|----|------|---------|
+| 6407 | E-Document Data Exch. Handler | IStructuredFormatReader for Data Exchange format |
+
+### Key design decisions
+- **No Commit()** — ReadIntoDraft runs inside pipeline try-function context
+- **No EDocument.Modify()** — record passed by value; local variables used
+- **Namespace matching** — matches XML root namespace against DataExchLineDef.Namespace instead of v1's trial-and-error (which requires Commit())
+- **Data Handling only** — runs codeunit 1214 to populate Intermediate Data Import, skips Pre-Mapping (6156) since v2 Prepare Draft handles vendor/item resolution
+
+## Test plan
+- [x] Invoice ReadIntoDraft: header fields mapped (vendor name, invoice no, dates, amounts)
+- [x] Invoice ReadIntoDraft: line fields mapped (description, quantity, unit price, line numbers)
+- [x] Invoice returns "Purchase Invoice" process draft type
+- [x] CreditNote returns "Purchase Credit Memo" process draft type
+- [x] Total VAT computed correctly
+- [x] Attachments decoded from base64 and stored
+- [x] Currency code blank when matching LCY
+
+[AB#630822](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/630822)
+[AB#599123](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599123)
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

dataset/problemstatement/microsoft__BCApps-7565/README.md

@@ -0,0 +1,35 @@
+# [Shopify] Refresh cached plan before order sync
+
+## Summary
+
+Bug 635878: When a merchant downgrades their Shopify plan from Plus / Advanced to a standard plan, the connector keeps requesting the `staffMember { id }` field in the order GraphQL query. The lower plan does not grant `read_users` scope, so Shopify returns `ACCESS_DENIED` and order sync is fully broken until the user manually toggles the **Enabled** field off and on again on the Shop Card.
+
+`Shop."Advanced Shopify Plan"` (field 207) is the cached flag that gates the staff member field. It was only refreshed when the user toggled Enabled or when a scope change was detected on Shop Card open — never before an order sync.
+
+## Fix
+
+Auto-refresh the cached plan via the existing `Shop.GetShopSettings()` helper (one cheap GraphQL query for `shop { plan { ... } weightUnit }`) before both order-import entry points:
+
+1. **Bulk sync** — Report `30104 Shpfy Sync Orders from Shopify` (also the scheduled auto-sync path). One refresh call per shop per batch run.
+2. **Single-order reimport** — `ShpfyImportOrder.ReimportExistingOrderConfirmIfConflicting` (manual reimport action on the Order Header page).
+
+The refresh is deliberately not placed in `ShpfyImportOrder.SetShop()` because that runs per order; for a 100-order batch it would mean 100 extra GraphQL round-trips.
+
+## Tests
+
+Two regression tests added to the existing `ShpfyOrdersAPITest.Codeunit.al` (139608):
+
+- `TestGetShopSettingsClearsStaleAdvancedShopifyPlanFlag` — sets stale `"Advanced Shopify Plan" = true`, calls `GetShopSettings`, asserts the flag becomes `false`.
+- `TestSyncOrdersFromShopifyReportRefreshesAdvancedShopifyPlanFlag` — sets stale flag, runs Report 30104, asserts the persisted Shop record has the flag refreshed to `false`.
+
+Existing `OrdersAPIHttpHandler` extended with a one-shot `PlanRefreshExpected` flag returning a downgraded-plan JSON for the first request, then falling through to the prior empty-data behavior.
+
+Both tests verified locally.
+
+Fixes [AB#635878](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/635878)
+
+
+
+
+
+

dataset/problemstatement/microsoft__BCApps-8212/README.md

@@ -0,0 +1,34 @@
+# [Shopify] Auto Create Catalog: always visible, validate plan on enable
+
+## Summary
+
+Re-fix for **bug 630316** after PM verification of [PR #7605](https://github.com/microsoft/BCApps/pull/7605).
+
+PR #7605 made B2B features unconditional on all Shopify plans, but the `Auto Create Catalog` toggle on the **Customers and Companies** group of the Shop Card stayed hidden for non-Advanced shops because its `Visible = Rec."Advanced Shopify Plan"` binding is not re-evaluated after `GetShopSettings()` flips the flag at runtime.
+
+Per PM Andrei Pankos guidance:
+- Drop the dynamic visibility on the `Auto Create Catalog` field so its always visible in the Companies group.
+- Gate the field at the table layer instead: an `OnValidate` trigger raises a field error if the user tries to enable `Auto Create Catalog` on a shop whose plan does not support B2B catalogs (Plus, Plus Trial, Development, or Advanced).
+
+The error uses the existing `ErrorInfo` / `FieldNo` pattern already used elsewhere in `ShpfyShop.Table.al` (e.g. field 21 `Auto Create Orders`).
+
+## What is NOT changed
+
+- `action(Catalogs)` (B2B Catalogs action) and `action(StaffMembers)` visibility on the Shop Card  PM only flagged the field control.
+- The runtime `Shop."Auto Create Catalog"` checks in `ShpfyCompanyAPI.Codeunit.al` / `ShpfyCompanyExport.Codeunit.al`  the table guard prevents the boolean from being set to `true` on an unsupported plan, so no runtime check is needed.
+- The `B2B Enabled` obsoletion and upgrade code from PR #7605  already accepted by PM.
+- `app.json` versions  intentionally untouched.
+
+## Test
+
+Adds `TestAutoCreateCatalogRequiresAdvancedPlan` to `ShpfyStaffTest` (codeunit 139551, which is already the home for `Advanced Shopify Plan`-gated tests). Verified both passes locally:
+
+```
+PASS TestStaffMembersActionVisibleOnlyForSupportedPlans (513ms)
+PASS TestAutoCreateCatalogRequiresAdvancedPlan (23ms)
+```
+
+Fixes [AB#630316](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/630316)
+
+
+

dataset/problemstatement/microsoft__BCApps-8213/README.md

@@ -0,0 +1,23 @@
+# Add VAT rate resolution and VAT amount difference for E-Document purchases
+
+## Why
+
+When importing e-documents for purchase processing, the system did not automatically resolve VAT Product Posting Groups from extracted VAT rates. Users had to manually identify and assign the correct VAT posting group for each line, which was error-prone and time-consuming. Additionally, rounding differences between the document's total VAT and the computed line-level VAT amounts were not reconciled, leading to posting discrepancies.
+
+## Summary
+
+- **Added** VAT Product Posting Group resolution during Prepare Draft — matches the extracted VAT rate against VAT Posting Setup entries (Normal VAT and Reverse Charge VAT only) for the vendor's VAT Bus. Posting Group
+- **Added** `[BC] VAT Prod. Posting Group` and `[BC] VAT Rate Mismatch` fields on E-Document Purchase Line with OnValidate/OnLookup support
+- **Added** VAT amount difference computation and application to purchase lines when finalizing drafts, respecting Allow VAT Difference and Max. VAT Difference Allowed settings
+- **Added** "Resolve VAT Group Purch EDoc" and "Apply VAT Diff. For Purch EDoc" toggles on Purchases & Payables Setup
+- **Improved** ADI handler to prefer the unambiguous `taxRate` field and properly disambiguate the `tax` field between percentage and monetary values
+- **Added** comprehensive test codeunit `E-Doc Purch. VAT Tests` covering resolution, mismatch detection, OnValidate behavior, and VAT calculation type filtering
+- **Updated** existing structured validation tests to reflect corrected VAT rate expectations
+
+Fixes [AB#619564](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/619564)
+
+
+
+
+
+

dataset/problemstatement/microsoft__BCApps-8251/README.md

@@ -0,0 +1,25 @@
+# (Bug 633226): [Subcontracting] Standard Task not propagated from Routing to Prod. Order Routing or Subcontracting Worksheet; prices not picked up
+
+## Summary
+
+The Subcontracting Worksheet flow was dropping `Standard Task Code` between the Prod. Order Routing Line and the Requisition Line, the field on the worksheet was read-only, and Subcontractor Prices keyed on a Standard Task were therefore never applied. This change:
+
+- Propagates `Standard Task Code` from `Prod. Order Routing Line` to `Requisition Line` in both worksheet-population paths (Calculate Subcontracts… on the worksheet, and direct PO creation from a Prod. Order Routing line).
+- Makes the `Standard Task Code` field editable on the Subcontracting Worksheet so users can override it.
+- Causes the standard-task-bound subcontractor price to flow through to the Subcontracting Purchase Order's `Direct Unit Cost`.
+
+The bug enumerated four symptoms (Routing → Prod. Order Routing, Prod. Order Routing → Worksheet, field not editable, prices not picked up). Routing → Prod. Order Routing was already handled by `Prod. Order Routing Line.CopyFromRoutingLine`; no change there. The remaining three are addressed below.
+
+## Changes
+
+### `SubcCalcSubcontractsExt.Codeunit.al`
+Extended the existing `OnAfterTransferProdOrderRoutingLine` subscriber on report `Subc. Calculate Subcontracts` to also `Validate("Standard Task Code", ProdOrderRoutingLine."Standard Task Code")` on the new requisition line. Using `Validate` (not direct assignment) fires the field's OnValidate trigger in `Subc. RequisitionLine`, which calls `UpdateSubcontractorPrice` → `Subc. Price Management.GetSubcPriceForReqLine`. The price lookup already filters `Subcontractor Price` by `RequisitionLine."Standard Task Code"` exactly, so the standard-task-bound price is applied immediately.
+
+### `SubcPurchaseOrderCreator.Codeunit.al`
+Same fix in `InsertReqWkshLine`, which is the alternate worksheet-line builder used when a Subcontracting PO is created directly from a Prod. Order Routing Line (bypassing the worksheet UI).
+
+### `SubcSubcontractingWorksheet.Page.al`
+Removed `Editable = false` from the `Standard Task Code` field and added a tooltip clarifying that editing the value re-applies the matching subcontractor price. The field's OnValidate already triggers price re-lookup, so manual edits/clears on the worksheet immediately update `Direct Unit Cost`.
+
+Fixes [AB#633226](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/633226)
+