Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

after upgrading git for windows today, amazon logon resulted in "NullReference" exception #774

Closed
nilnul opened this issue Oct 6, 2018 · 28 comments
Milestone

Comments

@nilnul
Copy link

nilnul commented Oct 6, 2018

It used to work fine as of today, when I clicked the popped out "would you like to upgrade now" button of the git for windows upgrading reminder. (I regret that I just clicked too quick).

Now I face the console window with a "NullReferenceException"; and it prompts me to key in username and password; after I key in the username and password, another NullReferenceException is shown. But astonishingly, git begins enumerating objects and looks normal (with the two exceptions in the heading; see the screenshot below).

I'll try to locate the issue and report any further details.

@nilnul
Copy link
Author

nilnul commented Oct 6, 2018

46574953-be740f80-c9de-11e8-8882-74aea962db57

@nilnul
Copy link
Author

nilnul commented Oct 6, 2018

Shall I try to downgrade?

@nilnul
Copy link
Author

nilnul commented Oct 6, 2018

the credential in the Credential Vault of Windows of mine should be correct.

@masterged
Copy link

Same issue. Helps only downgrade to version 1.16.3

@nilnul
Copy link
Author

nilnul commented Oct 7, 2018

Same issue. Helps only downgrade to version 1.16.3

How to downgrade? Shall I just install v1.16.3 or shall I uninstall the newer version first before installing v1.16.3 ?

@nilnul
Copy link
Author

nilnul commented Oct 7, 2018

The upgrading bringing about this problem is the upgrading of GitForWindows, not the upgrading of GitCredentialManager itself. I don't know whether the upgrading of GitForWin includes the upgrading of GCM.

@masterged
Copy link

Same issue. Helps only downgrade to version 1.16.3

How to downgrade? Shall I just install v1.16.3 or shall I uninstall the newer version first before installing v1.16.3 ?

I uninstall GCM, and install old. GitForWindows is last version.

@nilnul
Copy link
Author

nilnul commented Oct 8, 2018

I uninstalled the upgraded GitForWindows(not GCM); I don't know whether the uninstalling of GitForWindows would also uninstall GCM. And then I reinstalled the old version of GitForWindows (I don't know whether the reinstalling would also reinstall GCM).

Now every thing works fine. (The NullReferenceException when logging onto amazon now doesn't pop up anymore).

So I guess the problems are borne due to the Oct.6th upgrading of GitForWindows.

@PhilipOakley
Copy link

the new release Comes with Git Credential Manager v1.18.0. (ignore the first 'comes with'..)

@viceice
Copy link

viceice commented Oct 9, 2018

Same here v1.17.2:

$ git fetch
11:34:44.624602 ...\Common.cs:677       trace: [Main] git-credential-manager (v1.17.2) 'get'
11:34:44.968317 ...\Git\Where.cs:361    trace: [FindGitInstallations] found 1 Git installation(s).
11:34:44.983954 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 38 entries.
11:34:45.267489 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://git.visualon.de/'.
11:34:45.658082 ...\Common.cs:196       trace: [CreateAuthentication] authority for 'https://git.visualon.de/' is basic with NTLM=Auto.
11:34:45.689342 ...seSecureStore.cs:195 trace: [ReadCredentials] credentials for 'git:https://git.visualon.de' read from store.
11:34:45.689342 ...\Common.cs:711       trace: [QueryCredentials] credentials found.
11:34:46.360979 ...\Common.cs:677       trace: [Main] git-credential-manager (v1.17.2) 'store'
11:34:46.676111 ...\Git\Where.cs:361    trace: [FindGitInstallations] found 1 Git installation(s).
11:34:46.691733 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 38 entries.
11:34:46.879391 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://[email protected]/'.
11:34:47.452635 ...\Common.cs:196       trace: [CreateAuthentication] authority for 'https://[email protected]/' is basic with NTLM=Auto.
11:34:47.452635 ...\Program.cs:514      trace: [Store] storing basic credentials for 'https://[email protected]/'.
11:34:47.483880 ...seSecureStore.cs:286 trace: [WriteCredential] credentials for 'git:https://[email protected]' written to store.

and v1.18.0

$ git fetch
11:35:13.318414 ...\Common.cs:744       trace: [Main] git-credential-manager (v1.18.0) 'get'
11:35:13.662148 ...\Git\Where.cs:348    trace: [FindGitInstallations] found 1 Git installation(s).
11:35:13.693391 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 39 entries.
11:35:13.865273 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://git.visualon.de/'.
11:35:14.281334 ...\Program.cs:601      trace: [Run] ! error: 'Object reference not set to an instance of an object.'.
11:35:14.296952 ...\Common.cs:709       trace: [LogEvent] System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.Alm.Authentication.NetworkResponseContent.<SetContent>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Authentication.NetworkResponseMessage.<SetContent>d__19.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Authentication.Network.<>c__DisplayClass6_0.<<HttpHeadAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<DetectAuthority>d__34.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<GetAuthentication>d__35.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.CommonFunctions.<CreateAuthentication>d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.CommonFunctions.<QueryCredentials>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.Program.<<Get>b__24_0>d.MoveNext()
11:35:14.312570 ...\Program.cs:601      trace: [Run] fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
11:35:14.957300 ...\Common.cs:744       trace: [Main] git-credential-manager (v1.18.0) 'get'
11:35:15.284414 ...\Git\Where.cs:348    trace: [FindGitInstallations] found 1 Git installation(s).
11:35:15.300040 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 39 entries.
11:35:15.581272 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://git.visualon.de/'.
11:35:16.034359 ...\Program.cs:601      trace: [Run] ! error: 'Object reference not set to an instance of an object.'.
11:35:16.049997 ...\Common.cs:709       trace: [LogEvent] System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.Alm.Authentication.NetworkResponseContent.<SetContent>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Authentication.NetworkResponseMessage.<SetContent>d__19.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Authentication.Network.<>c__DisplayClass6_0.<<HttpHeadAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<DetectAuthority>d__34.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<GetAuthentication>d__35.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.CommonFunctions.<CreateAuthentication>d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.CommonFunctions.<QueryCredentials>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.Program.<<Get>b__24_0>d.MoveNext()
11:35:16.049997 ...\Program.cs:601      trace: [Run] fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
Username for 'https://git.visualon.de': kriese
11:35:29.857446 ...\Common.cs:744       trace: [Main] git-credential-manager (v1.18.0) 'store'
11:35:30.231206 ...\Git\Where.cs:348    trace: [FindGitInstallations] found 1 Git installation(s).
11:35:30.262571 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 39 entries.
11:35:30.449962 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://[email protected]/'.
11:35:30.934328 ...\Program.cs:601      trace: [Run] ! error: 'Object reference not set to an instance of an object.'.
11:35:30.949942 ...\Common.cs:709       trace: [LogEvent] System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.Alm.Authentication.NetworkResponseContent.<SetContent>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Authentication.NetworkResponseMessage.<SetContent>d__19.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Authentication.Network.<>c__DisplayClass6_0.<<HttpHeadAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<DetectAuthority>d__34.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<GetAuthentication>d__35.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.CommonFunctions.<CreateAuthentication>d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.Program.<<Store>b__27_0>d.MoveNext()
11:35:30.949942 ...\Program.cs:601      trace: [Run] fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
11:35:31.430927 ...\Common.cs:744       trace: [Main] git-credential-manager (v1.18.0) 'store'
11:35:31.790307 ...\Git\Where.cs:348    trace: [FindGitInstallations] found 1 Git installation(s).
11:35:31.821558 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 39 entries.
11:35:32.009057 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://[email protected]/'.
11:35:32.509804 ...\Program.cs:601      trace: [Run] ! error: 'Object reference not set to an instance of an object.'.
11:35:32.525441 ...\Common.cs:709       trace: [LogEvent] System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.Alm.Authentication.NetworkResponseContent.<SetContent>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Authentication.NetworkResponseMessage.<SetContent>d__19.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Authentication.Network.<>c__DisplayClass6_0.<<HttpHeadAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<DetectAuthority>d__34.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<GetAuthentication>d__35.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.CommonFunctions.<CreateAuthentication>d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.Program.<<Store>b__27_0>d.MoveNext()
11:35:32.525441 ...\Program.cs:601      trace: [Run] fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.

@bert2
Copy link

bert2 commented Oct 9, 2018

I installed the previous of version as suggested here and it resolved the issue: git-for-windows/git#1868 (comment)

Installing the previous version of git credential manager, 1.17.2, resolves the authentication issues for now.

https://github.com/Microsoft/Git-Credential-Manager-for-Windows/releases/tag/v1.17.2

I did not uninstall the current version. I just ran the installer.

@PhilipOakley
Copy link

looking at @viceice report, the difference shown by V1.17.2 is that the creds are for 'basic' with 'NTLM=Auto', but that it never gets that far with V1.18.0.

I remember that there was a lot of discussion historically on the Git List about some 'problems' in this area (with libcurl I think), so there is a lot of hackery in that region.

Have a look at https://public-inbox.org/git/?q=NTLM+basic+auth to see some on the threads on that issue. With this one https://public-inbox.org/git/alpine.DEB.2.20.1702281116360.3767@virtualbox/ looking like it has a few clues right at the beginning.

I suspect that the Cred Manager may also need to be clearer about the reason for the change that is causing the issue (It's beyond my level of knowledge in that arena)

@jeschu1
Copy link
Member

jeschu1 commented Oct 9, 2018

@sageliu
Copy link

sageliu commented Oct 10, 2018

进入项目的根目录,输入如下命令: git config --global credential.helper store,并在此从远程分支拉取一次代码,即git pull ...
可以解决需要反复输入密码的问题,但是如下的提示还是会重复出现
fatal: NullReferenceException encountered.
未将对象引用设置到对象的实例。

@MrNonsense
Copy link

@nilnul can you verify the issue is fixed in this release https://github.com/Microsoft/Git-Credential-Manager-for-Windows/releases/tag/v1.18.1

I was encountering the same NullReferenceException after updating Git for Windows (with the annexed new credential manager), and updating the credential manager to this version fixed it for me.
(thanks to @jeschu1 for the suggestion)

@jeschu1
Copy link
Member

jeschu1 commented Oct 10, 2018

@sageliu, Please

  1. set GCM_TRACE=1
  2. run your clone

I want to verify GCM 1.18.1 is being picked up.

@ghost
Copy link

ghost commented Oct 10, 2018

Windows 10 1803, Git for Windows 2.19.1

Cloning into 'xxyyzz'...
10:30:24.390597 ...\Common.cs:744       trace: [Main] git-credential-manager (v1.18.0) 'get'
10:30:24.516950 ...\Git\Where.cs:348    trace: [FindGitInstallations] found 1 Git installation(s).
10:30:24.522200 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 17 entries.
10:30:24.593730 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://xxyyzz.visualstudio.com/'.
10:30:24.974949 ...uthentication.cs:229 trace: [DetectAuthority] detected 'https://xxyyzz.visualstudio.com/' as Azure DevOps from GET response.
10:30:24.978217 ...\Program.cs:601      trace: [Run] ! error: 'Object reference not set to an instance of an object.'.
10:30:24.996963 ...\Common.cs:709       trace: [LogEvent] System.NullReferenceException: Object reference not set to an instance of an object.
   at AzureDevOps.Authentication.Authentication.<DetectAuthority>d__34.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureDevOps.Authentication.Authentication.<GetAuthentication>d__35.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.CommonFunctions.<CreateAuthentication>d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.CommonFunctions.<QueryCredentials>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Alm.Cli.Program.<<Get>b__24_0>d.MoveNext()
10:30:25.013729 ...\Program.cs:601      trace: [Run] fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
Username for 'https://xxyyzz.visualstudio.com':

Confirming that updating to 1.18.1 fixes it:

Cloning into 'xxyyzz'...
10:44:22.247274 ...\Common.cs:744       trace: [Main] git-credential-manager (v1.18.1) 'get'
10:44:22.363962 ...\Git\Where.cs:348    trace: [FindGitInstallations] found 1 Git installation(s).
10:44:22.373938 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 18 entries.
10:44:22.477659 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://xxyyzz.visualstudio.com/'.
10:44:25.359953 ...uthentication.cs:229 trace: [DetectAuthority] detected 'https://xxyyzz.visualstudio.com/' as Azure DevOps from GET response.
10:44:25.361979 ...uthentication.cs:297 trace: [DetectAuthority] tenant resource for 'https://xxyyzz.visualstudio.com/' is {00000000000000000000000000000000}.
10:44:25.363974 ...uthentication.cs:362 trace: [GetAuthentication] MSA authority detected.
10:44:25.488609 ...\Common.cs:205       trace: [CreateAuthentication] authority for 'https://xxyyzz.visualstudio.com/' is Microsoft Live.
10:44:25.489607 ...\Common.cs:765       trace: [QueryCredentials] querying 'MicrosoftAccount' for credentials.
10:45:04.531842 ...\Authority.cs:195    trace: [InteractiveAcquireToken] authority host URL = 'https://login.microsoftonline.com/live.com', token acquisition for tenant [xxx] succeeded.
10:45:04.534834 ...Authentication.cs:84 trace: [InteractiveLogon] token 'https://xxyyzz.visualstudio.com/' successfully acquired.
10:45:06.605513 ...\Authority.cs:533    trace: [GetAccessTokenRequestBody] creating access token scoped to 'vso.code_write vso.packaging' for 'https://xxyyzz.visualstudio.com/'
10:45:09.699672 ...\Authority.cs:124    trace: [GeneratePersonalAccessToken] personal access token acquisition for 'https://xxyyzz.visualstudio.com/' succeeded.
10:45:09.700668 ...uthentication.cs:458 trace: [GeneratePersonalAccessToken] personal access token created for 'https://xxyyzz.visualstudio.com/'.
10:45:13.725947 ...\Common.cs:849       trace: [QueryCredentials] credentials for 'https://xxyyzz.visualstudio.com/' found.
10:45:13.726945 ...\Common.cs:709       trace: [LogEvent] Microsoft Live credentials for 'https://xxyyzz.visualstudio.com/' successfully retrieved.
10:45:15.394879 ...\Common.cs:744       trace: [Main] git-credential-manager (v1.18.1) 'store'
10:45:15.566421 ...\Git\Where.cs:348    trace: [FindGitInstallations] found 1 Git installation(s).
10:45:15.580384 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 18 entries.
10:45:15.649200 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://[email protected]/'.
10:45:18.104645 ...uthentication.cs:229 trace: [DetectAuthority] detected 'https://xxyyzz.visualstudio.com/' as Azure DevOps from GET response.
10:45:18.106640 ...uthentication.cs:297 trace: [DetectAuthority] tenant resource for 'https://xxyyzz.visualstudio.com/' is {00000000000000000000000000000000}.
10:45:18.108635 ...uthentication.cs:362 trace: [GetAuthentication] MSA authority detected.
10:45:18.124601 ...\Common.cs:205       trace: [CreateAuthentication] authority for 'https://[email protected]/' is Microsoft Live.
10:45:18.126599 ...\Program.cs:522      trace: [Store] storing Azure DevOps credentials for 'https://[email protected]/'.
10:45:18.310097 ...\Common.cs:744       trace: [Main] git-credential-manager (v1.18.1) 'store'
10:45:18.434761 ...\Git\Where.cs:348    trace: [FindGitInstallations] found 1 Git installation(s).
10:45:18.446731 ...Configuration.cs:222 trace: [LoadGitConfiguration] git All config read, 18 entries.
10:45:18.525520 ...\Common.cs:85        trace: [CreateAuthentication] detecting authority type for 'https://[email protected]/'.
10:45:20.877827 ...uthentication.cs:229 trace: [DetectAuthority] detected 'https://xxyyzz.visualstudio.com/' as Azure DevOps from GET response.
10:45:20.881820 ...uthentication.cs:297 trace: [DetectAuthority] tenant resource for 'https://xxyyzz.visualstudio.com/' is {00000000000000000000000000000000}.
10:45:20.886046 ...uthentication.cs:362 trace: [GetAuthentication] MSA authority detected.
10:45:20.925701 ...\Common.cs:205       trace: [CreateAuthentication] authority for 'https://[email protected]/' is Microsoft Live.
10:45:20.926697 ...\Program.cs:522      trace: [Store] storing Azure DevOps credentials for 'https://[email protected]/'.
remote: Azure Repos
remote: Found 554 objects to send. (119 ms)
Receiving objects: 100% (554/554), 118.46 KiB | 142.00 KiB/s, done.
Resolving deltas: 100% (260/260), done.

In that case, you may want to get the Git for Windows folks to re-release 2.19 with an updated credential manager...

@nilnul
Copy link
Author

nilnul commented Oct 11, 2018

@jeschu1, great that you guys make such a quick patch. @MrNonsense, thank you for taking that test and it looks assuring. I'll give the new version of GCM a try later for now I'm working in a product environment

@nilnul
Copy link
Author

nilnul commented Oct 11, 2018

@sageliu ,

git config --global credential.helper store

to my knowledge, by changing the helper to "store", you may have switched off "manager", aka GCM, which stores password in vault where MS claims safe.

@jeschu1 jeschu1 closed this as completed Oct 12, 2018
@jpluimers
Copy link

Like many people in git-for-windows/git#1868 , I downgraded from https://github.com/git-for-windows/git/releases/tag/v2.19.1.windows.1 to https://github.com/git-for-windows/git/releases/tag/v2.19.0.windows.1 (x64 version) which "resolved" the symptom: no more "NullReferenceException" during https pull or push.

This narrows down the commit range where the issue was introduced.

If you cannot wait for a newer release, try git-for-windows/git#1868 (comment), or try a snapshot, then you can use 1.19.0 as a workaround.

@gnattwc
Copy link

gnattwc commented Oct 25, 2018

works great after downgrade to 2.9.0.
Releases section of the repository on GitHub

@psimoneau22
Copy link

I am getting the same thing.

git push
fatal: NullReferenceException encountered.
   Object reference not set to an instance of an object.
 ...

git --version
git version 2.19.1.windows.1

@viceice
Copy link

viceice commented Oct 26, 2018

Simply install GCMW >= 1.18.1 after git upgrade. This will resolve this issue.

@nilnul
Copy link
Author

nilnul commented Oct 27, 2018

I have upgraded git for windows (which, I think, comes with the upgraded git credential manager).

Now the upgraded version works fine.

Thank you. @jeschu1

@testworksau
Copy link

Simply install GCMW >= 1.19.1 after git upgrade. This will resolve this issue.

That should be >= 1.18.1

@viceice
Copy link

viceice commented Oct 29, 2018

@testworksau: You are right, fixed my comment. 😄

@goxr3plus
Copy link

Had exactly the same problem .... exactly -> Simply install latest version of GCMW as @testworksau said .

So in the system now i have :

Git Credential Manager for Windows v1.18.2
(2.19.1) 64-bit version of Git for Windows.

What a pain it was typing everytime the passwords .... thank you for this issue :)

@Kirkaiya
Copy link

Simply install GCMW >= 1.18.1 after git upgrade. This will resolve this issue.

This also fixed the problem for me.
git version 2.19.1.windows.1

Remote is an AWS CodeCommit repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests