Skip to content

Commit eee34e6

Browse files
committed
Fix review comments
1 parent a6d6343 commit eee34e6

4 files changed

+8
-6
lines changed

GitHubConfiguration.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ function Set-GitHubConfiguration
244244
}
245245
}
246246

247-
if (-not $PSCmdlet.ShouldProcess('GitHubConfiguration',' Save'))
247+
if (-not $PSCmdlet.ShouldProcess('GitHubConfiguration','Save'))
248248
{
249249
return
250250
}
@@ -344,7 +344,7 @@ function Save-GitHubConfiguration
344344
[string] $Path
345345
)
346346

347-
if (-not $PSCmdlet.ShouldProcess('GitHub Configuration','Save'))
347+
if (-not $PSCmdlet.ShouldProcess('GitHub Configuration', 'Save'))
348348
{
349349
return
350350
}
@@ -514,7 +514,7 @@ function Reset-GitHubConfiguration
514514

515515
Set-TelemetryEvent -EventName Reset-GitHubConfiguration
516516

517-
if (-not $PSCmdlet.ShouldProcess('GitHub Configuration','Reset'))
517+
if (-not $PSCmdlet.ShouldProcess('GitHub Configuration', 'Reset'))
518518
{
519519
return
520520
}

GitHubIssueComments.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ filter Set-GitHubIssueComment
550550
'body' = $Body
551551
}
552552

553-
if (-not $PSCmdlet.ShouldProcess($Issue, 'Create GitHub Issue Comment'))
553+
if (-not $PSCmdlet.ShouldProcess($Comment, 'Update GitHub Issue Comment'))
554554
{
555555
return
556556
}

GitHubProjectColumns.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ filter Move-GitHubProjectColumn
477477
'position' = $Position
478478
}
479479

480-
if (-not $PSCmdlet.ShouldProcess($ColumnName, 'Move GitHub Project Column'))
480+
if (-not $PSCmdlet.ShouldProcess($Column, 'Move GitHub Project Column'))
481481
{
482482
return
483483
}

GitHubPullRequests.ps1

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,7 @@ filter New-GitHubPullRequest
391391
if ($PSBoundParameters.ContainsKey('Title'))
392392
{
393393
$description = "Creating pull request $Title in $RepositoryName"
394+
$shouldProcessAction = "Create GitHub Pull Request $Title"
394395
$postBody['title'] = $Title
395396

396397
# Body may be whitespace, although this might not be useful
@@ -402,6 +403,7 @@ filter New-GitHubPullRequest
402403
else
403404
{
404405
$description = "Creating pull request for issue $Issue in $RepositoryName"
406+
$shouldProcessAction = "Create GitHub Pull Request for Issue $Issue"
405407
$postBody['issue'] = $Issue
406408
}
407409

@@ -416,7 +418,7 @@ filter New-GitHubPullRequest
416418
$acceptHeader = 'application/vnd.github.shadow-cat-preview+json'
417419
}
418420

419-
if (-not $PSCmdlet.ShouldProcess($Title, 'Create GitHub Pull Request'))
421+
if (-not $PSCmdlet.ShouldProcess($RepositoryName, $shouldProcessAction))
420422
{
421423
return
422424
}

0 commit comments

Comments
 (0)