From 1d3ae59b0fb67455cc7afb2d481a4540103ac227 Mon Sep 17 00:00:00 2001 From: Serafima Date: Thu, 21 Jan 2021 18:51:48 +0300 Subject: [PATCH 1/3] disable name editing for templates --- .../fancyzones/editor/FancyZonesEditor/MainWindow.xaml | 1 + .../editor/FancyZonesEditor/Models/LayoutModel.cs | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml b/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml index 93d07a7cb9ce..7d5eb018feec 100644 --- a/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml +++ b/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml @@ -416,6 +416,7 @@ Foreground="{DynamicResource PrimaryForegroundBrush}" /> diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/Models/LayoutModel.cs b/src/modules/fancyzones/editor/FancyZonesEditor/Models/LayoutModel.cs index 12ea50353866..ea66005b22ac 100644 --- a/src/modules/fancyzones/editor/FancyZonesEditor/Models/LayoutModel.cs +++ b/src/modules/fancyzones/editor/FancyZonesEditor/Models/LayoutModel.cs @@ -90,6 +90,14 @@ public string Uuid } } + public bool IsCustom + { + get + { + return Type == LayoutType.Custom; + } + } + // IsSelected (not-persisted) - tracks whether or not this LayoutModel is selected in the picker // TODO: once we switch to a picker per monitor, we need to move this state to the view public bool IsSelected From b58665fb1ee5e99abe3f11d6fd8217563dd24ff8 Mon Sep 17 00:00:00 2001 From: Serafima Date: Thu, 21 Jan 2021 18:52:20 +0300 Subject: [PATCH 2/3] hide "Edit zones" button for templates --- .../LayoutTypeCustomToVisibilityConverter.cs | 25 +++++++++++++++++++ .../editor/FancyZonesEditor/MainWindow.xaml | 2 ++ 2 files changed, 27 insertions(+) create mode 100644 src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeCustomToVisibilityConverter.cs diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeCustomToVisibilityConverter.cs b/src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeCustomToVisibilityConverter.cs new file mode 100644 index 000000000000..67f685de71b2 --- /dev/null +++ b/src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeCustomToVisibilityConverter.cs @@ -0,0 +1,25 @@ +// Copyright (c) Microsoft Corporation +// The Microsoft Corporation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; +using System.Globalization; +using System.Windows; +using System.Windows.Data; +using FancyZonesEditor.Models; + +namespace FancyZonesEditor.Converters +{ + public class LayoutTypeCustomToVisibilityConverter : IValueConverter + { + public object Convert(object value, Type targetType, object parameter, CultureInfo culture) + { + return (LayoutType)value == LayoutType.Custom ? Visibility.Visible : Visibility.Collapsed; + } + + public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) + { + return null; + } + } +} diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml b/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml index 7d5eb018feec..c3e091a0a1c9 100644 --- a/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml +++ b/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml @@ -27,6 +27,7 @@ + From ce808ae798e08dcb2625825f4c85b9857c35c02c Mon Sep 17 00:00:00 2001 From: Serafima Date: Fri, 22 Jan 2021 14:31:53 +0300 Subject: [PATCH 3/3] added zone number --- ...LayoutTypeTemplateToVisibilityConverter.cs | 25 ++++++++++++ .../editor/FancyZonesEditor/MainWindow.xaml | 40 ++++++++++++++++++- .../Properties/Resources.Designer.cs | 9 +++++ .../Properties/Resources.resx | 3 ++ 4 files changed, 75 insertions(+), 2 deletions(-) create mode 100644 src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeTemplateToVisibilityConverter.cs diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeTemplateToVisibilityConverter.cs b/src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeTemplateToVisibilityConverter.cs new file mode 100644 index 000000000000..c525f2a11f58 --- /dev/null +++ b/src/modules/fancyzones/editor/FancyZonesEditor/Converters/LayoutTypeTemplateToVisibilityConverter.cs @@ -0,0 +1,25 @@ +// Copyright (c) Microsoft Corporation +// The Microsoft Corporation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; +using System.Globalization; +using System.Windows; +using System.Windows.Data; +using FancyZonesEditor.Models; + +namespace FancyZonesEditor.Converters +{ + public class LayoutTypeTemplateToVisibilityConverter : IValueConverter + { + public object Convert(object value, Type targetType, object parameter, CultureInfo culture) + { + return (LayoutType)value != LayoutType.Custom ? Visibility.Visible : Visibility.Collapsed; + } + + public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) + { + return null; + } + } +} diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml b/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml index c3e091a0a1c9..8301b9d02c03 100644 --- a/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml +++ b/src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml @@ -28,6 +28,7 @@ + + + + + + @@ -410,16 +434,28 @@ - + + + +