Skip to content

feat: refine the logic of enabling hyperparameter tuning and add criteira#1175

Merged
RolandMinrui merged 4 commits intomainfrom
minrui/revert_tuning_criteria
Aug 12, 2025
Merged

feat: refine the logic of enabling hyperparameter tuning and add criteira#1175
RolandMinrui merged 4 commits intomainfrom
minrui/revert_tuning_criteria

Conversation

@RolandMinrui
Copy link
Copy Markdown
Contributor

@RolandMinrui RolandMinrui commented Aug 12, 2025

Description

Motivation and Context

How Has This Been Tested?

  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

📚 Documentation preview 📚: https://RDAgent--1175.org.readthedocs.build/en/1175/

@RolandMinrui RolandMinrui requested review from peteryang1 and you-n-g and removed request for peteryang1 August 12, 2025 03:55
timer = RD_Agent_TIMER_wrapper.timer
res_time = timer.remain_time()
if DS_RD_SETTING.only_enable_tuning_in_merge:
c3 = res_time >= timedelta(hours=DS_RD_SETTING.merge_hours)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the direction correct?


# 4. The current time spent on global is less than the time limit ratio for whole timeout.
res_ratio = res_time / timer.all_duration
c4 = (1-res_ratio) <= DS_RD_SETTING.overall_time_ratio_limit_to_enable_hyperparameter_tuning
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the direction correct?

Comment thread rdagent/scenarios/data_science/dev/runner/eval.py
Co-authored-by: you-n-g <you-n-g@users.noreply.github.com>
@RolandMinrui RolandMinrui merged commit af071f5 into main Aug 12, 2025
9 checks passed
@RolandMinrui RolandMinrui deleted the minrui/revert_tuning_criteria branch August 12, 2025 13:12
licong01-cloud pushed a commit to licong01-cloud/RD-Agent that referenced this pull request Dec 13, 2025
…eira (microsoft#1175)

* add 4 tuning criteria

* fix equation direction

* fix ci

* add comment

Co-authored-by: you-n-g <you-n-g@users.noreply.github.com>

---------

Co-authored-by: Xu <v-xuminrui@microsoft.com>
Co-authored-by: you-n-g <you-n-g@users.noreply.github.com>
yongbin4 pushed a commit to yongbin4/RD-Agent that referenced this pull request Mar 8, 2026
…eira (microsoft#1175)

* add 4 tuning criteria

* fix equation direction

* fix ci

* add comment

Co-authored-by: you-n-g <you-n-g@users.noreply.github.com>

---------

Co-authored-by: Xu <v-xuminrui@microsoft.com>
Co-authored-by: you-n-g <you-n-g@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants