Skip to content

document.fullscreenElement gone #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Aug 2, 2018 · 6 comments
Closed

document.fullscreenElement gone #551

ghost opened this issue Aug 2, 2018 · 6 comments

Comments

@ghost
Copy link

ghost commented Aug 2, 2018

interface Document used to define a property readonly fullscreenElement: Element | null;. It looks like as of microsoft/TypeScript#25944 this property is missing. It doesn't seem to be deprecated so maybe it should be added back?
Detected in vast-client on DefinitelyTyped.
@ghost
Copy link
Author

ghost commented Aug 2, 2018

document.onfullscreenchange and document.documentElement.requestFullscreen are gone too, although browser compatibility for those isn't as good. Detected in w3c-screen-orientation on DefinitelyTyped.

@saschanaz saschanaz mentioned this issue Aug 2, 2018
Merged
@mhegazy mhegazy mentioned this issue Aug 2, 2018
Merged
@ghost
Copy link
Author

ghost commented Aug 6, 2018

This doesn't seem to be fixed in [email protected] -- document.fullscreenElement is still a compile error.

@ghost ghost reopened this Aug 6, 2018
@magcius
Copy link
Contributor

magcius commented Nov 1, 2018

The PR added the events and methods back but not the property.

@magcius magcius mentioned this issue Nov 1, 2018
Merged
@magcius
Copy link
Contributor

magcius commented Nov 1, 2018

PR attached.

@saschanaz
Copy link
Contributor

@github-actions close

@github-actions
Copy link
Contributor

Closing because @saschanaz is one of the code-owners of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magcius @saschanaz