Update core dependencies #2047
Open
Update core dependencies #2047
+695
−1,063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Woah |
|
See why I deferred it? 😂 |
typescript-bot
force-pushed
the
update-core-deps
branch
from
325a617 to
8685ba5
Compare
Bashamega
suggested changes
Jun 21, 2025
baselines/dom.generated.d.ts
Outdated
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin) */ | ||
| margin: string; | ||
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-bottom) */ | ||
| margin-bottom: string; |
There was a problem hiding this comment.
It needs to be wrapped in quotation marks.
baselines/dom.generated.d.ts
Outdated
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-right) */ | ||
| margin-right: string; | ||
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-top) */ | ||
| margin-top: string; |
There was a problem hiding this comment.
It needs to be wrapped in quotation marks.
baselines/dom.generated.d.ts
Outdated
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-left) */ | ||
| margin-left: string; | ||
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-right) */ | ||
| margin-right: string; |
There was a problem hiding this comment.
It needs to be wrapped in quotation marks.
baselines/dom.generated.d.ts
Outdated
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-bottom) */ | ||
| margin-bottom: string; | ||
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-left) */ | ||
| margin-left: string; |
There was a problem hiding this comment.
It needs to be wrapped in quotation marks.
typescript-bot
force-pushed
the
update-core-deps
branch
3 times, most recently
from
324c995 to
9a9140a
Compare
Bashamega
approved these changes
Jun 23, 2025
|
Resolves #1199. |
typescript-bot
force-pushed
the
update-core-deps
branch
5 times, most recently
from
18e8e79 to
387c217
Compare
|
Ok, enough procrastination. Updating to bcd 6.0.24 adds 46 new Web IDL interfaces:
I do NOT want to add them with a single PR, so instead I'll disable most of them and restore them progressively. |
typescript-bot
force-pushed
the
update-core-deps
branch
3 times, most recently
from
b09d336 to
30ec5e6
Compare
3 tasks
typescript-bot
force-pushed
the
update-core-deps
branch
8 times, most recently
from
e0fe8ad to
fa9ba03
Compare
typescript-bot
force-pushed
the
update-core-deps
branch
from
fa9ba03 to
edf353a
Compare
typescript-bot
force-pushed
the
update-core-deps
branch
from
edf353a to
d523a1d
Compare
typescript-bot
force-pushed
the
update-core-deps
branch
from
d523a1d to
37dbaa2
Compare
|
LGTM, the current PR only includes the spec change from w3c/reporting#284 and a few comment changes. |
|
There was an issue merging, maybe try again saschanaz. Details |
jakebailey
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action