Merge branch 'main' into lsp-mem-fix

Author: ghost2023

.github/skills/mcfly/SKILL.md

@@ -4,18 +4,19 @@ description: Only invoke when explicitly instructed to
 ---
 
 You need to "re-stack" your commits to match the following format:
- * A failing test case
+ * Testcase(s), including at least one that demonstrate the problem - this could be a test that directly fails, baselines that show the problem, or even both
  * A commit, or series of commits, that fixes the failing test case
- * (Optional) a follow-up commit that checks in any modified baselines
+ * If needed, a follow-up commit with modified baselines
 
 Since you can't force-push, start with a commit that undoes all your prior changes and gets you back to `main`.
 
 Then add your test case(s) in a single commit.
+When you add testcases that create or modify baselines, commit the (pre-fix) baselines at the same time as the testcases themselves.
 A test case isn't necessarily a new file; it could be a modification to an existing test or a change in the test configuration.
 Ensure that at least one test in the full run fails - you might be operating on a bad PR that didn't actually introduce a failing scenario!
 If zero tests failed, abort and post a message explaining what you observed.
 Remember that baseline tests do not "fail" in the traditional sense; they are used to verify that the output matches the expected baseline.
-You should examine the PR description to determine what the desired passing baseline should look like.
+Ensure that your test demonstrates the problem that the PR is intended to fix.
 
 Then, add your fix.
 You can break this apart into multiple commits if it's more logical to review that way; use your judgment.

packages/typescript/src/api/async/api.ts

@@ -60,14 +60,18 @@ import {
     toPath,
 } from "../path.ts";
 import type {
+    BuildResponse,
+    CleanBuildResponse,
     CompilerOptions,
     ConfiguredProjectId,
+    CreateBuildOrchestratorResponse,
     CreateProgramOptions as ProtocolCreateProgramOptions,
     CreateSnapshotParams as ProtocolCreateSnapshotParams,
     CreateSnapshotProgramParams as ProtocolCreateSnapshotProgramParams,
     CreateSnapshotResponse,
     CreateSourceFileOptions,
     Diagnostic,
+    DiagnosticResponse,
     DocumentIdentifier,
     DocumentPosition,
     EmitOutputResponse as ProtocolEmitOutputResponse,
@@ -328,6 +332,7 @@ export class API<FromLSP extends boolean = false> implements FormatDiagnosticsHo
     private initialized: boolean = false;
     private initializing: Promise<void> | undefined;
     private activeSnapshots: Map<number, Snapshot> = new Map();
+    private activeBuildOrchestrators: Set<BuildOrchestrator> = new Set();
     private activeSourceFileLeases: Map<number, RetainedSourceFile> = new Map();
     readonly printer: Printer;
     readonly internal: InternalAPI;
@@ -399,6 +404,21 @@ export class API<FromLSP extends boolean = false> implements FormatDiagnosticsHo
         return "\n";
     }
 
+    async createBuildOrchestrator(rootNames: readonly string[], buildOrchestratorOptions: BuildOrchestratorOptions): Promise<BuildOrchestrator> {
+        await this.ensureInitialized();
+        const orchestratorResponse = await this.client.apiRequest("createBuildOrchestrator", {
+            ...buildOrchestratorOptions,
+            ...buildOrchestratorOptions.overrideCompilerOptions,
+            rootNames,
+        });
+
+        const orchestrator = new BuildOrchestrator(this.client, orchestratorResponse, () => {
+            this.activeBuildOrchestrators.delete(orchestrator);
+        });
+        this.activeBuildOrchestrators.add(orchestrator);
+        return orchestrator;
+    }
+
     async parseConfigFile(file: DocumentIdentifier): Promise<ParsedCommandLine> {
         await this.ensureInitialized();
         return this.client.apiRequest("parseConfigFile", { file });
@@ -652,6 +672,9 @@ export class API<FromLSP extends boolean = false> implements FormatDiagnosticsHo
         }
         finally {
             try {
+                for (const orchestrator of [...this.activeBuildOrchestrators]) {
+                    await orchestrator.dispose();
+                }
                 for (const snapshot of [...this.activeSnapshots.values()]) {
                     await snapshot.dispose();
                 }
@@ -1961,6 +1984,107 @@ export class Program<Id extends ProjectId = ProjectId> implements FormatDiagnost
     }
 }
 
+export interface BuildOrchestratorOptions {
+    cwd?: string | undefined;
+    dry?: boolean;
+    force?: boolean;
+    verbose?: boolean;
+    stopBuildOnErrors?: boolean;
+    overrideCompilerOptions?: OverrideCompilerOptions;
+}
+
+export interface OverrideCompilerOptions {
+    incremental?: boolean;
+    assumeChangesOnlyAffectDirectDependencies?: boolean;
+    declaration?: boolean;
+    declarationMap?: boolean;
+    emitDeclarationOnly?: boolean;
+    sourceMap?: boolean;
+    inlineSourceMap?: boolean;
+    traceResolution?: boolean;
+}
+
+export class BuildOrchestrator {
+    private client: Client;
+    private id: number;
+    private disposed = false;
+    private disposePromise: Promise<void> | undefined;
+    private onDispose: () => void;
+
+    constructor(
+        client: Client,
+        orchestratorResponse: CreateBuildOrchestratorResponse,
+        onDispose: () => void,
+    ) {
+        this.client = client;
+        this.id = orchestratorResponse.buildOrchestratorID;
+        this.onDispose = onDispose;
+    }
+
+    [globalThis.Symbol.dispose](): void {
+        void this.dispose();
+    }
+    dispose(): Promise<void> {
+        return this.disposePromise ??= this.disposeWorker();
+    }
+
+    private async disposeWorker(): Promise<void> {
+        if (this.disposed) return;
+        this.disposed = true;
+        try {
+            await this.client.apiRequest("disposeBuildOrchestrator", {
+                buildOrchestratorID: this.id,
+            });
+        }
+        finally {
+            this.onDispose();
+        }
+    }
+
+    async build(project?: string): Promise<BuildResponse> {
+        this.ensureNotDisposed();
+        const response = await this.client.apiRequest("build", {
+            buildOrchestratorID: this.id,
+            ...(project !== undefined ? { project } : {}),
+        });
+        return response;
+    }
+    async buildReferences(project: string): Promise<BuildResponse> {
+        this.ensureNotDisposed();
+        const response = await this.client.apiRequest("buildReferences", {
+            buildOrchestratorID: this.id,
+            project,
+        });
+        return response;
+    }
+    async clean(project?: string): Promise<CleanBuildResponse> {
+        this.ensureNotDisposed();
+        const response = await this.client.apiRequest("cleanBuild", {
+            buildOrchestratorID: this.id,
+            ...(project !== undefined ? { project } : {}),
+        });
+        return response;
+    }
+    async cleanReferences(project?: string): Promise<CleanBuildResponse> {
+        this.ensureNotDisposed();
+        const response = await this.client.apiRequest("cleanReferences", {
+            buildOrchestratorID: this.id,
+            ...(project !== undefined ? { project } : {}),
+        });
+        return response;
+    }
+
+    isDisposed(): boolean {
+        return this.disposed;
+    }
+
+    private ensureNotDisposed(): void {
+        if (this.disposed) {
+            throw new Error("Build orchestrator is disposed");
+        }
+    }
+}
+
 function toEmitOutput(response: ProtocolEmitOutputResponse): EmitOutput {
     const outputFiles = new Map<string, EmitOutputFile>();
     for (const { fileName, ...outputFile } of response.outputFiles) {

packages/typescript/src/api/fs.ts

@@ -36,7 +36,7 @@ export interface FileSystem {
 }
 
 /** The callback names supported by the Go server for virtual FS delegation. */
-export const fsCallbackNames = ["readFile", "fileExists", "directoryExists", "getAccessibleEntries", "realpath", "writeFile"] as const;
+export const fsCallbackNames = ["readFile", "fileExists", "directoryExists", "getAccessibleEntries", "realpath", "writeFile", "removeFile"] as const;
 
 export interface CreateFileSystemOptions {
     /** Complete directory listings. Full filesystems derive these from `files` when omitted. */

packages/typescript/src/api/proto.generated.ts

@@ -27,6 +27,12 @@ export interface APIMethodInfo {
     createSnapshot: APIMethod<CreateSnapshotParams, CreateSnapshotResponse>;
     updateSnapshot: APIMethod<UpdateSnapshotParams, CreateSnapshotResponse>;
     getCurrentLanguageServerSnapshot: APIMethod<GetCurrentLanguageServerSnapshotParams, CreateSnapshotResponse>;
+    createBuildOrchestrator: APIMethod<CreateBuildOrchestratorParams, CreateBuildOrchestratorResponse>;
+    disposeBuildOrchestrator: APIMethod<DisposeBuildOrchestratorParams, unknown>;
+    build: APIMethod<BuildParams, BuildResponse>;
+    buildReferences: APIMethod<BuildParams, BuildResponse>;
+    cleanBuild: APIMethod<CleanBuildParams, CleanBuildResponse>;
+    cleanReferences: APIMethod<CleanBuildParams, CleanBuildResponse>;
     createModuleResolver: APIMethod<CreateModuleResolverParams, number>;
     releaseModuleResolver: APIMethod<ReleaseModuleResolverParams, unknown>;
     resolveModuleName: APIMethod<ResolveModuleNameParams, ResolveModuleNameResult>;
@@ -262,6 +268,42 @@ export interface GetCurrentLanguageServerSnapshotParams {
     changes?: LanguageServerSnapshotChanges | undefined;
 }
 
+export interface CreateBuildOrchestratorParams extends BuildOptions, CompilerOptions {
+    rootNames: readonly string[] | null;
+    cwd?: string | undefined;
+}
+
+export interface CreateBuildOrchestratorResponse {
+    buildOrchestratorID: number;
+}
+
+export interface DisposeBuildOrchestratorParams {
+    buildOrchestratorID: number;
+}
+
+export interface BuildParams {
+    buildOrchestratorID: number;
+    project?: string | undefined;
+}
+
+export interface BuildResponse {
+    status: number;
+    diagnostics?: DiagnosticResponse[] | undefined;
+    statistics: Statistics;
+}
+
+export interface CleanBuildParams {
+    buildOrchestratorID: number;
+    project?: string | undefined;
+}
+
+export interface CleanBuildResponse {
+    status: number;
+    diagnostics?: DiagnosticResponse[] | undefined;
+    statistics: Statistics;
+    filesDeleted?: string[] | undefined;
+}
+
 export interface CreateModuleResolverParams {
     compilerOptions: CompilerOptions;
     moduleResolutions?: ModuleResolutionSpec | undefined;
@@ -294,6 +336,7 @@ export interface ParseCommandLineParams {
 export interface ConfigFileResponse {
     fileNames: string[];
     options: CompilerOptions;
+    buildOptions?: BuildOptions | undefined;
     projectReferences?: ProjectReference[] | undefined;
     typeAcquisition?: TypeAcquisition | undefined;
     compileOnSave?: boolean | undefined;
@@ -1042,10 +1085,16 @@ export interface ProfileResult {
 export interface BatchRequest {
     method:
         | "batchRequests"
+        | "build"
+        | "buildReferences"
+        | "cleanBuild"
+        | "cleanReferences"
+        | "createBuildOrchestrator"
         | "createModuleResolver"
         | "createSnapshot"
         | "createSourceFile"
         | "createSourceFileFromFile"
+        | "disposeBuildOrchestrator"
         | "emit"
         | "emitToString"
         | "formatNodeForInsertion"
@@ -1211,10 +1260,16 @@ export interface BatchRequest {
 export interface BatchResponse {
     method:
         | "batchRequests"
+        | "build"
+        | "buildReferences"
+        | "cleanBuild"
+        | "cleanReferences"
+        | "createBuildOrchestrator"
         | "createModuleResolver"
         | "createSnapshot"
         | "createSourceFile"
         | "createSourceFileFromFile"
+        | "disposeBuildOrchestrator"
         | "emit"
         | "emitToString"
         | "formatNodeForInsertion"
@@ -1482,6 +1537,16 @@ export interface SnapshotOperationResponse {
 export interface LanguageServerSnapshotChanges extends SnapshotRequestChangesParams {
 }
 
+export interface BuildOptions {
+    dry?: boolean | undefined;
+    force?: boolean | undefined;
+    verbose?: boolean | undefined;
+    builders?: number | undefined;
+    stopBuildOnErrors?: boolean | undefined;
+    /** Internal fields */
+    clean?: boolean | undefined;
+}
+
 /** CompilerOptions contains the compiler options exposed by the API. */
 export interface CompilerOptions {
     allowJs?: boolean | undefined;
@@ -1590,6 +1655,12 @@ export interface CompilerOptions {
     configFilePath?: string | undefined;
 }
 
+export interface Statistics {
+    Projects: number;
+    ProjectsBuilt: number;
+    TimestampUpdates: number;
+}
+
 export interface ModuleResolutionSpec {
     fallback: "resolve" | "unresolved";
     entries: ModuleResolutionEntry[];

packages/typescript/src/api/proto.ts

@@ -92,6 +92,10 @@ export interface CreateSnapshotParams extends CoreCreateSnapshotParams {
     openProject?: string | undefined;
 }
 
+export interface CreateBuildOrchestratorParams {
+    rootNames: readonly string[] | null;
+}
+
 /**
  * Builds the wire request for createSnapshot, applying the deprecated `openProject`
  * compatibility shim: a single `openProject` is folded into `openProjects` and is