goToDefinition: Don't go to jsx constructor signature (#25382)

Author: Andy

src/services/goToDefinition.ts

@@ -28,7 +28,8 @@ namespace ts.GoToDefinition {
         }
 
         const calledDeclaration = tryGetSignatureDeclaration(typeChecker, node);
-        if (calledDeclaration) {
+        // Don't go to the component constructor definition for a JSX element, just go to the component definition.
+        if (calledDeclaration && !(isJsxOpeningLikeElement(node.parent) && isConstructorDeclaration(calledDeclaration))) {
             const sigInfo = createDefinitionFromSignatureDeclaration(typeChecker, calledDeclaration);
             // For a function, if this is the original function definition, return just sigInfo.
             // If this is the original constructor definition, parent is the class.

tests/cases/fourslash/goToDefinitionSignatureAlias.ts

@@ -1,5 +1,8 @@
 /// <reference path='fourslash.ts'/>
 
+// @jsx: preserve
+
+// @Filename: /a.tsx
 ////function /*f*/f() {}
 ////const /*g*/g = f;
 ////const /*h*/h = g;
@@ -17,6 +20,13 @@
 ////const o = { m: /*m*/() => 0 };
 ////o.[|/*useM*/m|]();
 
+////class Component { /*componentCtr*/constructor(props: {}) {} }
+////class /*MyComponent*/MyComponent extends Component {}
+////<[|/*jsxMyComponent*/MyComponent|] />
+////new [|/*newMyComponent*/MyComponent|]({});
+
+verify.noErrors();
+
 verify.goToDefinition({
     useF: "f",
     useG: ["g", "f"],
@@ -25,4 +35,7 @@ verify.goToDefinition({
     useI: "i",
     useJ: ["j", "i"],
     useM: "m",
+
+    jsxMyComponent: "MyComponent",
+    newMyComponent: ["MyComponent", "componentCtr"],
 });

tests/cases/fourslash/tsxGoToDefinitionStatelessFunction2.ts

@@ -27,14 +27,14 @@
 //// let opt = <[|Main/*secondTarget*/Button|] children="chidlren" />;
 //// let opt = <[|Main/*thirdTarget*/Button|] onClick={()=>{}} />;
 //// let opt = <[|Main/*fourthTarget*/Button|] onClick={()=>{}} ignore-prop />;
-//// let opt = <[|Main/*fivethTarget*/Button|] goTo="goTo" />;
+//// let opt = <[|Main/*fifthTarget*/Button|] goTo="goTo" />;
 //// let opt = <[|Main/*sixthTarget*/Button|] wrong />;
 
 verify.goToDefinition({
     firstTarget: "thirdSource",
     secondTarget: "thirdSource",
     thirdTarget: "firstSource",
     fourthTarget: "firstSource",
-    fivethTarget: "secondSource",
+    fifthTarget: "secondSource",
     sixthTarget: "thirdSource"
 });