Fix circularity errors in intra-binding-pattern references (#59183)

Author: ahejlsberg

src/compiler/checker.ts

@@ -2680,10 +2680,6 @@
         "category": "Error",
         "code": 2524
     },
-    "Initializer provides no value for this binding element and the binding element has no default value.": {
-        "category": "Error",
-        "code": 2525
-    },
     "A 'this' type is available only in a non-static member of a class or interface.": {
         "category": "Error",
         "code": 2526

src/compiler/diagnosticMessages.json

@@ -6697,7 +6697,7 @@ export const enum AccessFlags {
     NoIndexSignatures = 1 << 1,
     Writing = 1 << 2,
     CacheSymbol = 1 << 3,
-    NoTupleBoundsCheck = 1 << 4,
+    AllowMissing = 1 << 4,
     ExpressionPosition = 1 << 5,
     ReportDeprecated = 1 << 6,
     SuppressNoImplicitAnyError = 1 << 7,

src/compiler/types.ts

@@ -9,24 +9,24 @@ function Test({ b = '' } = {}) {}
 >  : ^^^^^^
 >'' : ""
 >   : ^^
->{} : { b?: string; }
->   : ^^^^^^^^^^^^^^^
+>{} : {}
+>   : ^^
 
 Test(({ b = '5' } = {}));
 >Test(({ b = '5' } = {})) : void
 >                         : ^^^^
 >Test : ({ b }?: { b?: string; }) => void
 >     : ^     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
->({ b = '5' } = {}) : { b?: any; }
->                   : ^^^^^^^^^^^^
->{ b = '5' } = {} : { b?: any; }
->                 : ^^^^^^^^^^^^
+>({ b = '5' } = {}) : {}
+>                   : ^^
+>{ b = '5' } = {} : {}
+>                 : ^^
 >{ b = '5' } : { b?: any; }
 >            : ^^^^^^^^^^^^
 >b : any
 >  : ^^^
 >'5' : "5"
 >    : ^^^
->{} : { b?: any; }
->   : ^^^^^^^^^^^^
+>{} : {}
+>   : ^^
 

tests/baselines/reference/checkDestructuringShorthandAssigment.types

@@ -1,14 +1,11 @@
-checkDestructuringShorthandAssigment2.ts(4,7): error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
 checkDestructuringShorthandAssigment2.ts(4,27): error TS2353: Object literal may only specify known properties, and '[k]' does not exist in type '{ x: any; }'.
 
 
-==== checkDestructuringShorthandAssigment2.ts (2 errors) ====
+==== checkDestructuringShorthandAssigment2.ts (1 errors) ====
     // GH #38175 -- should not crash while checking
 
     let o: any, k: any;
     let { x } = { x: 1, ...o, [k]: 1 };
-          ~
-!!! error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
                               ~~~
 !!! error TS2353: Object literal may only specify known properties, and '[k]' does not exist in type '{ x: any; }'.
 

tests/baselines/reference/checkDestructuringShorthandAssigment2.errors.txt

@@ -104,8 +104,8 @@ type Something = { foo: number };
 
 // inference fails here, but ideally should not
 const A = object<Something>()({
->A : ObjectType<Something>
->  : ^^^^^^^^^^^^^^^^^^^^^
+>A : any
+>  : ^^^
 >object<Something>()({  name: "A",  fields: () => ({    a: field({      type: A,      resolve() {        return {          foo: 100,        };      },    }),  }),}) : ObjectType<Something>
 >                                                                                                                                                                    : ^^^^^^^^^^^^^^^^^^^^^
 >object<Something>() : <Fields extends { [Key in keyof Fields]: Field<Something, Key & string>; }>(config: { name: string; fields: Fields | (() => Fields); }) => ObjectType<Something>
@@ -138,14 +138,14 @@ const A = object<Something>()({
 >                                                                                                  : ^^^^^^^^^^^^^^^^^^^^^
 >field : <Source, Type extends ObjectType<any>, Key extends string>(field: FieldFuncArgs<Source, Type>) => Field<Source, Key>
 >      : ^      ^^    ^^^^^^^^^               ^^   ^^^^^^^^^      ^^     ^^                           ^^^^^                  
->{      type: A,      resolve() {        return {          foo: 100,        };      },    } : { type: ObjectType<Something>; resolve(): { foo: number; }; }
->                                                                                           : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+>{      type: A,      resolve() {        return {          foo: 100,        };      },    } : { type: any; resolve(): { foo: number; }; }
+>                                                                                           : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
       type: A,
->type : ObjectType<Something>
->     : ^^^^^^^^^^^^^^^^^^^^^
->A : ObjectType<Something>
->  : ^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
+>A : any
+>  : ^^^
 
       resolve() {
 >resolve : () => { foo: number; }

tests/baselines/reference/circularReferenceInReturnType2.types

@@ -10,8 +10,8 @@ const fInferred = ({ a = 0 } = {}) => a;
 >  : ^^^^^^
 >0 : 0
 >  : ^
->{} : { a?: number | undefined; }
->   : ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+>{} : {}
+>   : ^^
 >a : number
 >  : ^^^^^^
 

tests/baselines/reference/contextualTypeForInitalizedVariablesFiltersUndefined.types

@@ -53,8 +53,8 @@ try {
 >  : ^^^^^^
 >1 : 1
 >  : ^
->{ } : { e?: number | undefined; }
->    : ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+>{ } : {}
+>    : ^^
 
 } catch {
     console.error("error");

tests/baselines/reference/controlFlowDestructuringVariablesInTryCatch.types

@@ -11,8 +11,8 @@ declarationsAndAssignments.ts(63,13): error TS2493: Tuple type '[number]' of len
 declarationsAndAssignments.ts(63,16): error TS2493: Tuple type '[number]' of length '1' has no element at index '2'.
 declarationsAndAssignments.ts(67,9): error TS2461: Type '{}' is not an array type.
 declarationsAndAssignments.ts(68,9): error TS2461: Type '{ 0: number; 1: number; }' is not an array type.
-declarationsAndAssignments.ts(73,11): error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
-declarationsAndAssignments.ts(73,14): error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
+declarationsAndAssignments.ts(73,11): error TS2339: Property 'a' does not exist on type '{}'.
+declarationsAndAssignments.ts(73,14): error TS2339: Property 'b' does not exist on type '{}'.
 declarationsAndAssignments.ts(74,11): error TS2339: Property 'a' does not exist on type 'undefined[]'.
 declarationsAndAssignments.ts(74,14): error TS2339: Property 'b' does not exist on type 'undefined[]'.
 declarationsAndAssignments.ts(106,17): error TS2741: Property 'x' is missing in type '{ y: false; }' but required in type '{ x: any; y?: boolean; }'.
@@ -122,9 +122,9 @@ declarationsAndAssignments.ts(138,9): error TS2322: Type 'number' is not assigna
     function f10() {
         var { a, b } = {};  // Error
               ~
-!!! error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
+!!! error TS2339: Property 'a' does not exist on type '{}'.
                  ~
-!!! error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
+!!! error TS2339: Property 'b' does not exist on type '{}'.
         var { a, b } = [];  // Error
               ~
 !!! error TS2339: Property 'a' does not exist on type 'undefined[]'.

tests/baselines/reference/declarationsAndAssignments.errors.txt

@@ -486,8 +486,8 @@ function f10() {
 >  : ^^^
 >b : any
 >  : ^^^
->{} : { a: any; b: any; }
->   : ^^^^^^^^^^^^^^^^^^^
+>{} : {}
+>   : ^^
 
     var { a, b } = [];  // Error
 >a : any