Reuse operandType in checkPrefixUnaryExpression (#53682)

jakebailey · web-flow · commit 7f6376794e23 · 2023-04-06T13:37:12.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -36120,7 +36120,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 }
                 return getUnaryResultType(operandType);
             case SyntaxKind.ExclamationToken:
-                checkTruthinessExpression(node.operand);
+                checkTruthinessOfType(operandType, node.operand);
                 const facts = getTypeFacts(operandType) & (TypeFacts.Truthy | TypeFacts.Falsy);
                 return facts === TypeFacts.Truthy ? falseType :
                     facts === TypeFacts.Falsy ? trueType :
diff --git a/tests/baselines/reference/nestedUnaryExpressionHang.errors.txt b/tests/baselines/reference/nestedUnaryExpressionHang.errors.txt
@@ -0,0 +1,11 @@
+tests/cases/compiler/nestedUnaryExpressionHang.ts(1,6): error TS2363: The right-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.
+tests/cases/compiler/nestedUnaryExpressionHang.ts(1,34): error TS1109: Expression expected.
+
+
+==== tests/cases/compiler/nestedUnaryExpressionHang.ts (2 errors) ====
+    3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2363: The right-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.
+                                     
+!!! error TS1109: Expression expected.
+    
diff --git a/tests/baselines/reference/nestedUnaryExpressionHang.js b/tests/baselines/reference/nestedUnaryExpressionHang.js
@@ -0,0 +1,6 @@
+//// [nestedUnaryExpressionHang.ts]
+3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+
+//// [nestedUnaryExpressionHang.js]
+3333 % !!!!!!!!!!!!!!!!!!!!!!!!!!!!;
diff --git a/tests/baselines/reference/nestedUnaryExpressionHang.symbols b/tests/baselines/reference/nestedUnaryExpressionHang.symbols
@@ -0,0 +1,4 @@
+=== tests/cases/compiler/nestedUnaryExpressionHang.ts ===
+
+3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
diff --git a/tests/baselines/reference/nestedUnaryExpressionHang.types b/tests/baselines/reference/nestedUnaryExpressionHang.types
@@ -0,0 +1,35 @@
+=== tests/cases/compiler/nestedUnaryExpressionHang.ts ===
+3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+>3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!! : number
+>3333 : 3333
+>!!!!!!!!!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!!! : boolean
+>!!!!!!!!!!!! : boolean
+>!!!!!!!!!!! : boolean
+>!!!!!!!!!! : boolean
+>!!!!!!!!! : boolean
+>!!!!!!!! : boolean
+>!!!!!!! : boolean
+>!!!!!! : boolean
+>!!!!! : boolean
+>!!!! : boolean
+>!!! : boolean
+>!! : boolean
+>! : boolean
+
+> : any
+
diff --git a/tests/cases/compiler/nestedUnaryExpressionHang.ts b/tests/cases/compiler/nestedUnaryExpressionHang.ts
@@ -0,0 +1 @@
+3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Original file line number	Diff line number	Diff line change
`@@ -36120,7 +36120,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`36120`	`36120`	`}`
`36121`	`36121`	`return getUnaryResultType(operandType);`
`36122`	`36122`	`case SyntaxKind.ExclamationToken:`
`36123`		`- checkTruthinessExpression(node.operand);`
	`36123`	`+ checkTruthinessOfType(operandType, node.operand);`
`36124`	`36124`	`const facts = getTypeFacts(operandType) & (TypeFacts.Truthy \| TypeFacts.Falsy);`
`36125`	`36125`	`return facts === TypeFacts.Truthy ? falseType :`
`36126`	`36126`	`facts === TypeFacts.Falsy ? trueType :`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +=== tests/cases/compiler/nestedUnaryExpressionHang.ts ===
++
 +3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!
++