Skip to content

No completion for string literal in binary equality #13789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandersn opened this issue Jan 31, 2017 · 0 comments
Closed

No completion for string literal in binary equality #13789

sandersn opened this issue Jan 31, 2017 · 0 comments
Assignees
Labels
Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Fixed A PR has been merged for this issue

Comments

@sandersn
Copy link
Member

TypeScript Version: nightly (31/1/2017)

Code

type As = 'arf' | 'abacus' | 'abaddon';
let a: As;
if (a === 'ab/**/

Expected behavior:

Two line completion: ["abacus", "abaddon"].

Actual behavior:
File-based symbol completion.

Notes:

  1. This works for assignments (a = 'ab/**/) and function calls (f('ab/**/)) already. It should also work for comparisons to make the discriminated union pattern work better.
  2. I only tried this in VS Code. But it should probably work anywhere that supports ' as a completion character.
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor labels Jan 31, 2017
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Feb 1, 2017
@mhegazy mhegazy self-assigned this Feb 1, 2017
@mhegazy mhegazy added this to the TypeScript 2.2 milestone Feb 1, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants